[GitHub] [commons-lang] EACUAMBA closed pull request #889: Added method to convert Object to String that support null values.

EACUAMBA closed pull request #889: Added method to convert Object to String that support null values. URL: https://github.com/apache/commons-lang/pull/889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [commons-lang] EACUAMBA commented on a diff in pull request #889: Added method to convert Object to String that support null values.

EACUAMBA commented on code in PR #889: URL: https://github.com/apache/commons-lang/pull/889#discussion_r862528440 ## src/main/java/org/apache/commons/lang3/StringUtils.java: ## @@ -1588,6 +1588,59 @@ public static String defaultString(final String str, final String

[GitHub] [commons-lang] kinow commented on a diff in pull request #889: Added method to convert Object to String that support null values.

kinow commented on code in PR #889: URL: https://github.com/apache/commons-lang/pull/889#discussion_r862522289 ## src/main/java/org/apache/commons/lang3/StringUtils.java: ## @@ -1588,6 +1588,59 @@ public static String defaultString(final String str, final String nullDefault) {

[jira] [Work logged] (COLLECTIONS-811) Consider integration Guava testlib tests

[ https://issues.apache.org/jira/browse/COLLECTIONS-811?focusedWorklogId=764804=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-764804 ] ASF GitHub Bot logged work on COLLECTIONS-811: -- Author: ASF

[GitHub] [commons-collections] ben-manes commented on a diff in pull request #301: [COLLECTIONS-811] Integrate Guava Testlib tests for Apache Commons Collections

ben-manes commented on code in PR #301: URL: https://github.com/apache/commons-collections/pull/301#discussion_r862521177 ## src/test/java/org/apache/commons/collections4/GuavaTestlibTest.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [commons-lang] EACUAMBA opened a new pull request, #889: Added method to convert Object to String that support null values.

EACUAMBA opened a new pull request, #889: URL: https://github.com/apache/commons-lang/pull/889 I added a method to help people convert any object to String or return an empty String. I added this methods because I was facing a problem with convert Wrap classes like Integer, Double

[GitHub] [commons-lang] EACUAMBA closed pull request #888: Convert object to String.

EACUAMBA closed pull request #888: Convert object to String. URL: https://github.com/apache/commons-lang/pull/888 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [commons-lang] EACUAMBA opened a new pull request, #888: Convert object to String.

EACUAMBA opened a new pull request, #888: URL: https://github.com/apache/commons-lang/pull/888 I added two methods to convert Objects to String. I did it because I was facing a problem to convert Wraper objects to String and lead with NullPointerException. With this two method you

[GitHub] [commons-bcel] timboudreau closed pull request #125: Fix IAE when calling `toString(ConstantPool)` on a `Module` or `ModuleRequires`

timboudreau closed pull request #125: Fix IAE when calling `toString(ConstantPool)` on a `Module` or `ModuleRequires` URL: https://github.com/apache/commons-bcel/pull/125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [commons-bcel] timboudreau commented on pull request #125: Fix IAE when calling `toString(ConstantPool)` on a `Module` or `ModuleRequires`

timboudreau commented on PR #125: URL: https://github.com/apache/commons-bcel/pull/125#issuecomment-1114302035 The module info file in the test I provided _is_ a real module info file - just base-64 encoded. But whatever. Closing. -- This is an automated message from the Apache Git

[GitHub] [commons-lang] garydgregory merged pull request #886: Bump github/codeql-action from 1 to 2

garydgregory merged PR #886: URL: https://github.com/apache/commons-lang/pull/886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-bcel] garydgregory commented on pull request #125: Fix IAE when calling `toString(ConstantPool)` on a `Module` or `ModuleRequires`

garydgregory commented on PR #125: URL: https://github.com/apache/commons-bcel/pull/125#issuecomment-1114286993 Hi @timboudreau I appologize for not being clearer in my comment https://github.com/apache/commons-bcel/pull/125#issuecomment-1113740147 There is now a fix and a test in

[GitHub] [commons-bcel] timboudreau commented on pull request #125: Fix IAE when calling `toString(ConstantPool)` on a `Module` or `ModuleRequires`

timboudreau commented on PR #125: URL: https://github.com/apache/commons-bcel/pull/125#issuecomment-1114260729 I see a change that blindly casts to ConstantUtf8 has been made in the trunk, now creating a conflict with this PR. I have no idea if the blind cast is safe (it does not

[GitHub] [commons-bcel] timboudreau commented on pull request #125: Fix IAE when calling `toString(ConstantPool)` on a `Module` or `ModuleRequires`

timboudreau commented on PR #125: URL: https://github.com/apache/commons-bcel/pull/125#issuecomment-1114259680 Updated the PR branch to no longer call `StringBuilder.isEmpty()` in tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (DBCP-585) Connection level JMX queries result in concurrent access to connection objects, causing errors

[ https://issues.apache.org/jira/browse/DBCP-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530521#comment-17530521 ] Gary D. Gregory commented on DBCP-585: -- Hi [~psteitz] Do you think the PR's test is enough to validate

[GitHub] [commons-geometry] asfgit merged pull request #198: Addressing sonar issues

asfgit merged PR #198: URL: https://github.com/apache/commons-geometry/pull/198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (GEOMETRY-144) Review API in "hull" module

[ https://issues.apache.org/jira/browse/GEOMETRY-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530519#comment-17530519 ] Matt Juntunen commented on GEOMETRY-144: I'm thinking it would be useful to apply the builder

[GitHub] [commons-daemon] garydgregory commented on pull request #32: DAEMON-336 - If lCallbacks is empty don't call the fnCallbacks to avoid an ACCESS_VIOLATION

garydgregory commented on PR #32: URL: https://github.com/apache/commons-daemon/pull/32#issuecomment-1114211791 Any luck reproducing this issue or including changes for the upcoming RC? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [commons-daemon] garydgregory commented on a diff in pull request #39: Fix for https://issues.redhat.com/browse/JBCS-1261

garydgregory commented on code in PR #39: URL: https://github.com/apache/commons-daemon/pull/39#discussion_r862461720 ## src/native/windows/src/rprocess.c: ## @@ -316,13 +373,16 @@ static BOOL __apxProcessClose(APXHANDLE hProcess) lpProc = APXHANDLE_DATA(hProcess);

[jira] [Work logged] (IO-768) Add reserved Windows file names CONIN$ and CONOUT$ to FileSystem

[ https://issues.apache.org/jira/browse/IO-768?focusedWorklogId=764754=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-764754 ] ASF GitHub Bot logged work on IO-768: - Author: ASF GitHub Bot Created

[GitHub] [commons-io] michael-o commented on a diff in pull request #355: IO-768: Add reserved Windows file names CONIN$ and CONOUT$ to FileSystem

michael-o commented on code in PR #355: URL: https://github.com/apache/commons-io/pull/355#discussion_r862447101 ## src/main/java/org/apache/commons/io/FileSystem.java: ## @@ -73,6 +73,8 @@ public enum FileSystem { * * @see

[GitHub] [commons-daemon] jfclere commented on a diff in pull request #39: Fix for https://issues.redhat.com/browse/JBCS-1261

jfclere commented on code in PR #39: URL: https://github.com/apache/commons-daemon/pull/39#discussion_r862443964 ## src/native/windows/src/rprocess.c: ## @@ -316,13 +373,16 @@ static BOOL __apxProcessClose(APXHANDLE hProcess) lpProc = APXHANDLE_DATA(hProcess);

[GitHub] [commons-daemon] markt-asf commented on a diff in pull request #39: Fix for https://issues.redhat.com/browse/JBCS-1261

markt-asf commented on code in PR #39: URL: https://github.com/apache/commons-daemon/pull/39#discussion_r862440496 ## src/native/windows/src/rprocess.c: ## @@ -316,13 +373,16 @@ static BOOL __apxProcessClose(APXHANDLE hProcess) lpProc = APXHANDLE_DATA(hProcess);

[GitHub] [commons-daemon] jfclere commented on a diff in pull request #39: Fix for https://issues.redhat.com/browse/JBCS-1261

jfclere commented on code in PR #39: URL: https://github.com/apache/commons-daemon/pull/39#discussion_r862440196 ## src/native/windows/src/rprocess.c: ## @@ -316,13 +373,16 @@ static BOOL __apxProcessClose(APXHANDLE hProcess) lpProc = APXHANDLE_DATA(hProcess);

[GitHub] [commons-daemon] markt-asf commented on a diff in pull request #39: Fix for https://issues.redhat.com/browse/JBCS-1261

markt-asf commented on code in PR #39: URL: https://github.com/apache/commons-daemon/pull/39#discussion_r862439030 ## src/native/windows/src/rprocess.c: ## @@ -316,13 +373,16 @@ static BOOL __apxProcessClose(APXHANDLE hProcess) lpProc = APXHANDLE_DATA(hProcess);

[jira] [Commented] (JEXL-367) Deprecate -> and support =>

[ https://issues.apache.org/jira/browse/JEXL-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530490#comment-17530490 ] Dmitri Blinov commented on JEXL-367: [~henrib] In short, in JS world fat arrow functions have their own

[jira] [Work logged] (COLLECTIONS-811) Consider integration Guava testlib tests

[ https://issues.apache.org/jira/browse/COLLECTIONS-811?focusedWorklogId=764732=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-764732 ] ASF GitHub Bot logged work on COLLECTIONS-811: -- Author: ASF

[GitHub] [commons-collections] codecov-commenter commented on pull request #301: [COLLECTIONS-811] Integrate Guava Testlib tests for Apache Commons Collections

codecov-commenter commented on PR #301: URL: https://github.com/apache/commons-collections/pull/301#issuecomment-1114144824 #

[jira] [Work logged] (COLLECTIONS-811) Consider integration Guava testlib tests

[ https://issues.apache.org/jira/browse/COLLECTIONS-811?focusedWorklogId=764731=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-764731 ] ASF GitHub Bot logged work on COLLECTIONS-811: -- Author: ASF

[GitHub] [commons-collections] kinow commented on a diff in pull request #301: [COLLECTIONS-811] Integrate Guava Testlib tests for Apache Commons Collections

kinow commented on code in PR #301: URL: https://github.com/apache/commons-collections/pull/301#discussion_r862427902 ## src/test/java/org/apache/commons/collections4/GuavaTestlibTest.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one