[GitHub] [commons-collections] Claudenw commented on pull request #320: Collections 824

Claudenw commented on PR #320: URL: https://github.com/apache/commons-collections/pull/320#issuecomment-1179661751 I am away for the next 1.5 weeks but will make that change when I return On Sun, Jul 10, 2022, 05:11 Sam Ng ***@***.***> wrote: > @Claudenw

[jira] [Work logged] (COLLECTIONS-806) Upgrade junit.framework.Test to org.junit.jupiter.api.Test

[ https://issues.apache.org/jira/browse/COLLECTIONS-806?focusedWorklogId=789303&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-789303 ] ASF GitHub Bot logged work on COLLECTIONS-806: -- Author: ASF

[GitHub] [commons-collections] samabcde commented on pull request #293: [COLLECTIONS-806] Continue JUnit v5

samabcde commented on PR #293: URL: https://github.com/apache/commons-collections/pull/293#issuecomment-1179653774 > @nhojpatrick maybe [b705855](https://github.com/apache/commons-collections/commit/b705855353272a1a50aee36cef21fb6bfbcc6da2) ? That commit only fix one of the flaky te

[GitHub] [commons-collections] samabcde commented on pull request #320: Collections 824

samabcde commented on PR #320: URL: https://github.com/apache/commons-collections/pull/320#issuecomment-1179652334 @Claudenw Would you mind updating `import org.junit.Test;` to `import org.junit.jupiter.api.Test;` in [src/test/java/org/apache/commons/collections4/bloomfilter/A

[jira] [Commented] (COLLECTIONS-807) Upgrade org.junit.Test to org.junit.jupiter.api.Test

[ https://issues.apache.org/jira/browse/COLLECTIONS-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17564640#comment-17564640 ] Ng Tsz Sum commented on COLLECTIONS-807: Checked out  [https://github.com/ap

[jira] (COLLECTIONS-806) Upgrade junit.framework.Test to org.junit.jupiter.api.Test

[ https://issues.apache.org/jira/browse/COLLECTIONS-806 ] Ng Tsz Sum deleted comment on COLLECTIONS-806: was (Author: samabcde): Checked out https://github.com/apache/commons-collections/commit/29d79003ea73528796bed63bf81b1cc508b1f215 sang

[jira] [Commented] (COLLECTIONS-806) Upgrade junit.framework.Test to org.junit.jupiter.api.Test

[ https://issues.apache.org/jira/browse/COLLECTIONS-806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17564639#comment-17564639 ] Ng Tsz Sum commented on COLLECTIONS-806: Checked out https://github.com/apa

[GitHub] [commons-dbcp] arturobernalg closed pull request #129: Simplify conditions and avoid extra checks.

arturobernalg closed pull request #129: Simplify conditions and avoid extra checks. URL: https://github.com/apache/commons-dbcp/pull/129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (COLLECTIONS-824) BloomFilter: Optimize SimpleHasher.forEachIndex and SimpleHasher name change

[ https://issues.apache.org/jira/browse/COLLECTIONS-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17564617#comment-17564617 ] Alex Herbert commented on COLLECTIONS-824: -- I would not add the double for

[GitHub] [commons-collections] aherbert commented on pull request #320: Collections 824

aherbert commented on PR #320: URL: https://github.com/apache/commons-collections/pull/320#issuecomment-1179602765 The hasher `uniqueIndices(Shape)` method has not been updated to match the `indices(Shape)` method. This error really should have been detected by a unit test. E.g. Cre

[GitHub] [commons-dbcp] arturobernalg closed pull request #112: Minor changes

arturobernalg closed pull request #112: Minor changes URL: https://github.com/apache/commons-dbcp/pull/112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [commons-dbcp] garydgregory commented on pull request #112: Minor changes

garydgregory commented on PR #112: URL: https://github.com/apache/commons-dbcp/pull/112#issuecomment-1179599509 Hi @arturobernalg I simplified `BasicDataSource` even more. Please rebase on git master. -- This is an automated message from the Apache Git Service. To respond to the messag

[jira] [Commented] (COLLECTIONS-824) BloomFilter: Optimize SimpleHasher.forEachIndex and SimpleHasher name change

[ https://issues.apache.org/jira/browse/COLLECTIONS-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17564593#comment-17564593 ] Claude Warren commented on COLLECTIONS-824: --- I reverted the  Shape change

[jira] [Commented] (COLLECTIONS-824) BloomFilter: Optimize SimpleHasher.forEachIndex and SimpleHasher name change

[ https://issues.apache.org/jira/browse/COLLECTIONS-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17564580#comment-17564580 ] Alex Herbert commented on COLLECTIONS-824: -- The term is not a pure cubic ad

[jira] [Commented] (COLLECTIONS-824) BloomFilter: Optimize SimpleHasher.forEachIndex and SimpleHasher name change

[ https://issues.apache.org/jira/browse/COLLECTIONS-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17564570#comment-17564570 ] Claude Warren commented on COLLECTIONS-824: --- Pull request 320 opened to re

[GitHub] [commons-collections] codecov-commenter commented on pull request #320: Collections 824

codecov-commenter commented on PR #320: URL: https://github.com/apache/commons-collections/pull/320#issuecomment-1179525887 # [Codecov](https://codecov.io/gh/apache/commons-collections/pull/320?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[jira] [Commented] (COLLECTIONS-824) BloomFilter: Optimize SimpleHasher.forEachIndex and SimpleHasher name change

[ https://issues.apache.org/jira/browse/COLLECTIONS-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17564564#comment-17564564 ] Claude Warren commented on COLLECTIONS-824: --- I have modified Shape so that