[jira] [Commented] (COMPRESS-635) switch system.err/system.out printlns to be log4j logging

2022-11-29 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641112#comment-17641112 ] Michael Osipov commented on COMPRESS-635: - Hell no, just use a facade SLF4J. Don't impose

[GitHub] [commons-lang] PiMaDaum commented on pull request #992: NumberUtils check if Number is null or zero

2022-11-29 Thread GitBox
PiMaDaum commented on PR #992: URL: https://github.com/apache/commons-lang/pull/992#issuecomment-1331475163 Sorry, I have forget to comment the new method and clean unused imports. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [commons-lang] PiMaDaum closed pull request #992: NumberUtils check if Number is null or zero

2022-11-29 Thread GitBox
PiMaDaum closed pull request #992: NumberUtils check if Number is null or zero URL: https://github.com/apache/commons-lang/pull/992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [commons-lang] codecov-commenter commented on pull request #992: NumberUtils check if Number is null or zero

2022-11-29 Thread GitBox
codecov-commenter commented on PR #992: URL: https://github.com/apache/commons-lang/pull/992#issuecomment-1331461814 #

[jira] [Created] (COMPRESS-635) switch system.err/system.out printlns to be log4j logging

2022-11-29 Thread PJ Fanning (Jira)
PJ Fanning created COMPRESS-635: --- Summary: switch system.err/system.out printlns to be log4j logging Key: COMPRESS-635 URL: https://issues.apache.org/jira/browse/COMPRESS-635 Project: Commons Compress

[GitHub] [commons-compress] garydgregory closed pull request #303: [SECURITY] Fix Zip Slip Vulnerability

2022-11-29 Thread GitBox
garydgregory closed pull request #303: [SECURITY] Fix Zip Slip Vulnerability URL: https://github.com/apache/commons-compress/pull/303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [commons-compress] garydgregory commented on pull request #303: [SECURITY] Fix Zip Slip Vulnerability

2022-11-29 Thread GitBox
garydgregory commented on PR #303: URL: https://github.com/apache/commons-compress/pull/303#issuecomment-1331448704 Closing, tests are not a security risk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [commons-bcel] nbauma109 commented on pull request #178: verifier tests on various opcodes and fixed typo testCommonsLang1->2

2022-11-29 Thread GitBox
nbauma109 commented on PR #178: URL: https://github.com/apache/commons-bcel/pull/178#issuecomment-1331324271 Coverage report didn't show up. Check here https://github.com/nbauma109/commons-bcel/pull/24. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [commons-exec] arturobernalg commented on pull request #27: [EXEC-114] - Migrate to Junit 5

2022-11-29 Thread GitBox
arturobernalg commented on PR #27: URL: https://github.com/apache/commons-exec/pull/27#issuecomment-1331293219 > @arturobernalg > Hi, > This component is now on Java 8. Hey @garydgregory I think its already done. TY -- This is an automated message from the Apache

[GitHub] [commons-compress] kinow merged pull request #333: Bump slf4j-api from 2.0.4 to 2.0.5

2022-11-29 Thread GitBox
kinow merged PR #333: URL: https://github.com/apache/commons-compress/pull/333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (COMPRESS-623) make ZipFile's getRawInputStream usable when local headers are not read

2022-11-29 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved COMPRESS-623. -- Fix Version/s: 1.23 Resolution: Fixed > make ZipFile's getRawInputStream

[jira] [Work logged] (COMPRESS-623) make ZipFile's getRawInputStream usable when local headers are not read

2022-11-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-623?focusedWorklogId=829840=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-829840 ] ASF GitHub Bot logged work on COMPRESS-623: --- Author: ASF GitHub Bot

[GitHub] [commons-compress] garydgregory merged pull request #306: COMPRESS-623: make ZipFile's getRawInputStream usable when local headers are not read

2022-11-29 Thread GitBox
garydgregory merged PR #306: URL: https://github.com/apache/commons-compress/pull/306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-compress] dependabot[bot] opened a new pull request, #333: Bump slf4j-api from 2.0.4 to 2.0.5

2022-11-29 Thread GitBox
dependabot[bot] opened a new pull request, #333: URL: https://github.com/apache/commons-compress/pull/333 Bumps [slf4j-api](https://github.com/qos-ch/slf4j) from 2.0.4 to 2.0.5. Commits https://github.com/qos-ch/slf4j/commit/7e62e1e6917e19e6eeb8faf97daa9e2469bc946d;>7e62e1e

[jira] [Resolved] (VFS-828) Dependency hadoop-hdfs-client should be optional

2022-11-29 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/VFS-828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved VFS-828. - Resolution: Fixed It already is, see git master. > Dependency hadoop-hdfs-client should be

[jira] [Created] (NET-717) FTPClient: Encapsulate completePendingCommand in returned outputstream

2022-11-29 Thread Jira
Julien Béti created NET-717: --- Summary: FTPClient: Encapsulate completePendingCommand in returned outputstream Key: NET-717 URL: https://issues.apache.org/jira/browse/NET-717 Project: Commons Net

[GitHub] [commons-vfs] garydgregory merged pull request #339: Bump commons.pmd.version from 6.51.0 to 6.52.0

2022-11-29 Thread GitBox
garydgregory merged PR #339: URL: https://github.com/apache/commons-vfs/pull/339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-vfs] dependabot[bot] opened a new pull request, #340: Bump checkstyle from 9.3 to 10.5.0

2022-11-29 Thread GitBox
dependabot[bot] opened a new pull request, #340: URL: https://github.com/apache/commons-vfs/pull/340 Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 9.3 to 10.5.0. Release notes Sourced from https://github.com/checkstyle/checkstyle/releases;>checkstyle's

[GitHub] [commons-vfs] dependabot[bot] opened a new pull request, #339: Bump commons.pmd.version from 6.51.0 to 6.52.0

2022-11-29 Thread GitBox
dependabot[bot] opened a new pull request, #339: URL: https://github.com/apache/commons-vfs/pull/339 Bumps `commons.pmd.version` from 6.51.0 to 6.52.0. Updates `pmd-core` from 6.51.0 to 6.52.0 Release notes Sourced from https://github.com/pmd/pmd/releases;>pmd-core's releases.

[GitHub] [commons-vfs] dependabot[bot] opened a new pull request, #338: Bump slf4j-simple from 1.7.26 to 2.0.5

2022-11-29 Thread GitBox
dependabot[bot] opened a new pull request, #338: URL: https://github.com/apache/commons-vfs/pull/338 Bumps [slf4j-simple](https://github.com/qos-ch/slf4j) from 1.7.26 to 2.0.5. Commits https://github.com/qos-ch/slf4j/commit/7e62e1e6917e19e6eeb8faf97daa9e2469bc946d;>7e62e1e

[GitHub] [commons-bcel] nbauma109 commented on a diff in pull request #177: Bcelifier stackmap support verifier

2022-11-29 Thread GitBox
nbauma109 commented on code in PR #177: URL: https://github.com/apache/commons-bcel/pull/177#discussion_r1034761303 ## src/test/resources/StackMapExample2.java: ## @@ -0,0 +1,8 @@ +public class StackMapExample2 { + Review Comment: Commented rather than javadoc-ed as it is

[GitHub] [commons-bcel] nbauma109 commented on pull request #177: Bcelifier stackmap support verifier

2022-11-29 Thread GitBox
nbauma109 commented on PR #177: URL: https://github.com/apache/commons-bcel/pull/177#issuecomment-1330659897 > @nbauma109 Rebase on git master to pick up `StackMapTest`. Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [commons-bcel] nbauma109 commented on a diff in pull request #177: Bcelifier stackmap support verifier

2022-11-29 Thread GitBox
nbauma109 commented on code in PR #177: URL: https://github.com/apache/commons-bcel/pull/177#discussion_r1034748724 ## src/main/java/org/apache/bcel/classfile/Code.java: ## @@ -247,6 +247,20 @@ public LineNumberTable getLineNumberTable() { return null; } +

[GitHub] [commons-bcel] garydgregory commented on a diff in pull request #177: Bcelifier stackmap support verifier

2022-11-29 Thread GitBox
garydgregory commented on code in PR #177: URL: https://github.com/apache/commons-bcel/pull/177#discussion_r1034747557 ## src/main/java/org/apache/bcel/classfile/Code.java: ## @@ -247,6 +247,20 @@ public LineNumberTable getLineNumberTable() { return null; } +

[GitHub] [commons-bcel] nbauma109 commented on a diff in pull request #177: Bcelifier stackmap support verifier

2022-11-29 Thread GitBox
nbauma109 commented on code in PR #177: URL: https://github.com/apache/commons-bcel/pull/177#discussion_r1034720605 ## src/main/java/org/apache/bcel/classfile/Code.java: ## @@ -247,6 +247,20 @@ public LineNumberTable getLineNumberTable() { return null; } +

[GitHub] [commons-bcel] garydgregory commented on pull request #177: Bcelifier stackmap support verifier

2022-11-29 Thread GitBox
garydgregory commented on PR #177: URL: https://github.com/apache/commons-bcel/pull/177#issuecomment-1330604892 @nbauma109 Rebase on git master to pick up `StackMapTest`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [commons-bcel] codecov-commenter commented on pull request #177: Bcelifier stackmap support verifier

2022-11-29 Thread GitBox
codecov-commenter commented on PR #177: URL: https://github.com/apache/commons-bcel/pull/177#issuecomment-1330603035 #

[GitHub] [commons-bcel] nbauma109 commented on a diff in pull request #177: Bcelifier stackmap support verifier

2022-11-29 Thread GitBox
nbauma109 commented on code in PR #177: URL: https://github.com/apache/commons-bcel/pull/177#discussion_r1034705119 ## src/main/java/org/apache/bcel/classfile/StackMapType.java: ## @@ -29,9 +29,9 @@ * @see StackMap * @see Const */ -public final class StackMapType

[jira] [Commented] (VALIDATOR-487) EmailValidator validates too much

2022-11-29 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/VALIDATOR-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640667#comment-17640667 ] Michael Osipov commented on VALIDATOR-487: -- I'd say that one needs for the latest ASCII-only

[GitHub] [commons-bcel] nbauma109 commented on a diff in pull request #177: Bcelifier stackmap support verifier

2022-11-29 Thread GitBox
nbauma109 commented on code in PR #177: URL: https://github.com/apache/commons-bcel/pull/177#discussion_r1034702240 ## src/main/java/org/apache/bcel/classfile/StackMap.java: ## @@ -135,7 +135,7 @@ public StackMapEntry[] getStackMap() { public void setStackMap(final

[GitHub] [commons-bcel] garydgregory commented on a diff in pull request #177: Bcelifier stackmap support verifier

2022-11-29 Thread GitBox
garydgregory commented on code in PR #177: URL: https://github.com/apache/commons-bcel/pull/177#discussion_r1034692847 ## src/test/resources/StackMapExample2.java: ## @@ -0,0 +1,8 @@ +public class StackMapExample2 { + Review Comment: Javadoc what this tests. ##

[GitHub] [commons-bcel] nbauma109 opened a new pull request, #177: Bcelifier stackmap support verifier

2022-11-29 Thread GitBox
nbauma109 opened a new pull request, #177: URL: https://github.com/apache/commons-bcel/pull/177 * Bcelifier stackmap support * BCELifier generates the stack map table so that the generated class passes the Java verifier checks. * added some test inputs StackMapExample and

[jira] [Commented] (VALIDATOR-487) EmailValidator validates too much

2022-11-29 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/VALIDATOR-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640652#comment-17640652 ] Gary D. Gregory commented on VALIDATOR-487: --- Should we have different validation for

[jira] [Comment Edited] (JEXL-388) v3.3-SNAPSHOT doesn't find public getter as property

2022-11-29 Thread Henri Biestro (Jira)
[ https://issues.apache.org/jira/browse/JEXL-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640643#comment-17640643 ] Henri Biestro edited comment on JEXL-388 at 11/29/22 12:06 PM: --- Current trunk

[jira] [Comment Edited] (JEXL-388) v3.3-SNAPSHOT doesn't find public getter as property

2022-11-29 Thread Henri Biestro (Jira)
[ https://issues.apache.org/jira/browse/JEXL-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640643#comment-17640643 ] Henri Biestro edited comment on JEXL-388 at 11/29/22 12:04 PM: --- Current trunk

[jira] [Comment Edited] (JEXL-388) v3.3-SNAPSHOT doesn't find public getter as property

2022-11-29 Thread Henri Biestro (Jira)
[ https://issues.apache.org/jira/browse/JEXL-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640643#comment-17640643 ] Henri Biestro edited comment on JEXL-388 at 11/29/22 12:03 PM: --- Current trunk

[jira] [Commented] (JEXL-388) v3.3-SNAPSHOT doesn't find public getter as property

2022-11-29 Thread Henri Biestro (Jira)
[ https://issues.apache.org/jira/browse/JEXL-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640643#comment-17640643 ] Henri Biestro commented on JEXL-388: Current trunk default is to restrict what JEXL can see using

[jira] [Updated] (VALIDATOR-487) EmailValidator validates too much

2022-11-29 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/VALIDATOR-487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated VALIDATOR-487: - Description: Coming from https://github.com/everit-org/json-schema which uses

[jira] [Created] (VALIDATOR-487) EmailValidator validates too much

2022-11-29 Thread Michael Osipov (Jira)
Michael Osipov created VALIDATOR-487: Summary: EmailValidator validates too much Key: VALIDATOR-487 URL: https://issues.apache.org/jira/browse/VALIDATOR-487 Project: Commons Validator

[jira] [Commented] (FILEUPLOAD-309) Release version 2.0.0

2022-11-29 Thread Flying Wolf (Jira)
[ https://issues.apache.org/jira/browse/FILEUPLOAD-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640504#comment-17640504 ] Flying Wolf commented on FILEUPLOAD-309: Maybe it's time to stop with Commons File Upload?