[
https://issues.apache.org/jira/browse/CSV-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652125#comment-17652125
]
Damjan Jovanovic edited comment on CSV-141 at 12/27/22 5:43 AM:
--
[
https://issues.apache.org/jira/browse/CSV-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652125#comment-17652125
]
Damjan Jovanovic commented on CSV-141:
--
This kind of patch:
{code:java}
// code placeho
[
https://issues.apache.org/jira/browse/CSV-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652116#comment-17652116
]
Damjan Jovanovic commented on CSV-141:
--
I've made a patch for this and added a pull req
DamjanJovanovic opened a new pull request, #295:
URL: https://github.com/apache/commons-csv/pull/295
As per issue https://issues.apache.org/jira/browse/CSV-141 and based on what
we did in Apache OpenOffice https://bz.apache.org/ooo/show_bug.cgi?id=126805
This adds a setting, allowTrai
[
https://issues.apache.org/jira/browse/CSV-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652083#comment-17652083
]
Damjan Jovanovic commented on CSV-141:
--
[~nhatminh12369] "But if I open the file on Mi
[
https://issues.apache.org/jira/browse/COLLECTIONS-806?focusedWorklogId=835703&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-835703
]
ASF GitHub Bot logged work on COLLECTIONS-806:
--
Author: ASF
codecov-commenter commented on PR #371:
URL:
https://github.com/apache/commons-collections/pull/371#issuecomment-1365467714
#
[Codecov](https://codecov.io/gh/apache/commons-collections/pull/371?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
[
https://issues.apache.org/jira/browse/COLLECTIONS-806?focusedWorklogId=835702&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-835702
]
ASF GitHub Bot logged work on COLLECTIONS-806:
--
Author: ASF
pas725 opened a new pull request, #371:
URL: https://github.com/apache/commons-collections/pull/371
**Jira**: https://issues.apache.org/jira/browse/COLLECTIONS-806
**Description**: COLLECTIONS-806 is a subtask of the main task
[COLLECTIONS-777-Fully migrate to JUnit
5](https://issues
garydgregory commented on code in PR #344:
URL: https://github.com/apache/commons-compress/pull/344#discussion_r1057339000
##
src/test/java/org/apache/commons/compress/harmony/pack200/tests/ArchiveTest.java:
##
@@ -25,20 +28,27 @@
import java.io.InputStreamReader;
import java.
garydgregory commented on code in PR #344:
URL: https://github.com/apache/commons-compress/pull/344#discussion_r1057339000
##
src/test/java/org/apache/commons/compress/harmony/pack200/tests/ArchiveTest.java:
##
@@ -25,20 +28,27 @@
import java.io.InputStreamReader;
import java.
henrib merged PR #149:
URL: https://github.com/apache/commons-jexl/pull/149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.a
theobisproject commented on PR #344:
URL: https://github.com/apache/commons-compress/pull/344#issuecomment-1365283815
I have replaced all the try-catch-assert patterns in the tests I migrated.
Also more tests do now use the parameterized tests for execution.
--
This is an automated messag
[
https://issues.apache.org/jira/browse/FILEUPLOAD-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652022#comment-17652022
]
Andy Seaborne commented on FILEUPLOAD-309:
--
I tried the servlet 3.1 multipar
garydgregory commented on PR #344:
URL: https://github.com/apache/commons-compress/pull/344#issuecomment-1365225577
Keep it focused on the one task please: Junit 5 😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
theobisproject commented on PR #344:
URL: https://github.com/apache/commons-compress/pull/344#issuecomment-1365219087
@garydgregory I will go through the classes and do some more migrations. Is
there anything else you would like to have changed (like using
try-with-resources, ...)?
--
Th
garydgregory commented on PR #344:
URL: https://github.com/apache/commons-compress/pull/344#issuecomment-1365207025
Hi @theobisproject
Thank you for pitching in!
No matter which way you slice it, it's going to be a large PR. The only way
I can think of making it smaller is by doing it
theobisproject commented on code in PR #344:
URL: https://github.com/apache/commons-compress/pull/344#discussion_r1057249368
##
src/test/java/org/apache/commons/compress/archivers/LongPathTest.java:
##
@@ -142,7 +140,7 @@ public void testArchive(final File file) throws Exception
garydgregory commented on code in PR #344:
URL: https://github.com/apache/commons-compress/pull/344#discussion_r1057246093
##
src/test/java/org/apache/commons/compress/archivers/LongPathTest.java:
##
@@ -142,7 +140,7 @@ public void testArchive(final File file) throws Exception {
garydgregory commented on code in PR #344:
URL: https://github.com/apache/commons-compress/pull/344#discussion_r1057246093
##
src/test/java/org/apache/commons/compress/archivers/LongPathTest.java:
##
@@ -142,7 +140,7 @@ public void testArchive(final File file) throws Exception {
codecov-commenter commented on PR #344:
URL: https://github.com/apache/commons-compress/pull/344#issuecomment-1365200978
#
[Codecov](https://codecov.io/gh/apache/commons-compress/pull/344?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term
theobisproject opened a new pull request, #344:
URL: https://github.com/apache/commons-compress/pull/344
Most tests are replaced with simple JUnit 5 tests. A small number of tests
were migrated to parameterized tests.
--
This is an automated message from the Apache Git Service.
To respond
garydgregory merged PR #97:
URL: https://github.com/apache/commons-scxml/pull/97
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@comm
23 matches
Mail list logo
