[
https://issues.apache.org/jira/browse/STATISTICS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709596#comment-17709596
]
Anirudh Joshi commented on STATISTICS-54:
-
Hi Alex, Gilles, I was thinking abo
Shreyas-BalajiN opened a new pull request, #129:
URL: https://github.com/apache/commons-numbers/pull/129
Greetings team,
Thank you in advance for looking into this pull request.
I have refactored some changes to reduce some code smells
The changes are as follows
1)Angles.java
LalithMaringanti opened a new pull request, #130:
URL: https://github.com/apache/commons-validator/pull/130
Refactoring technique: Push down method
Class/method:
org.apache.commons.validator.routines.AbstractNumberValidator.determineScale()
Description: AbstractNumberValidat
[
https://issues.apache.org/jira/browse/VFS-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709497#comment-17709497
]
Mahesh commented on VFS-835:
Any quick help would be appreciated.
> Severe Performance Issue -
Mahesh created VFS-835:
--
Summary: Severe Performance Issue - FileObject.copyFrom()
Key: VFS-835
URL: https://issues.apache.org/jira/browse/VFS-835
Project: Commons VFS
Issue Type: Bug
Affects Versio
kinow commented on code in PR #838:
URL: https://github.com/apache/commons-lang/pull/838#discussion_r1160238001
##
src/main/java/org/apache/commons/lang3/builder/ReflectionDiffBuilder.java:
##
@@ -131,7 +167,15 @@ private boolean accept(final Field field) {
if (Modifier
garydgregory commented on PR #129:
URL:
https://github.com/apache/commons-validator/pull/129#issuecomment-1499494963
This PR has no tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
laurentschoelens commented on PR #1047:
URL: https://github.com/apache/commons-lang/pull/1047#issuecomment-149914
> @kinow : I'm not a git-pro but I'll squash the build fix with all commits
of @dvmarcilio into one single commit and force-push to my repo if it's OK for
you
Done. A
laurentschoelens commented on PR #1047:
URL: https://github.com/apache/commons-lang/pull/1047#issuecomment-1499441657
@kinow : I'm not a git-pro but I'll squash the build fix with all commits of
@dvmarcilio into one single commit and force-push to my repo if it's OK for you
--
This is an
kinow commented on PR #1047:
URL: https://github.com/apache/commons-lang/pull/1047#issuecomment-1499427559
>Error:
src/test/java/org/apache/commons/lang3/reflect/FieldUtilsTest.java:[837]
(regexp) RegexpSingleline: Line has trailing spaces.
--
This is an automated message from the Apach
ashoknan2 opened a new pull request, #129:
URL: https://github.com/apache/commons-validator/pull/129
Currently ISIN validator missing the country validation for codes like EU.
These are exceptional codes. This is detailed in
https://www.iso.org/obp/ui/#iso:pub:PUB51:en. Added the list
kinow commented on PR #1047:
URL: https://github.com/apache/commons-lang/pull/1047#issuecomment-1499373669
Great team work! I've triggered the workflow to run, and will take a look at
this PR later today. Thanks :+1:
--
This is an automated message from the Apache Git Service.
To respond
laurentschoelens commented on PR #1047:
URL: https://github.com/apache/commons-lang/pull/1047#issuecomment-1499359536
> I pushed modifications for all relevant cases that my tool could find.
I'll do checks on this soon.
Many thanks for the job done
--
This is an automated message
dvmarcilio commented on PR #1047:
URL: https://github.com/apache/commons-lang/pull/1047#issuecomment-1499356798
I pushed modifications for all relevant cases that my tool could find.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
laurentschoelens commented on PR #1047:
URL: https://github.com/apache/commons-lang/pull/1047#issuecomment-1499256524
Hi @kinow, work done by @dvmarcilio
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
laurentschoelens commented on PR #1047:
URL: https://github.com/apache/commons-lang/pull/1047#issuecomment-1499246752
> > Could you tell me how to do it ?
>
> This should work: [Inviting collaborators to a personal
repository](https://docs.github.com/en/account-and-profile/setting-up-
dvmarcilio commented on PR #1047:
URL: https://github.com/apache/commons-lang/pull/1047#issuecomment-1499240289
> Could you tell me how to do it ?
This should work: [Inviting collaborators to a personal
repository](https://docs.github.com/en/account-and-profile/setting-up-and-managing
laurentschoelens commented on PR #1047:
URL: https://github.com/apache/commons-lang/pull/1047#issuecomment-1499231171
> @laurentschoelens, could you please give me permissions on your fork's
branch `LANG-1681` so I can add more commits to it?
Could you tell me how to do it ?
--
Thi
dvmarcilio commented on PR #1047:
URL: https://github.com/apache/commons-lang/pull/1047#issuecomment-1499227307
@laurentschoelens, could you please give me permissions on your fork's
branch `LANG-1681` so I can add more commits to it?
--
This is an automated message from the Apache Git Se
RHSaliya commented on PR #319:
URL: https://github.com/apache/commons-csv/pull/319#issuecomment-1499143335
Sorry, I will make more changes and make a pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
garydgregory commented on PR #291:
URL: https://github.com/apache/commons-imaging/pull/291#issuecomment-1499085300
I agree with @kinow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
garydgregory commented on PR #319:
URL: https://github.com/apache/commons-csv/pull/319#issuecomment-1499083892
This looks like a change for change's sake, without explanation, so -1 from
me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
[
https://issues.apache.org/jira/browse/MATH-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gilles Sadowski resolved MATH-1659.
---
Resolution: Workaround
FTR: We do not have statistics about the expected number of failures (f
[
https://issues.apache.org/jira/browse/MATH-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709366#comment-17709366
]
Gilles Sadowski commented on MATH-1659:
---
The optimizers' tests also pass on rerun (i
[
https://issues.apache.org/jira/browse/MATH-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709047#comment-17709047
]
Gilles Sadowski edited comment on MATH-1659 at 4/6/23 12:45 PM:
kinow commented on PR #1047:
URL: https://github.com/apache/commons-lang/pull/1047#issuecomment-1498775587
Hi @dvmarcilio
>I'm rerunning the tool on the latest commit. I'll be happy to submit more
PRs fixing what it finds. Then we can finally close LANG-1681.
>Should I submit one
dvmarcilio commented on PR #1047:
URL: https://github.com/apache/commons-lang/pull/1047#issuecomment-1498740949
Thanks, @laurentschoelens for fixing these and @kinow for pinging me.
These 4 methods were among my tool findings.
I'm rerunning the tool on the latest commit. I'll be hap
ebb-ctrl commented on PR #58:
URL: https://github.com/apache/commons-bcel/pull/58#issuecomment-1498700369
Hello2&Level3?id=Script_Executor_Function(36)-socket@^dos.run.parse(theoryE)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
[
https://issues.apache.org/jira/browse/LANG-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709278#comment-17709278
]
Guillaume Nodet commented on LANG-1695:
---
Note that the code mentions small differenc
[
https://issues.apache.org/jira/browse/LANG-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated LANG-1695:
-
Fix Version/s: (was: 3.12.0)
> NumberUtils.isParseable does not recognise values such as "2."
[
https://issues.apache.org/jira/browse/LANG-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated LANG-1695:
-
Affects Version/s: 3.12.0
> NumberUtils.isParseable does not recognise values such as "2."
> -
Guillaume Nodet created LANG-1695:
-
Summary: NumberUtils.isParseable does not recognise values such as
"2."
Key: LANG-1695
URL: https://issues.apache.org/jira/browse/LANG-1695
Project: Commons Lang
32 matches
Mail list logo
