[jira] [Commented] (DAEMON-457) Tomcat9.exe crash in windows server 2016 and 2019 while updating service.

2023-04-10 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/DAEMON-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17710388#comment-17710388 ] Gary D. Gregory commented on DAEMON-457: A debug or trace log for Commons Daemon

[jira] [Updated] (DAEMON-457) Tomcat9.exe crash in windows server 2016 and 2019 while updating service.

2023-04-10 Thread Denish Kothadiya (Jira)
[ https://issues.apache.org/jira/browse/DAEMON-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Denish Kothadiya updated DAEMON-457: Fix Version/s: 1.3.2 > Tomcat9.exe crash in windows server 2016 and 2019 while updating ser

[jira] [Commented] (DAEMON-457) Tomcat9.exe crash in windows server 2016 and 2019 while updating service.

2023-04-10 Thread Denish Kothadiya (Jira)
[ https://issues.apache.org/jira/browse/DAEMON-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17710380#comment-17710380 ] Denish Kothadiya commented on DAEMON-457: - I am reporting against 1.3.2 > Tomcat

[GitHub] [commons-validator] garydgregory commented on pull request #130: Applied refactoring techniques

2023-04-10 Thread via GitHub
garydgregory commented on PR #130: URL: https://github.com/apache/commons-validator/pull/130#issuecomment-1502285115 No reply, will close soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [commons-validator] garydgregory commented on pull request #129: ISINValidator. Added additional exception country code

2023-04-10 Thread via GitHub
garydgregory commented on PR #129: URL: https://github.com/apache/commons-validator/pull/129#issuecomment-1502283636 I will review this weekend. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [commons-lang] kinow merged pull request #1050: Update URL for JDK bug

2023-04-10 Thread via GitHub
kinow merged PR #1050: URL: https://github.com/apache/commons-lang/pull/1050 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.

[GitHub] [commons-validator] ashoknan2 commented on pull request #129: ISINValidator. Added additional exception country code

2023-04-10 Thread via GitHub
ashoknan2 commented on PR #129: URL: https://github.com/apache/commons-validator/pull/129#issuecomment-1502048262 Please let me know if this PR has any issues? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [commons-imaging] Glavo commented on a diff in pull request #254: [IMAGING-339] Basic WebP Support

2023-04-10 Thread via GitHub
Glavo commented on code in PR #254: URL: https://github.com/apache/commons-imaging/pull/254#discussion_r1161772193 ## src/main/java/org/apache/commons/imaging/formats/webp/WebPImageParser.java: ## @@ -0,0 +1,351 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [commons-compress] Glavo commented on pull request #378: Optimize the nameMap of ZipFile

2023-04-10 Thread via GitHub
Glavo commented on PR #378: URL: https://github.com/apache/commons-compress/pull/378#issuecomment-1501863937 > No tests. Code coverage is down. No proof of performance change one way or another. Non-trivial additional complexity. The core intention of this PR is to reduce memory alloc

[GitHub] [commons-compress] garydgregory commented on pull request #378: Optimize the nameMap of ZipFile

2023-04-10 Thread via GitHub
garydgregory commented on PR #378: URL: https://github.com/apache/commons-compress/pull/378#issuecomment-1501773958 No tests. Code coverage is down. No proof of performance change one way or another. Non-trivial additional complexity. So -1 as it stands. "For extremely rare situation

[GitHub] [commons-compress] Glavo opened a new pull request, #378: Optimize the nameMap of ZipFile

2023-04-10 Thread via GitHub
Glavo opened a new pull request, #378: URL: https://github.com/apache/commons-compress/pull/378 For most regular zip files, all of their entries will have different names. The current implementation of ZipFile maps each name to a LinkedList in the nameMap in order to deal with the cas