[GitHub] [commons-parent] garydgregory merged pull request #271: Bump buildnumber-maven-plugin from 3.0.0 to 3.1.0

2023-05-15 Thread via GitHub
garydgregory merged PR #271: URL: https://github.com/apache/commons-parent/pull/271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@c

[GitHub] [commons-compress] tballison opened a new pull request, #386: COMPRESS-644 -- do not allow zero by entries when detecting magic-less tar

2023-05-15 Thread via GitHub
tballison opened a new pull request, #386: URL: https://github.com/apache/commons-compress/pull/386 When relying on reading the first record from a tar file and then verifying the checksum as proof that the file is a tar file, require that the record have more than zero bytes. -- This is

[jira] [Updated] (COMPRESS-644) Don't trust tar detection on zero byte record?

2023-05-15 Thread Tim Allison (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Allison updated COMPRESS-644: - Affects Version/s: 1.23.0 > Don't trust tar detection on zero byte record? > --

[jira] [Commented] (COMPRESS-644) Don't trust tar detection on zero byte record?

2023-05-15 Thread Tim Allison (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722800#comment-17722800 ] Tim Allison commented on COMPRESS-644: -- Y, I was thinking something like this: ht

[jira] [Commented] (COMPRESS-644) Don't trust tar detection on zero byte record?

2023-05-15 Thread Tim Allison (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722807#comment-17722807 ] Tim Allison commented on COMPRESS-644: -- Do you we need to check that the entry is

[GitHub] [commons-compress] garydgregory commented on a diff in pull request #386: COMPRESS-644 -- do not allow zero by entries when detecting magic-less tar

2023-05-15 Thread via GitHub
garydgregory commented on code in PR #386: URL: https://github.com/apache/commons-compress/pull/386#discussion_r1194113644 ## src/test/java/org/apache/commons/compress/DetectArchiverTestCase.java: ## @@ -141,4 +145,17 @@ public void testEmptyJarArchive() throws Exception {

[GitHub] [commons-compress] tballison commented on a diff in pull request #386: COMPRESS-644 -- do not allow zero by entries when detecting magic-less tar

2023-05-15 Thread via GitHub
tballison commented on code in PR #386: URL: https://github.com/apache/commons-compress/pull/386#discussion_r1194351373 ## src/main/java/org/apache/commons/compress/archivers/ArchiveStreamFactory.java: ## @@ -268,7 +269,16 @@ public static String detect(final InputStream in) thr