zenghu1chen commented on PR #230:
URL: https://github.com/apache/commons-pool/pull/230#issuecomment-1637476815
> @zenghu1chen Thank you for the PR. Please see the build failure and update
the PR. There are no unit tests here, I'd really like to see a test that can
demonstrate a dead lock in
zenghu1chen commented on code in PR #230:
URL: https://github.com/apache/commons-pool/pull/230#discussion_r1264935217
##
src/main/java/org/apache/commons/pool2/PooledObject.java:
##
@@ -33,6 +34,8 @@
*/
public interface PooledObject extends Comparable> {
+ReentrantLock
[
https://issues.apache.org/jira/browse/GEOMETRY-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743605#comment-17743605
]
Matt Juntunen commented on GEOMETRY-155:
This can be done by multiplying the ve
ani5rudh commented on code in PR #49:
URL: https://github.com/apache/commons-statistics/pull/49#discussion_r1264800171
##
commons-statistics-descriptive/src/test/java/org/apache/commons/statistics/descriptive/MaxTest.java:
##
@@ -0,0 +1,187 @@
+/*
+ * Licensed to the Apache Soft
[
https://issues.apache.org/jira/browse/GEOMETRY-150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743601#comment-17743601
]
Matt Juntunen commented on GEOMETRY-150:
I believe this method is general enoug
[
https://issues.apache.org/jira/browse/GEOMETRY-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743597#comment-17743597
]
Matt Juntunen commented on GEOMETRY-154:
[~dimitrios.efthymiou], I'm not sold o
[
https://issues.apache.org/jira/browse/IMAGING-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743590#comment-17743590
]
Gary Lucas commented on IMAGING-358:
It's been two years since I looked at this (Ima
[
https://issues.apache.org/jira/browse/GEOMETRY-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743585#comment-17743585
]
Dimitrios Efthymiou edited comment on GEOMETRY-154 at 7/16/23 11:38 PM:
-
[
https://issues.apache.org/jira/browse/GEOMETRY-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743585#comment-17743585
]
Dimitrios Efthymiou commented on GEOMETRY-154:
--
[~erans] doing it now. Sho
[
https://issues.apache.org/jira/browse/GEOMETRY-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743582#comment-17743582
]
Gilles Sadowski commented on GEOMETRY-154:
--
bq. One thing i would love to do i
[
https://issues.apache.org/jira/browse/GEOMETRY-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743577#comment-17743577
]
Dimitrios Efthymiou edited comment on GEOMETRY-154 at 7/16/23 11:01 PM:
-
[
https://issues.apache.org/jira/browse/GEOMETRY-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743577#comment-17743577
]
Dimitrios Efthymiou edited comment on GEOMETRY-154 at 7/16/23 11:00 PM:
-
[
https://issues.apache.org/jira/browse/GEOMETRY-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743577#comment-17743577
]
Dimitrios Efthymiou edited comment on GEOMETRY-154 at 7/16/23 10:59 PM:
-
[
https://issues.apache.org/jira/browse/GEOMETRY-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743577#comment-17743577
]
Dimitrios Efthymiou commented on GEOMETRY-154:
--
[~mattjuntunen] for exampl
[
https://issues.apache.org/jira/browse/GEOMETRY-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743573#comment-17743573
]
Matt Juntunen commented on GEOMETRY-154:
What would be a use case for this meth
[
https://issues.apache.org/jira/browse/IMAGING-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743568#comment-17743568
]
Gary D. Gregory commented on IMAGING-358:
-
" of Imaging-309, it turned out that
[
https://issues.apache.org/jira/browse/IMAGING-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743564#comment-17743564
]
Gilles Sadowski commented on IMAGING-358:
-
bq. [...] the rational number format
[
https://issues.apache.org/jira/browse/IMAGING-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743563#comment-17743563
]
Gary Lucas edited comment on IMAGING-358 at 7/16/23 8:11 PM:
-
[
https://issues.apache.org/jira/browse/IMAGING-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743563#comment-17743563
]
Gary Lucas commented on IMAGING-358:
Well, there always a trade off with this kind o
garydgregory commented on code in PR #786:
URL: https://github.com/apache/commons-lang/pull/786#discussion_r1264740474
##
src/test/java/org/apache/commons/lang3/builder/DiffBuilderTest.java:
##
@@ -495,4 +519,16 @@ public void testTriviallyEqualTestEnabled() {
assertTha
[
https://issues.apache.org/jira/browse/COLLECTIONS-844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Claude Warren updated COLLECTIONS-844:
--
Summary: Counting Bloom filter expects counts (cells) to be ints (was:
Counting B
garydgregory commented on PR #786:
URL: https://github.com/apache/commons-lang/pull/786#issuecomment-1637177513
@greatmastermario
Hm, I'm having trouble apply the patch locally on master with `git apply`.
Would you rebase on master please?
--
This is an automated message from the Apac
greatmastermario commented on PR #786:
URL: https://github.com/apache/commons-lang/pull/786#issuecomment-1637176458
Since it has been a bit since I opened this PR, let me know if any edits
are required.
On Sun, Jul 16, 2023, 12:39 PM Gary Gregory ***@***.***>
wrote:
> Look
garydgregory commented on PR #786:
URL: https://github.com/apache/commons-lang/pull/786#issuecomment-1637173471
Looking...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
Osdel commented on PR #786:
URL: https://github.com/apache/commons-lang/pull/786#issuecomment-1637170747
What happened to this pull request? This change is really needed. Having the
`DiffBuilder.append()` constraint on passing a `DiffResult` is not ideal.
Ideally you want to recursively cal
garydgregory closed pull request #27: Bump junit from 4.13 to 4.13.1 in /core
URL: https://github.com/apache/commons-digester/pull/27
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
garydgregory commented on PR #27:
URL: https://github.com/apache/commons-digester/pull/27#issuecomment-1637168427
Done elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
kinow commented on code in PR #49:
URL: https://github.com/apache/commons-statistics/pull/49#discussion_r1264731414
##
commons-statistics-descriptive/src/test/java/org/apache/commons/statistics/descriptive/MaxTest.java:
##
@@ -0,0 +1,187 @@
+/*
+ * Licensed to the Apache Softwar
[
https://issues.apache.org/jira/browse/POOL-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743558#comment-17743558
]
Phil Steitz commented on POOL-410:
--
Moving a comment from PR to here. I think I now under
aherbert commented on PR #406:
URL:
https://github.com/apache/commons-collections/pull/406#issuecomment-1637156007
Some extra checkstyle files were added. I hope to have time to review in the
next few days.
--
This is an automated message from the Apache Git Service.
To respond to the me
Claudenw opened a new pull request, #406:
URL: https://github.com/apache/commons-collections/pull/406
Counting bloom filter tests are dependant upon the maximum value that can be
stored in a cell in a Bloom filter.
This patch adds a `maxValue()` method to the CountingBloomFilter inter
ani5rudh opened a new pull request, #49:
URL: https://github.com/apache/commons-statistics/pull/49
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
Claude Warren created COLLECTIONS-844:
-
Summary: Counting Bloomfilter tests expect counts to be ints
Key: COLLECTIONS-844
URL: https://issues.apache.org/jira/browse/COLLECTIONS-844
Project: Commons
garydgregory commented on PR #4:
URL: https://github.com/apache/commons-digester/pull/4#issuecomment-1637133010
Closing: we no longer use Travis CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
garydgregory closed pull request #4: refine travis-ci scripts
URL: https://github.com/apache/commons-digester/pull/4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
garydgregory commented on PR #46:
URL: https://github.com/apache/commons-digester/pull/46#issuecomment-1637132832
Hi @nhojpatrick
I've fixed and modernized the build and it is now green. Would you please
rebase your PRs?
--
This is an automated message from the Apache Git Service.
To
garydgregory merged PR #81:
URL: https://github.com/apache/commons-digester/pull/81
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@c
step-security-bot opened a new pull request, #81:
URL: https://github.com/apache/commons-digester/pull/81
## Summary
This pull request is created by [Secure
Repo](https://app.stepsecurity.io/securerepo) at the request of @garydgregory.
Please merge the Pull Request to incorporate the
garydgregory merged PR #32:
URL: https://github.com/apache/commons-digester/pull/32
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@c
garydgregory merged PR #78:
URL: https://github.com/apache/commons-digester/pull/78
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@c
garydgregory merged PR #79:
URL: https://github.com/apache/commons-digester/pull/79
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@c
garydgregory merged PR #80:
URL: https://github.com/apache/commons-digester/pull/80
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@c
garydgregory commented on PR #32:
URL: https://github.com/apache/commons-digester/pull/32#issuecomment-1637120479
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
garydgregory merged PR #9:
URL: https://github.com/apache/commons-digester/pull/9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@com
garydgregory closed pull request #64: Bump maven-javadoc-plugin from 2.8 to
3.5.0
URL: https://github.com/apache/commons-digester/pull/64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
garydgregory merged PR #63:
URL: https://github.com/apache/commons-digester/pull/63
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@c
garydgregory merged PR #68:
URL: https://github.com/apache/commons-digester/pull/68
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@c
garydgregory merged PR #69:
URL: https://github.com/apache/commons-digester/pull/69
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@c
garydgregory commented on PR #69:
URL: https://github.com/apache/commons-digester/pull/69#issuecomment-1637117074
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
garydgregory merged PR #75:
URL: https://github.com/apache/commons-digester/pull/75
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@c
garydgregory merged PR #77:
URL: https://github.com/apache/commons-digester/pull/77
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@c
garydgregory commented on PR #72:
URL: https://github.com/apache/commons-digester/pull/72#issuecomment-1637116567
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
[
https://issues.apache.org/jira/browse/IMAGING-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743539#comment-17743539
]
Gary D. Gregory commented on IMAGING-358:
-
IMO and in general, I would move all
garydgregory merged PR #112:
URL: https://github.com/apache/commons-exec/pull/112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@com
[
https://issues.apache.org/jira/browse/GEOMETRY-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743530#comment-17743530
]
Dimitrios Efthymiou edited comment on GEOMETRY-154 at 7/16/23 1:57 PM:
--
[
https://issues.apache.org/jira/browse/GEOMETRY-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743536#comment-17743536
]
Gilles Sadowski commented on GEOMETRY-154:
--
IIUC, this says that there are at
garydgregory commented on code in PR #112:
URL: https://github.com/apache/commons-exec/pull/112#discussion_r1264685302
##
src/site/apt/tutorial.apt:
##
@@ -169,7 +169,7 @@ executor.execute(cmdLine, resultHandler);
// some time later the result handler callback was invoked so
garydgregory commented on code in PR #112:
URL: https://github.com/apache/commons-exec/pull/112#discussion_r1264685302
##
src/site/apt/tutorial.apt:
##
@@ -169,7 +169,7 @@ executor.execute(cmdLine, resultHandler);
// some time later the result handler callback was invoked so
[
https://issues.apache.org/jira/browse/GEOMETRY-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743530#comment-17743530
]
Dimitrios Efthymiou commented on GEOMETRY-154:
--
[~erans] In a sense yes. t
ecki commented on code in PR #112:
URL: https://github.com/apache/commons-exec/pull/112#discussion_r1264679931
##
src/site/apt/tutorial.apt:
##
@@ -169,7 +169,7 @@ executor.execute(cmdLine, resultHandler);
// some time later the result handler callback was invoked so we
// c
kinow commented on code in PR #430:
URL: https://github.com/apache/commons-text/pull/430#discussion_r1264679028
##
src/main/java/org/apache/commons/text/AlphabetConverter.java:
##
@@ -87,9 +87,6 @@ public final class AlphabetConverter {
* @see
"http://www.oracle.com/us/te
[
https://issues.apache.org/jira/browse/IMAGING-358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gilles Sadowski updated IMAGING-358:
Summary: "RationalNumber" class is "public" (was: "RationalNumer" class is
"public")
> "
Gilles Sadowski created IMAGING-358:
---
Summary: "RationalNumer" class is "public"
Key: IMAGING-358
URL: https://issues.apache.org/jira/browse/IMAGING-358
Project: Commons Imaging
Issue Type:
aherbert commented on code in PR #430:
URL: https://github.com/apache/commons-text/pull/430#discussion_r1264670367
##
src/main/java/org/apache/commons/text/AlphabetConverter.java:
##
@@ -87,9 +87,6 @@ public final class AlphabetConverter {
* @see
"http://www.oracle.com/us
[
https://issues.apache.org/jira/browse/GEOMETRY-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743517#comment-17743517
]
Gilles Sadowski commented on GEOMETRY-154:
--
[~dimitrios.efthymiou],
Is this [
[
https://issues.apache.org/jira/browse/TEXT-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743508#comment-17743508
]
Dimitrios Efthymiou commented on TEXT-227:
--
[~aherbert] PR on GitHub https://githu
[
https://issues.apache.org/jira/browse/TEXT-227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dimitrios Efthymiou updated TEXT-227:
-
Description: Removed unnecessary IF statement in AlphabetConverter, because
the Character::
Anirudh Joshi created STATISTICS-76:
---
Summary: Implement Max
Key: STATISTICS-76
URL: https://issues.apache.org/jira/browse/STATISTICS-76
Project: Commons Statistics
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/STATISTICS-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Herbert resolved STATISTICS-72.
Resolution: Implemented
Added in commit:
c9ed0a61e16e8083dc0e4b1f8afa33086d195f40
> Im
asfgit closed pull request #46: [STATISTICS-71]: Add base interfaces for all
statistic implementations.
URL: https://github.com/apache/commons-statistics/pull/46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
[
https://issues.apache.org/jira/browse/TEXT-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743499#comment-17743499
]
Alex Herbert commented on TEXT-227:
---
Some more context would be useful here. I presume th
aherbert commented on code in PR #153:
URL: https://github.com/apache/commons-email/pull/153#discussion_r1264625263
##
src/main/java/org/apache/commons/mail/EmailUtils.java:
##
@@ -295,10 +295,6 @@ static String encodeUrl(final String input) throws
UnsupportedEncodingException
aherbert commented on PR #46:
URL:
https://github.com/apache/commons-statistics/pull/46#issuecomment-1637001699
The `foundation` branch requires more commits to reopen this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
aherbert closed pull request #48: [STATISTICS-71]: Add base interfaces for all
statistic implementations.
URL: https://github.com/apache/commons-statistics/pull/48
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
aherbert commented on PR #48:
URL:
https://github.com/apache/commons-statistics/pull/48#issuecomment-1637001364
See #46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
75 matches
Mail list logo