shashankrnr32 opened a new pull request, #1082:
URL: https://github.com/apache/commons-lang/pull/1082
**Note: Please feel free to close this PR if this was previously discussed
before and was decided not to be added to this implementation.**
Currently, `ReflectiveToStringBuilder` allo
garydgregory closed pull request #157: Net constants refine
URL: https://github.com/apache/commons-net/pull/157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
aherbert commented on code in PR #218:
URL: https://github.com/apache/commons-geometry/pull/218#discussion_r1268708345
##
commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/twod/hull/ConvexHull2D.java:
##
Review Comment:
This is showing as a new
[ https://issues.apache.org/jira/browse/FILEUPLOAD-309 ]
Erica Kane deleted comment on FILEUPLOAD-309:
---
was (Author: ekane):
I see release 2.0.0-M1 on the releases here, but it is not in Maven Central. Am
I looking in the wrong place?
> Rele
[
https://issues.apache.org/jira/browse/FILEUPLOAD-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744791#comment-17744791
]
Erica Kane commented on FILEUPLOAD-309:
---
I see release 2.0.0-M1 on the releases
garydgregory commented on code in PR #157:
URL: https://github.com/apache/commons-net/pull/157#discussion_r1268661489
##
src/main/java/org/apache/commons/net/util/NetConstants.java:
##
@@ -23,7 +23,7 @@
*
* @since 3.8.0
*/
-public class NetConstants {
+public final class N
jkbkupczyk commented on PR #165:
URL: https://github.com/apache/commons-net/pull/165#issuecomment-1642742312
Thank you @garydgregory and @kinow for review 😊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
garydgregory merged PR #165:
URL: https://github.com/apache/commons-net/pull/165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@comm
jkbkupczyk commented on PR #165:
URL: https://github.com/apache/commons-net/pull/165#issuecomment-1642693810
I think it's good RN. Would you mind looking at this @garydgregory, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/GEOMETRY-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744759#comment-17744759
]
Andreas Goss edited comment on GEOMETRY-144 at 7/19/23 8:08 PM:
-
[
https://issues.apache.org/jira/browse/GEOMETRY-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744759#comment-17744759
]
Andreas Goss commented on GEOMETRY-144:
---
I created a pull request on the github p
garydgregory commented on PR #165:
URL: https://github.com/apache/commons-net/pull/165#issuecomment-1642617320
😜
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
jkbkupczyk commented on PR #165:
URL: https://github.com/apache/commons-net/pull/165#issuecomment-1642593903
> This PR looks odd, you need to only have your commits in here. Git can be
tricky sometimes...
ahh, I did it through Intellij, should have done it manually...
--
This is an
garydgregory commented on PR #165:
URL: https://github.com/apache/commons-net/pull/165#issuecomment-1642585924
This PR looks odd, you need to only have your commits in here. Git can be
tricky sometimes...
--
This is an automated message from the Apache Git Service.
To respond to the messa
[
https://issues.apache.org/jira/browse/CONFIGURATION-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744752#comment-17744752
]
Gary D. Gregory commented on CONFIGURATION-835:
---
Eventually, yes, we
StefanOltmann commented on PR #303:
URL: https://github.com/apache/commons-imaging/pull/303#issuecomment-1642543066
That’s for the reporter to decide, but I wanted just to add my two cents
here. 😄
In general if you don’t need order and there are no duplicates Set should be
used.
--
orionlibs commented on PR #303:
URL: https://github.com/apache/commons-imaging/pull/303#issuecomment-1642538868
@StefanOltmann the ticket said List, tha tis why I did it with a list.
Should I change it to Set?
--
This is an automated message from the Apache Git Service.
To respond to the
StefanOltmann commented on PR #303:
URL: https://github.com/apache/commons-imaging/pull/303#issuecomment-1642538788
That makes sense. In my fork I use a `Set`, because there is no order needed.
https://github.com/Ashampoo/kim/blob/2d437c4d6b54cf64450add84600a7af370fae36a/src/commonMai
StefanOltmann commented on PR #303:
URL: https://github.com/apache/commons-imaging/pull/303#issuecomment-1642533808
That makes sense. In my fork I refactored it to a `Set`, because there is no
order needed.
--
This is an automated message from the Apache Git Service.
To respond to the mes
kinow commented on PR #165:
URL: https://github.com/apache/commons-net/pull/165#issuecomment-1642394341
Still seeing the same failure I saw yesterday on `master`. I have a Windows
VM at $work, but haven't had much time to set up or test anything on that
machine (using that to write docs/sha
garydgregory commented on PR #165:
URL: https://github.com/apache/commons-net/pull/165#issuecomment-1642379826
@jkbkupczyk
OK, now you can rebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
[
https://issues.apache.org/jira/browse/MATH-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744684#comment-17744684
]
Dimitrios Efthymiou commented on MATH-1579:
---
[~ani5rudh] Thank you Anirudh!!
>
[
https://issues.apache.org/jira/browse/MATH-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744669#comment-17744669
]
Anirudh Joshi commented on MATH-1579:
-
{quote}May i try to move Variance.java to commo
garydgregory commented on PR #165:
URL: https://github.com/apache/commons-net/pull/165#issuecomment-1642238145
@jkbkupczyk
OK, I finally nailed the bulletproofing on the failing test.
Would you please rebase this PR on master? Then we should see a green
build...
TY!
[
https://issues.apache.org/jira/browse/MATH-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744608#comment-17744608
]
Gilles Sadowski commented on MATH-1579:
---
Build fails (error issued by the "javadoc"
[
https://issues.apache.org/jira/browse/MATH-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744593#comment-17744593
]
Dimitrios Efthymiou commented on MATH-1579:
---
[~erans] committed
> Create "clust
[
https://issues.apache.org/jira/browse/MATH-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744581#comment-17744581
]
Gilles Sadowski commented on MATH-1579:
---
Build fails (you've deleted the top-level P
[
https://issues.apache.org/jira/browse/MATH-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744546#comment-17744546
]
Dimitrios Efthymiou commented on MATH-1579:
---
[~aherbert] thank you Alex. I ran t
[
https://issues.apache.org/jira/browse/MATH-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744539#comment-17744539
]
Alex Herbert commented on MATH-1579:
I presume you have added the dependency in a chil
[
https://issues.apache.org/jira/browse/MATH-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744530#comment-17744530
]
Dimitrios Efthymiou edited comment on MATH-1579 at 7/19/23 10:30 AM:
---
[
https://issues.apache.org/jira/browse/MATH-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744530#comment-17744530
]
Dimitrios Efthymiou commented on MATH-1579:
---
[~aherbert] thanks Alex. I did "mvn
[
https://issues.apache.org/jira/browse/MATH-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744519#comment-17744519
]
Alex Herbert edited comment on MATH-1579 at 7/19/23 10:19 AM:
--
[
https://issues.apache.org/jira/browse/MATH-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744519#comment-17744519
]
Alex Herbert commented on MATH-1579:
An IDE may cache some parts of the build. Across
garydgregory commented on PR #165:
URL: https://github.com/apache/commons-net/pull/165#issuecomment-1641804438
Let's fix master before we do anything else. I'll look today.
It is ok to add the Junit test dependency for parameterized testing.
--
This is an automated message from the
[
https://issues.apache.org/jira/browse/MATH-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744514#comment-17744514
]
Dimitrios Efthymiou edited comment on MATH-1579 at 7/19/23 10:06 AM:
---
aherbert commented on PR #406:
URL:
https://github.com/apache/commons-collections/pull/406#issuecomment-1641796871
Go ahead. If if more closely matches the literature then this is what we
should do.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
[
https://issues.apache.org/jira/browse/MATH-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744514#comment-17744514
]
Dimitrios Efthymiou commented on MATH-1579:
---
[~erans] Sorry. When I create a new
[
https://issues.apache.org/jira/browse/MATH-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744511#comment-17744511
]
Gilles Sadowski edited comment on MATH-1577 at 7/19/23 9:54 AM:
[
https://issues.apache.org/jira/browse/MATH-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gilles Sadowski reopened MATH-1577:
---
Module exists only in the dedicated branch.
Work stalled because no agreement has been reached on
[
https://issues.apache.org/jira/browse/MATH-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gilles Sadowski updated MATH-1577:
--
Description:
Move and enhance codes from "legacy" module that are currently in the
{{o.a.c.math
[
https://issues.apache.org/jira/browse/MATH-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744504#comment-17744504
]
Gilles Sadowski commented on MATH-1579:
---
bq. I managed to move only a few classes fr
Claudenw commented on PR #406:
URL:
https://github.com/apache/commons-collections/pull/406#issuecomment-1641712706
Cells are used in stable Bloom filters which are technically not a counting
bloom filter they are in a class called "Element decay" Bloom filters. They do
use cells, not bits
[
https://issues.apache.org/jira/browse/JCS-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1773#comment-1773
]
Amol D edited comment on JCS-235 at 7/19/23 7:04 AM:
-
Ok
was (Author:
43 matches
Mail list logo
