[GitHub] [commons-collections] Claudenw commented on pull request #402: COLLECTIONS-843: Implement Layered Bloom filter

2023-07-20 Thread via GitHub
Claudenw commented on PR #402: URL: https://github.com/apache/commons-collections/pull/402#issuecomment-1645018264 Recent changes: # Main code ## BloomFilterProducer * Cleaned up documentation to specify that implementations should specify if filters used in `forEachBloomFilter

[GitHub] [commons-compress] garydgregory merged pull request #400: Bump com.github.luben:zstd-jni from 1.5.5-4 to 1.5.5-5

2023-07-20 Thread via GitHub
garydgregory merged PR #400: URL: https://github.com/apache/commons-compress/pull/400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[GitHub] [commons-imaging] garydgregory commented on a diff in pull request #304: Make checkForSubImage null-safe

2023-07-20 Thread via GitHub
garydgregory commented on code in PR #304: URL: https://github.com/apache/commons-imaging/pull/304#discussion_r1270096441 ## src/main/java/org/apache/commons/imaging/formats/tiff/TiffImageParser.java: ## @@ -75,7 +75,7 @@ private Rectangle checkForSubImage( // dimension

[jira] [Commented] (STATISTICS-77) Implement Sum

2023-07-20 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/STATISTICS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745298#comment-17745298 ] Alex Herbert commented on STATISTICS-77: {quote}You mean "storeless", don't yo

[jira] [Commented] (STATISTICS-72) Implement Min

2023-07-20 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/STATISTICS-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745297#comment-17745297 ] Alex Herbert commented on STATISTICS-72: The current implementation uses Math.

[GitHub] [commons-net] jkbkupczyk commented on a diff in pull request #166: Add IMAP package tests, include junit-jupiter-params artifact

2023-07-20 Thread via GitHub
jkbkupczyk commented on code in PR #166: URL: https://github.com/apache/commons-net/pull/166#discussion_r1269939305 ## src/main/java/org/apache/commons/net/imap/IMAPCommand.java: ## @@ -84,7 +84,7 @@ public static final String getCommand(final IMAPCommand command) { }

[GitHub] [commons-net] garydgregory commented on a diff in pull request #166: Add IMAP package tests, include junit-jupiter-params artifact

2023-07-20 Thread via GitHub
garydgregory commented on code in PR #166: URL: https://github.com/apache/commons-net/pull/166#discussion_r1269933342 ## src/main/java/org/apache/commons/net/imap/IMAPCommand.java: ## @@ -84,7 +84,7 @@ public static final String getCommand(final IMAPCommand command) { }

[GitHub] [commons-geometry] agoss94 commented on a diff in pull request #218: Refactor hull

2023-07-20 Thread via GitHub
agoss94 commented on code in PR #218: URL: https://github.com/apache/commons-geometry/pull/218#discussion_r1269930417 ## commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/twod/hull/ConvexHull2D.java: ## @@ -0,0 +1,469 @@ +/* + * Licensed to the Apach

[GitHub] [commons-geometry] agoss94 commented on a diff in pull request #218: Refactor hull

2023-07-20 Thread via GitHub
agoss94 commented on code in PR #218: URL: https://github.com/apache/commons-geometry/pull/218#discussion_r1269930240 ## commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/twod/hull/ConvexHull2D.java: ## @@ -0,0 +1,469 @@ +/* + * Licensed to the Apach

[GitHub] [commons-net] jkbkupczyk opened a new pull request, #166: Add IMAP package tests, include junit-jupiter-params artifact

2023-07-20 Thread via GitHub
jkbkupczyk opened a new pull request, #166: URL: https://github.com/apache/commons-net/pull/166 - Adds [junit-jupiter-params](https://mvnrepository.com/artifact/org.junit.jupiter/junit-jupiter-params) artifact - Adds tests for various IMAP package classes that do not require a real (or

[GitHub] [commons-geometry] agoss94 commented on a diff in pull request #218: Refactor hull

2023-07-20 Thread via GitHub
agoss94 commented on code in PR #218: URL: https://github.com/apache/commons-geometry/pull/218#discussion_r1269919571 ## commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/twod/hull/ConvexHull2D.java: ## @@ -0,0 +1,469 @@ +/* + * Licensed to the Apach

[GitHub] [commons-geometry] agoss94 commented on a diff in pull request #218: Refactor hull

2023-07-20 Thread via GitHub
agoss94 commented on code in PR #218: URL: https://github.com/apache/commons-geometry/pull/218#discussion_r1269917506 ## commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/twod/hull/ConvexHull2D.java: ## @@ -0,0 +1,469 @@ +/* + * Licensed to the Apach

[GitHub] [commons-geometry] agoss94 commented on a diff in pull request #218: Refactor hull

2023-07-20 Thread via GitHub
agoss94 commented on code in PR #218: URL: https://github.com/apache/commons-geometry/pull/218#discussion_r1269916994 ## commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/twod/hull/ConvexHull2D.java: ## @@ -0,0 +1,469 @@ +/* + * Licensed to the Apach

[GitHub] [commons-geometry] agoss94 commented on a diff in pull request #218: Refactor hull

2023-07-20 Thread via GitHub
agoss94 commented on code in PR #218: URL: https://github.com/apache/commons-geometry/pull/218#discussion_r1269915517 ## commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/twod/hull/ConvexHull2D.java: ## @@ -0,0 +1,469 @@ +/* + * Licensed to the Apach

[GitHub] [commons-geometry] agoss94 commented on a diff in pull request #218: Refactor hull

2023-07-20 Thread via GitHub
agoss94 commented on code in PR #218: URL: https://github.com/apache/commons-geometry/pull/218#discussion_r1269915290 ## commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/twod/hull/ConvexHull2D.java: ## Review Comment: Old file has been retrieve

[jira] [Commented] (STATISTICS-72) Implement Min

2023-07-20 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/STATISTICS-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745215#comment-17745215 ] Gilles Sadowski commented on STATISTICS-72: --- Do we expect any implementation

[jira] [Commented] (STATISTICS-77) Implement Sum

2023-07-20 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/STATISTICS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745209#comment-17745209 ] Gilles Sadowski commented on STATISTICS-77: --- {quote}There may be different n

[jira] [Commented] (STATISTICS-77) Implement Sum

2023-07-20 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/STATISTICS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745196#comment-17745196 ] Alex Herbert commented on STATISTICS-77: There may be different non-storeless

[jira] [Commented] (STATISTICS-77) Implement Sum

2023-07-20 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/STATISTICS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745180#comment-17745180 ] Gilles Sadowski commented on STATISTICS-77: --- Is the purpose to possibly retu

[GitHub] [commons-pool] psteitz commented on pull request #230: Support for loom

2023-07-20 Thread via GitHub
psteitz commented on PR #230: URL: https://github.com/apache/commons-pool/pull/230#issuecomment-1644310926 Many thanks for the test and analysis. I will look at this in the next couple of days too. The test looks interesting as it is doing something that is not expected - invalidating an

[jira] [Commented] (STATISTICS-77) Implement Sum

2023-07-20 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/STATISTICS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745173#comment-17745173 ] Alex Herbert commented on STATISTICS-77: Note: Since the class is abstract, an

[jira] [Comment Edited] (STATISTICS-77) Implement Sum

2023-07-20 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/STATISTICS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745171#comment-17745171 ] Gilles Sadowski edited comment on STATISTICS-77 at 7/20/23 5:00 PM:

[jira] [Commented] (STATISTICS-77) Implement Sum

2023-07-20 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/STATISTICS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745171#comment-17745171 ] Gilles Sadowski commented on STATISTICS-77: --- * Shouldn't the constructor(s)

[GitHub] [commons-statistics] ani5rudh opened a new pull request, #50: STATISTICS-77: Sum Implementation

2023-07-20 Thread via GitHub
ani5rudh opened a new pull request, #50: URL: https://github.com/apache/commons-statistics/pull/50 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[jira] [Commented] (MATH-1579) Create "clustering" module

2023-07-20 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/MATH-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745121#comment-17745121 ] Gilles Sadowski commented on MATH-1579: --- FTR, I've just posted a reply to [~dimitrio

[GitHub] [commons-pool] garydgregory commented on pull request #230: Support for loom

2023-07-20 Thread via GitHub
garydgregory commented on PR #230: URL: https://github.com/apache/commons-pool/pull/230#issuecomment-1643929013 Hi @zenghu1chen Thank for your update, I might be able to look this weekend. Do note that I am still -1 on this PR due to the use of a global variable. -- This is an auto

[GitHub] [commons-imaging] mercuryLuz commented on a diff in pull request #304: Make checkForSubImage null-safe

2023-07-20 Thread via GitHub
mercuryLuz commented on code in PR #304: URL: https://github.com/apache/commons-imaging/pull/304#discussion_r1269210099 ## src/main/java/org/apache/commons/imaging/formats/tiff/TiffImageParser.java: ## @@ -75,7 +75,7 @@ private Rectangle checkForSubImage( // dimensions

[GitHub] [commons-imaging] kinow commented on a diff in pull request #304: Make checkForSubImage null-safe

2023-07-20 Thread via GitHub
kinow commented on code in PR #304: URL: https://github.com/apache/commons-imaging/pull/304#discussion_r1269199173 ## src/main/java/org/apache/commons/imaging/formats/tiff/TiffImageParser.java: ## @@ -75,7 +75,7 @@ private Rectangle checkForSubImage( // dimensions of th

[GitHub] [commons-pool] zenghu1chen commented on pull request #230: Support for loom

2023-07-20 Thread via GitHub
zenghu1chen commented on PR #230: URL: https://github.com/apache/commons-pool/pull/230#issuecomment-1643446429 > @zenghu1chen I think the first step would be to test your use case with the current version of Pool, 2.11.1, not 2.4.2. Also consider testing with git branch POOL_2_X. 2.4.2 is v