[jira] [Created] (JEXL-402) parse failed with empty return value.

Xu Pengcheng created JEXL-402: - Summary: parse failed with empty return value. Key: JEXL-402 URL: https://issues.apache.org/jira/browse/JEXL-402 Project: Commons JEXL Issue Type: Bug Affects

[GitHub] [commons-text] garydgregory merged pull request #452: TEXT-228: Fix TextStringBuilder to over-allocate when ensuring capacity

garydgregory merged PR #452: URL: https://github.com/apache/commons-text/pull/452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [commons-text] garydgregory commented on pull request #452: TEXT-228: Fix TextStringBuilder to over-allocate when ensuring capacity

garydgregory commented on PR #452: URL: https://github.com/apache/commons-text/pull/452#issuecomment-1687038018 https://issues.apache.org/jira/projects/TEXT/issues/TEXT-228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (TEXT-228) StringTokenizer performance degradation when parsing large lines

[ https://issues.apache.org/jira/browse/TEXT-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17757048#comment-17757048 ] Gary D. Gregory commented on TEXT-228: -- Ah, I see that AbstractStringBuilder throws OME in Java 11, so

[jira] [Commented] (TEXT-228) StringTokenizer performance degradation when parsing large lines

[ https://issues.apache.org/jira/browse/TEXT-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756957#comment-17756957 ] Alex Herbert commented on TEXT-228: --- Note: Running the 3 new memory tests locally requires 10G for the

[GitHub] [commons-text] aherbert commented on a diff in pull request #452: TEXT-228: Fix TextStringBuilder to over-allocate when ensuring capacity

aherbert commented on code in PR #452: URL: https://github.com/apache/commons-text/pull/452#discussion_r1300134930 ## src/main/java/org/apache/commons/text/TextStringBuilder.java: ## @@ -1820,17 +1832,84 @@ public boolean endsWith(final String str) { /** * Tests the

[jira] [Commented] (TEXT-228) StringTokenizer performance degradation when parsing large lines

[ https://issues.apache.org/jira/browse/TEXT-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756923#comment-17756923 ] Alex Herbert commented on TEXT-228: --- Throwing an OutOfMemoryError is reasonable practice when writing

[GitHub] [commons-text] garydgregory commented on a diff in pull request #452: TEXT-228: Fix TextStringBuilder to over-allocate when ensuring capacity

garydgregory commented on code in PR #452: URL: https://github.com/apache/commons-text/pull/452#discussion_r1300107300 ## src/main/java/org/apache/commons/text/TextStringBuilder.java: ## @@ -1820,17 +1832,84 @@ public boolean endsWith(final String str) { /** * Tests

[GitHub] [commons-text] aherbert opened a new pull request, #452: TEXT-228: Fix TextStringBuilder to over-allocate when ensuring capacity

aherbert opened a new pull request, #452: URL: https://github.com/apache/commons-text/pull/452 This fixes a performance regression where allocation was only using the exact size necessary for the additional chars (resulting in buffer reallocation on each append). -- This is an automated

[GitHub] [commons-text] theshoeshiner commented on a diff in pull request #450: Cases API + 4 implementations (Pascal, Camel, Kebab, Snake)

theshoeshiner commented on code in PR #450: URL: https://github.com/apache/commons-text/pull/450#discussion_r133105 ## src/main/java/org/apache/commons/text/cases/CamelCase.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [commons-text] theshoeshiner commented on a diff in pull request #450: Cases API + 4 implementations (Pascal, Camel, Kebab, Snake)

theshoeshiner commented on code in PR #450: URL: https://github.com/apache/commons-text/pull/450#discussion_r133105 ## src/main/java/org/apache/commons/text/cases/CamelCase.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [commons-text] theshoeshiner commented on a diff in pull request #450: Cases API + 4 implementations (Pascal, Camel, Kebab, Snake)

theshoeshiner commented on code in PR #450: URL: https://github.com/apache/commons-text/pull/450#discussion_r133105 ## src/main/java/org/apache/commons/text/cases/CamelCase.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [commons-text] theshoeshiner commented on a diff in pull request #450: Cases API + 4 implementations (Pascal, Camel, Kebab, Snake)

theshoeshiner commented on code in PR #450: URL: https://github.com/apache/commons-text/pull/450#discussion_r133105 ## src/main/java/org/apache/commons/text/cases/CamelCase.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[jira] [Commented] (TEXT-228) StringTokenizer performance degradation when parsing large lines

[ https://issues.apache.org/jira/browse/TEXT-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756856#comment-17756856 ] Gary D. Gregory commented on TEXT-228: -- Hi [~aherbert]  I'm not sure we or any library code should

[GitHub] [commons-text] garydgregory commented on pull request #450: Cases API + 4 implementations (Pascal, Camel, Kebab, Snake)

garydgregory commented on PR #450: URL: https://github.com/apache/commons-text/pull/450#issuecomment-1686152071 IMO: You should follow the YAGNI principle and only make public and protected what you must, especially in a first cut. -- This is an automated message from the Apache Git

[GitHub] [commons-build-plugin] garydgregory merged pull request #174: Bump org.apache.ant:ant-launcher from 1.10.12 to 1.10.14

garydgregory merged PR #174: URL: https://github.com/apache/commons-build-plugin/pull/174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (TEXT-228) StringTokenizer performance degradation when parsing large lines

[ https://issues.apache.org/jira/browse/TEXT-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756840#comment-17756840 ] Alex Herbert commented on TEXT-228: --- The performance regression can be traced to commit 808ecca following

[GitHub] [commons-text] theshoeshiner commented on pull request #450: Cases API + 4 implementations (Pascal, Camel, Kebab, Snake)

theshoeshiner commented on PR #450: URL: https://github.com/apache/commons-text/pull/450#issuecomment-1686121778 @elharo In regards to a couple of the above changes, is there a reason we want to prevent these classes from being extended? I can imagine many scenarios where one would