[GitHub] [commons-lang] sujin0529 commented on pull request #1105: add NPE testcase in LockingVisitorsTest

sujin0529 commented on PR #1105: URL: https://github.com/apache/commons-lang/pull/1105#issuecomment-1712976171 Hi, @garydgregory In this project, the guard conditioning is well done. However, there is no guard for this function `ReadWriteLockVisitor.`. So I thought it would be good to

[GitHub] [commons-lang] sujin0529 commented on pull request #1105: add NPE testcase in LockingVisitorsTest

sujin0529 commented on PR #1105: URL: https://github.com/apache/commons-lang/pull/1105#issuecomment-1712973650 Hi, @garydgregory -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [commons-vfs] woonsan commented on pull request #409: VFS-841: copying Jackrabbit standalone Main class not to depend on wh…

woonsan commented on PR #409: URL: https://github.com/apache/commons-vfs/pull/409#issuecomment-1712962169 Hi @garydgregory , Yes, I think so. The Jackrabbit team believes that the Main class actually needs to be in standalone, not standalone-components and other projects such as

[jira] [Comment Edited] (TEXT-231) WordUtils.wrap should react to prexisting "new line string" as a wrap

[ https://issues.apache.org/jira/browse/TEXT-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763460#comment-17763460 ] Michael Karnerfors edited comment on TEXT-231 at 9/10/23 10:47 PM: ---

[jira] [Commented] (IMAGING-316) Support the BigTIFF file format

[ https://issues.apache.org/jira/browse/IMAGING-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763473#comment-17763473 ] Gary Lucas commented on IMAGING-316: Have an updated version of the Commons Imaging library that 

[jira] [Updated] (TEXT-231) WordUtils.wrap should react to prexisting "new line string" as a wrap

[ https://issues.apache.org/jira/browse/TEXT-231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Karnerfors updated TEXT-231: Attachment: (was: TEXT-231-wrap-on-newline-string.patch) > WordUtils.wrap should react

[jira] [Commented] (TEXT-231) WordUtils.wrap should react to prexisting "new line string" as a wrap

[ https://issues.apache.org/jira/browse/TEXT-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763460#comment-17763460 ] Michael Karnerfors commented on TEXT-231: - [~ggregory] The PR is created:

[jira] [Comment Edited] (TEXT-231) WordUtils.wrap should react to prexisting "new line string" as a wrap

[ https://issues.apache.org/jira/browse/TEXT-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763453#comment-17763453 ] Gary D. Gregory edited comment on TEXT-231 at 9/10/23 5:11 PM: --- No. Don't

[jira] [Commented] (TEXT-231) WordUtils.wrap should react to prexisting "new line string" as a wrap

[ https://issues.apache.org/jira/browse/TEXT-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763453#comment-17763453 ] Gary D. Gregory commented on TEXT-231: -- No. Don't edit changes.xml as it will likely conflict with

[jira] [Comment Edited] (TEXT-231) WordUtils.wrap should react to prexisting "new line string" as a wrap

[ https://issues.apache.org/jira/browse/TEXT-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763443#comment-17763443 ] Michael Karnerfors edited comment on TEXT-231 at 9/10/23 4:11 PM: --

[jira] [Commented] (TEXT-231) WordUtils.wrap should react to prexisting "new line string" as a wrap

[ https://issues.apache.org/jira/browse/TEXT-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763443#comment-17763443 ] Michael Karnerfors commented on TEXT-231: - [~ggregory]  Yes, it is true that I have reorganised the

[GitHub] [commons-text] garydgregory commented on pull request #450: Cases API + 4 implementations (Pascal, Camel, Kebab, Snake)

garydgregory commented on PR #450: URL: https://github.com/apache/commons-text/pull/450#issuecomment-1712802790 > Guava has `@Beta` for APIs they want to push but not commit to yet. Perhaps we can add something similar? This feels unwise to me and I would discourage it. Based on what

[GitHub] [commons-text] elharo commented on pull request #450: Cases API + 4 implementations (Pascal, Camel, Kebab, Snake)

elharo commented on PR #450: URL: https://github.com/apache/commons-text/pull/450#issuecomment-1712797585 Guava has `@Beta` for APIs they want to push but not commit to yet. Perhaps we can add something similar? -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (LANG-1595) Add ArrayUtils methods that accept a Predicate.

[ https://issues.apache.org/jira/browse/LANG-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763416#comment-17763416 ] Elliotte Rusty Harold commented on LANG-1595: - New feature, not simply an improvement > Add

[jira] [Commented] (LANG-1413) Improve performance of ExceptionUtils.getRootCause

[ https://issues.apache.org/jira/browse/LANG-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763414#comment-17763414 ] Elliotte Rusty Harold commented on LANG-1413: - can this be closed now if it was caused by an

[jira] [Commented] (LANG-1711) Modify ReflectionToStringBuilder to use trySetAccessible and not throw exceptions

[ https://issues.apache.org/jira/browse/LANG-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763413#comment-17763413 ] Elliotte Rusty Harold commented on LANG-1711: - We should be able to emulate that method in

[jira] [Commented] (TEXT-231) WordUtils.wrap should react to prexisting "new line string" as a wrap

[ https://issues.apache.org/jira/browse/TEXT-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763412#comment-17763412 ] Gary D. Gregory commented on TEXT-231: -- [~michaelkarnerfors]  Thank you for your report. The patch

[GitHub] [commons-text] elharo commented on a diff in pull request #450: Cases API + 4 implementations (Pascal, Camel, Kebab, Snake)

elharo commented on code in PR #450: URL: https://github.com/apache/commons-text/pull/450#discussion_r1320746730 ## src/main/java/org/apache/commons/text/cases/PascalCase.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *