[jira] [Commented] (IO-808) FileUtils.moveFile, copyFile and others can throw undocumened IllegalArgumentException

[ https://issues.apache.org/jira/browse/IO-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763886#comment-17763886 ] Phil D commented on IO-808: --- I'm against that because of my reasons above as well as the following:

[GitHub] [commons-statistics] aherbert commented on pull request #54: Update code references to use JavaDoc links.

aherbert commented on PR #54: URL: https://github.com/apache/commons-statistics/pull/54#issuecomment-1714059737 I think the changes are fine. The javadoc rendered locally are good. You could go one step further and replace all `` with `{@code }` elements. This is the preferred way to

[GitHub] [commons-net] haegar9766 commented on pull request #182: Change Class "org.apache.commons.net.ftp.parser.MVSFTPEntryParser" to support more datasets

haegar9766 commented on PR #182: URL: https://github.com/apache/commons-net/pull/182#issuecomment-1714049423 @garydgregory How could i provide a unit test for this? To test the code, the appropriate environment is needed. In this case an MVS system with FTP server and user datasets. For

[jira] [Commented] (VFS-828) Dependency hadoop-hdfs-client should be optional

[ https://issues.apache.org/jira/browse/VFS-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763733#comment-17763733 ] Gary D. Gregory commented on VFS-828: - I am experimenting locally with splitting out HDF

[jira] [Commented] (VFS-828) Dependency hadoop-hdfs-client should be optional

[ https://issues.apache.org/jira/browse/VFS-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763729#comment-17763729 ] Arkadiusz Biczewski commented on VFS-828: - Hi [~ggregory] , I would like to ask how

[GitHub] [commons-net] garydgregory commented on pull request #182: Change Class "org.apache.commons.net.ftp.parser.MVSFTPEntryParser" to support more datasets

garydgregory commented on PR #182: URL: https://github.com/apache/commons-net/pull/182#issuecomment-1713932793 @haegar9766 Thank you for your PR. Please add unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[jira] [Commented] (CSV-270) Different Expeciton type on malformed csv files

[ https://issues.apache.org/jira/browse/CSV-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763727#comment-17763727 ] Buddhi De Silva commented on CSV-270: - I have gone through the requirement discussed in

[GitHub] [commons-text] theshoeshiner commented on a diff in pull request #450: Cases API + 4 implementations (Pascal, Camel, Kebab, Snake)

theshoeshiner commented on code in PR #450: URL: https://github.com/apache/commons-text/pull/450#discussion_r1321548812 ## src/main/java/org/apache/commons/text/cases/CamelCase.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [commons-text] theshoeshiner commented on a diff in pull request #450: Cases API + 4 implementations (Pascal, Camel, Kebab, Snake)

theshoeshiner commented on code in PR #450: URL: https://github.com/apache/commons-text/pull/450#discussion_r1321548812 ## src/main/java/org/apache/commons/text/cases/CamelCase.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[jira] [Commented] (NET-725) Variable FILE_LIST_REGEX in class MVSFTPEntryParser must be changed

[ https://issues.apache.org/jira/browse/NET-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763706#comment-17763706 ] Andreas Wagner commented on NET-725: Hi Gary! Thanks a lot. I was now able to open a pu

[GitHub] [commons-net] haegar9766 opened a new pull request, #182: Change Class "org.apache.commons.net.ftp.parser.MVSFTPEntryParser" to support more datasets

haegar9766 opened a new pull request, #182: URL: https://github.com/apache/commons-net/pull/182 Current MVSFTPEntryParser code doesn't support all possible datasets because some RECFM options (e.g. "FBA") are not listet in "static final String FILE_LIST_REGEX" (see also Jira-Ticket [NET-72

[GitHub] [commons-statistics] ani5rudh commented on pull request #54: Update code references to use JavaDoc links.

ani5rudh commented on PR #54: URL: https://github.com/apache/commons-statistics/pull/54#issuecomment-1713791166 Hi @kinow, Previously, the declaration of the abstract method `combine` in the `Mean` class was flagged as a code smell by SonarCloud and was removed. For uniformity, I've rem

[jira] [Commented] (IMAGING-316) Support the BigTIFF file format

[ https://issues.apache.org/jira/browse/IMAGING-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763673#comment-17763673 ] Gary D. Gregory commented on IMAGING-316: - (y) > Support the BigTIFF file forma

[GitHub] [commons-lang] garydgregory commented on pull request #1110: [LANG-1705] SerializationUtils.clone() throws a ClassCastException when override writeReplace()

garydgregory commented on PR #1110: URL: https://github.com/apache/commons-lang/pull/1110#issuecomment-1713731724 @a1batr0ss Please run `mvn` -- which uses the default goal -- locally before pushing and you'll catch build failures like what just happened. -- This is an automated m

[GitHub] [commons-lang] garydgregory commented on pull request #1105: add NPE testcase in LockingVisitorsTest

garydgregory commented on PR #1105: URL: https://github.com/apache/commons-lang/pull/1105#issuecomment-1713725280 Hello @sujin0529 >I think this error is closer to IllegalArgumentException than NullPointerException. I disagree: `NullPointerException` is more _precise_ than `I

[GitHub] [commons-vfs] garydgregory commented on pull request #409: VFS-841: copying Jackrabbit standalone Main class not to depend on wh…

garydgregory commented on PR #409: URL: https://github.com/apache/commons-vfs/pull/409#issuecomment-1713671657 Hi @woonsan Understood. All we need is for this PR not to break the build ;-) Would you please update this PR? -- This is an automated message from the Apache Git Service. To

[jira] [Comment Edited] (NET-725) Variable FILE_LIST_REGEX in class MVSFTPEntryParser must be changed

[ https://issues.apache.org/jira/browse/NET-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763653#comment-17763653 ] Gary D. Gregory edited comment on NET-725 at 9/11/23 11:12 AM: ---

[jira] [Commented] (NET-725) Variable FILE_LIST_REGEX in class MVSFTPEntryParser must be changed

[ https://issues.apache.org/jira/browse/NET-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763653#comment-17763653 ] Gary D. Gregory commented on NET-725: - Hi [~AndreasWagner]  In general, you: # Fork a

[GitHub] [commons-statistics] ani5rudh opened a new pull request, #54: Update code references to use JavaDoc links.- Remove abstract definition of combine method.

ani5rudh opened a new pull request, #54: URL: https://github.com/apache/commons-statistics/pull/54 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[jira] [Commented] (NET-725) Variable FILE_LIST_REGEX in class MVSFTPEntryParser must be changed

[ https://issues.apache.org/jira/browse/NET-725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763625#comment-17763625 ] Andreas Wagner commented on NET-725: Hello Gary! I have now signed up to GitHub. Do I h

[jira] [Comment Edited] (TEXT-231) WordUtils.wrap should react to prexisting "new line string" as a wrap

[ https://issues.apache.org/jira/browse/TEXT-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763460#comment-17763460 ] Michael Karnerfors edited comment on TEXT-231 at 9/11/23 7:14 AM: ---