Glavo commented on code in PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#discussion_r1339491986
##
src/main/java/org/apache/commons/imaging/formats/webp/chunks/WebPChunk.java:
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
gwlucastrig commented on PR #318:
URL: https://github.com/apache/commons-imaging/pull/318#issuecomment-1738274426
Added Javadoc and corrected formatting. In order to support an additional
JUnit test, I needed to add a new toBytes() method for longs. This method
wasn't required for
kinow commented on PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#issuecomment-1738133122
> We don't need to use since tags IMO since we don't have a 1.0 yet.
I think there are other since tags (can't recall if only for 1.0-alphaX or
for 0.98 (sanselan) as well)
garydgregory commented on PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#issuecomment-1738088877
We don't need to use since tags IMO since we don't have a 1.0 yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
aherbert commented on code in PR #402:
URL:
https://github.com/apache/commons-collections/pull/402#discussion_r1339164850
##
src/main/java/org/apache/commons/collections4/bloomfilter/BloomFilterProducer.java:
##
@@ -38,54 +40,102 @@ public interface BloomFilterProducer {
kinow commented on code in PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#discussion_r1339171634
##
src/main/java/org/apache/commons/imaging/formats/webp/chunks/WebPChunk.java:
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
kinow commented on PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#issuecomment-1737998055
Thank you @Glavo ! Hopefully we can solve simple issues and we won't need
any major refactoring for the review :crossed_fingers: Coming back to this one
soon... (allowed GH Actions
Glavo commented on PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#issuecomment-1737971692
I've rebased and resolved conflicts.
I noticed that the project had changed a lot in my time away, so I simply
updated this PR so that it would compile and pass tests. If there
kinow commented on PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#issuecomment-1737924058
> Considering the libwebp CVE the industry is currently dealing with, would
love to see this PR's conflicts resolved and this merged in sooner than later
so I can move away from
[
https://issues.apache.org/jira/browse/IMAGING-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769687#comment-17769687
]
Gary Lucas commented on IMAGING-362:
Hi Gary,
Thanks for taking care of this (and the others you
spencerhakim commented on PR #254:
URL: https://github.com/apache/commons-imaging/pull/254#issuecomment-1737605199
Considering the libwebp CVE the industry is currently dealing with, would
love to see this PR's conflicts resolved and this merged in sooner than later
so I can move away from
Cousnouf commented on code in PR #1114:
URL: https://github.com/apache/commons-lang/pull/1114#discussion_r1338772361
##
src/main/java/org/apache/commons/lang3/builder/TypedEqualsBuilder.java:
##
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
[
https://issues.apache.org/jira/browse/IMAGING-344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated IMAGING-344:
Fix Version/s: 1.0
(was: 1.0-alpha3)
> NPE in PcxWriter for PCX
[
https://issues.apache.org/jira/browse/IMAGING-358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated IMAGING-358:
Fix Version/s: (was: 1.0-alpha3)
> "RationalNumber" class is "public"
>
[
https://issues.apache.org/jira/browse/IMAGING-339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated IMAGING-339:
Fix Version/s: 1.0
(was: 1.0-alpha3)
> Basic WebP support
>
[
https://issues.apache.org/jira/browse/IMAGING-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated IMAGING-363:
Fix Version/s: 1.0
(was: 1.0-alpha3)
>
[
https://issues.apache.org/jira/browse/IMAGING-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated IMAGING-362:
Fix Version/s: 1.0
(was: 1.0-alpha3)
> TIFF tags 0x111 and 0x117
[
https://issues.apache.org/jira/browse/IMAGING-360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved IMAGING-360.
-
Fix Version/s: 1.0
Resolution: Fixed
> Missing some TIFF compression information
garydgregory merged PR #311:
URL: https://github.com/apache/commons-imaging/pull/311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory commented on code in PR #318:
URL: https://github.com/apache/commons-imaging/pull/318#discussion_r1338737448
##
src/main/java/org/apache/commons/imaging/formats/tiff/TiffField.java:
##
@@ -234,6 +234,14 @@ public int[] getIntArrayValue() throws ImagingException {
[
https://issues.apache.org/jira/browse/IO-809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769657#comment-17769657
]
Gary D. Gregory edited comment on IO-809 at 9/27/23 2:46 PM:
-
{quote}As the
[
https://issues.apache.org/jira/browse/IO-809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769657#comment-17769657
]
Gary D. Gregory commented on IO-809:
bq. As the current signature returns void, there shouldn't be any
Cousnouf commented on code in PR #1114:
URL: https://github.com/apache/commons-lang/pull/1114#discussion_r1338516200
##
src/test/java/org/apache/commons/lang3/builder/TypedEqualsBuilderTest.java:
##
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Cousnouf commented on PR #1114:
URL: https://github.com/apache/commons-lang/pull/1114#issuecomment-1737544105
I've addressed the comments. This version may tend to something better :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/IO-810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769651#comment-17769651
]
Gary D. Gregory commented on IO-810:
I like the idea of documenting the IOException only.
> Wrong
[
https://issues.apache.org/jira/browse/CONFIGURATION-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769623#comment-17769623
]
Gary D. Gregory commented on CONFIGURATION-836:
---
[~michieldx]
Feel free to provide a
[
https://issues.apache.org/jira/browse/IO-810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gregor Dschung updated IO-810:
--
Summary: Wrong JavaDoc regarding FileNotFoundException in FileUtils (was:
Wrong JavaDoc regarding
[
https://issues.apache.org/jira/browse/IO-809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769604#comment-17769604
]
Gregor Dschung edited comment on IO-809 at 9/27/23 1:30 PM:
As the current
[
https://issues.apache.org/jira/browse/IO-809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769604#comment-17769604
]
Gregor Dschung edited comment on IO-809 at 9/27/23 1:29 PM:
As the current
[
https://issues.apache.org/jira/browse/IO-809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769604#comment-17769604
]
Gregor Dschung commented on IO-809:
---
As the current signature returns void, there shouldn't be any
[
https://issues.apache.org/jira/browse/IO-810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769596#comment-17769596
]
Gregor Dschung edited comment on IO-810 at 9/27/23 1:12 PM:
Okay, I'll do so. I
[
https://issues.apache.org/jira/browse/IO-810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769596#comment-17769596
]
Gregor Dschung commented on IO-810:
---
Okay, I'll do so. I see two options:
# As {{NoSuchFileException}} is
Cousnouf commented on code in PR #1114:
URL: https://github.com/apache/commons-lang/pull/1114#discussion_r1338582697
##
src/test/java/org/apache/commons/lang3/builder/TypedEqualsBuilderTest.java:
##
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Cousnouf commented on code in PR #1114:
URL: https://github.com/apache/commons-lang/pull/1114#discussion_r1338531019
##
src/main/java/org/apache/commons/lang3/builder/TypedEqualsBuilder.java:
##
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
elharo commented on code in PR #1114:
URL: https://github.com/apache/commons-lang/pull/1114#discussion_r1338576635
##
src/test/java/org/apache/commons/lang3/builder/TypedEqualsBuilderTest.java:
##
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Cousnouf commented on code in PR #1114:
URL: https://github.com/apache/commons-lang/pull/1114#discussion_r1338563661
##
src/main/java/org/apache/commons/lang3/builder/TypedEqualsBuilder.java:
##
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Cousnouf commented on code in PR #1114:
URL: https://github.com/apache/commons-lang/pull/1114#discussion_r1338546647
##
src/main/java/org/apache/commons/lang3/builder/TypedEqualsBuilder.java:
##
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Cousnouf commented on code in PR #1114:
URL: https://github.com/apache/commons-lang/pull/1114#discussion_r1338546647
##
src/main/java/org/apache/commons/lang3/builder/TypedEqualsBuilder.java:
##
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Cousnouf commented on code in PR #1114:
URL: https://github.com/apache/commons-lang/pull/1114#discussion_r1338531019
##
src/main/java/org/apache/commons/lang3/builder/TypedEqualsBuilder.java:
##
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Cousnouf commented on code in PR #1114:
URL: https://github.com/apache/commons-lang/pull/1114#discussion_r1338516200
##
src/test/java/org/apache/commons/lang3/builder/TypedEqualsBuilderTest.java:
##
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
ecki commented on code in PR #1114:
URL: https://github.com/apache/commons-lang/pull/1114#discussion_r1338513972
##
src/main/java/org/apache/commons/lang3/builder/TypedEqualsBuilder.java:
##
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
garydgregory commented on PR #392:
URL:
https://github.com/apache/commons-collections/pull/392#issuecomment-1737270338
Hello @saurabh-rahate
Thank you for your PR. Would you please resolve conflicts and rebase on
master?
--
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/IO-810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769570#comment-17769570
]
Gary D. Gregory commented on IO-810:
In general, it's better to update the Javadoc to match the code.
elharo commented on code in PR #1114:
URL: https://github.com/apache/commons-lang/pull/1114#discussion_r1338483094
##
src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java:
##
@@ -450,6 +450,15 @@ public static boolean reflectionEquals(final Object lhs,
final
[
https://issues.apache.org/jira/browse/VFS-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17769561#comment-17769561
]
Usman Ashraf Bajwah commented on VFS-842:
-
I have tried both but it didn't work. I assume that while
garydgregory commented on code in PR #1114:
URL: https://github.com/apache/commons-lang/pull/1114#discussion_r1338471365
##
src/main/java/org/apache/commons/lang3/builder/TypedEqualsBuilder.java:
##
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
garydgregory commented on PR #1114:
URL: https://github.com/apache/commons-lang/pull/1114#issuecomment-1737220327
Hello @Cousnouf
Please run `mvn` locally and fix issues before you push to avoid broken
builds.
--
This is an automated message from the Apache Git Service.
To respond to
Marc Cappelletti created LANG-1712:
--
Summary: Complete the EqualsBuilder to manage type equivalence
Key: LANG-1712
URL: https://issues.apache.org/jira/browse/LANG-1712
Project: Commons Lang
garydgregory commented on PR #25:
URL: https://github.com/apache/commons-jxpath/pull/25#issuecomment-1737212833
> Please fix the issue with CVS 2022-41852.
Note that the CVE has been rejected.
--
This is an automated message from the Apache Git Service.
To respond to the message,
ecki commented on PR #1114:
URL: https://github.com/apache/commons-lang/pull/1114#issuecomment-1737138634
Change looks quite good and complete. Not sure about the size, it might
require a Apache contributor agreement. With this PR and Dev mail you probably
don’t need an extra JIRA (or a
Gregor Dschung created IO-810:
-
Summary: Wrong JavaDoc regarding exception in FileUtils
Key: IO-810
URL: https://issues.apache.org/jira/browse/IO-810
Project: Commons IO
Issue Type: Bug
[
https://issues.apache.org/jira/browse/IO-810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gregor Dschung updated IO-810:
--
Description:
The JavaDoc of {{FileUtils#readFileToString(...)}} is stating that a
52 matches
Mail list logo
