[jira] [Created] (POOL-413) [GOP] Race condition while returning objects. maxIdle is ignored

2023-10-03 Thread Adrien Bernard (Jira)
Adrien Bernard created POOL-413: --- Summary: [GOP] Race condition while returning objects. maxIdle is ignored Key: POOL-413 URL: https://issues.apache.org/jira/browse/POOL-413 Project: Commons Pool

[jira] [Resolved] (IO-815) XmlStreamReader encoding match RE is too strict

2023-10-03 Thread Sebb (Jira)
[ https://issues.apache.org/jira/browse/IO-815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved IO-815. - Resolution: Fixed > XmlStreamReader encoding match RE is too strict > --- > >

[jira] [Commented] (IO-815) XmlStreamReader encoding match RE is too strict

2023-10-03 Thread Sebb (Jira)
[ https://issues.apache.org/jira/browse/IO-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771647#comment-17771647 ] Sebb commented on IO-815: - Fixed in https://github.com/apache/commons-io/commit/841b5fafe13683389d07

[jira] [Updated] (IO-815) XmlStreamReader encoding match RE is too strict

2023-10-03 Thread Sebb (Jira)
[ https://issues.apache.org/jira/browse/IO-815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb updated IO-815: Fix Version/s: 2.14.1 > XmlStreamReader encoding match RE is too strict > --- > >

[jira] [Created] (IO-815) XmlStreamReader encoding match RE is too strict

2023-10-03 Thread Sebb (Jira)
Sebb created IO-815: --- Summary: XmlStreamReader encoding match RE is too strict Key: IO-815 URL: https://issues.apache.org/jira/browse/IO-815 Project: Commons IO Issue Type: Bug Components: Stream

Re: [PR] Check for null value with the appropriate assertion method [commons-lang]

2023-10-03 Thread via GitHub
garydgregory closed pull request #1117: Check for null value with the appropriate assertion method URL: https://github.com/apache/commons-lang/pull/1117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Check for null value with the appropriate assertion method [commons-lang]

2023-10-03 Thread via GitHub
garydgregory commented on PR #1117: URL: https://github.com/apache/commons-lang/pull/1117#issuecomment-1745249840 -1 I agree with @aherbert Throwing an NPE for null input to a method makes perfect sense. In this case, this PR throws an NPE because internal processing happens to see a

[jira] [Commented] (IO-814) FileUtils.deleteDirectory can throw UncheckedIOException

2023-10-03 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/IO-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771526#comment-17771526 ] Gilles Sadowski commented on IO-814: bq. This was a behavior breaking change, [...] Ther

Re: [PR] Check for null value with the appropriate assertion method [commons-lang]

2023-10-03 Thread via GitHub
aherbert commented on PR #1117: URL: https://github.com/apache/commons-lang/pull/1117#issuecomment-1745211972 This is not fixing any bugs, and introduces behaviour changes. The behavioural change is to throw NPE instead of IAE when an argument to reflect on a `target` using `FieldUtil

[jira] [Created] (IO-814) FileUtils.deleteDirectory can throw UncheckedIOException

2023-10-03 Thread Elliotte Rusty Harold (Jira)
Elliotte Rusty Harold created IO-814: Summary: FileUtils.deleteDirectory can throw UncheckedIOException Key: IO-814 URL: https://issues.apache.org/jira/browse/IO-814 Project: Commons IO I

Re: [PR] NUMBERS-205: Introduces isZero() to Addition and isOne() to Multiplication [commons-numbers]

2023-10-03 Thread via GitHub
HaraldKi commented on code in PR #138: URL: https://github.com/apache/commons-numbers/pull/138#discussion_r1344032055 ## commons-numbers-core/src/test/java/org/apache/commons/numbers/core/DDTest.java: ## @@ -78,6 +78,30 @@ void testZero() { Assertions.assertSame(DD.ZERO

Re: [PR] NUMBERS-205: Introduces isZero() to Addition and isOne() to Multiplication [commons-numbers]

2023-10-03 Thread via GitHub
HaraldKi commented on code in PR #138: URL: https://github.com/apache/commons-numbers/pull/138#discussion_r1344030542 ## commons-numbers-core/src/main/java/org/apache/commons/numbers/core/DD.java: ## @@ -1924,6 +1924,20 @@ public DD pow(int n) { return computePow(x, xx,

Re: [PR] NUMBERS-205: Introduces isZero() to Addition and isOne() to Multiplication [commons-numbers]

2023-10-03 Thread via GitHub
HaraldKi commented on code in PR #138: URL: https://github.com/apache/commons-numbers/pull/138#discussion_r1344030146 ## commons-numbers-core/src/main/java/org/apache/commons/numbers/core/Multiplication.java: ## @@ -44,4 +44,12 @@ public interface Multiplication { * @retur

Re: [PR] NUMBERS-205: Introduces isZero() to Addition and isOne() to Multiplication [commons-numbers]

2023-10-03 Thread via GitHub
HaraldKi commented on code in PR #138: URL: https://github.com/apache/commons-numbers/pull/138#discussion_r1344029696 ## commons-numbers-core/src/test/java/org/apache/commons/numbers/core/DDTest.java: ## @@ -78,6 +78,30 @@ void testZero() { Assertions.assertSame(DD.ZERO

Re: [PR] NUMBERS-205: Introduces isZero() to Addition and isOne() to Multiplication [commons-numbers]

2023-10-03 Thread via GitHub
aherbert commented on code in PR #138: URL: https://github.com/apache/commons-numbers/pull/138#discussion_r1343813273 ## commons-numbers-core/src/main/java/org/apache/commons/numbers/core/Multiplication.java: ## @@ -44,4 +44,12 @@ public interface Multiplication { * @retur

Re: [PR] NUMBERS-205: Introduces isZero() to Addition and isOne() to Multiplication [commons-numbers]

2023-10-03 Thread via GitHub
HaraldKi commented on code in PR #138: URL: https://github.com/apache/commons-numbers/pull/138#discussion_r1343751006 ## commons-numbers-core/src/main/java/org/apache/commons/numbers/core/Multiplication.java: ## @@ -44,4 +44,12 @@ public interface Multiplication { * @retur

[PR] Check for null value with the appropriate assertion method [commons-lang]

2023-10-03 Thread via GitHub
valery1707 opened a new pull request, #1117: URL: https://github.com/apache/commons-lang/pull/1117 Replace all occurrences of `Assert.isTrue\((\w+)\s?!=\s?null\s*,` with `Assert.notNull($1,`. -- This is an automated message from the Apache Git Service. To respond to the message, please lo