yakovsh commented on PR #439:
URL: https://github.com/apache/commons-compress/pull/439#issuecomment-1809492002
I re-based from master and it looks like the changes to IOUtils are
sufficient to fix this issue. To be sure, I re-ran the fuzzing harness and it
is not finding this issue again. I
yakovsh commented on PR #438:
URL: https://github.com/apache/commons-compress/pull/438#issuecomment-1809454401
I think putting a try/catch around the call to Instant.ofEpochSecond() is
probably the best option, I will change the PR to match.
--
This is an automated message from the Apache
garydgregory commented on PR #438:
URL: https://github.com/apache/commons-compress/pull/438#issuecomment-1809382916
We are not dealing with ints or longs here though, we are creating a time
object based on a string, so maybe this is not what we need to worry about. It
could be that using a
yakovsh commented on PR #438:
URL: https://github.com/apache/commons-compress/pull/438#issuecomment-1809221664
> Hello @yakovsh Thank you for your PR. Can you point to the TAR or PAX
specifications for the legal value range? If there are legal values that we
cannot represent in a Java Insta
garydgregory commented on PR #439:
URL: https://github.com/apache/commons-compress/pull/439#issuecomment-1809213574
Hello @yakovsh
Thank you for the PR.
If we thrown an exception, we should document what part of the ARJ
specification the file violates.
Otherwise, what about:
```
yakovsh opened a new pull request, #439:
URL: https://github.com/apache/commons-compress/pull/439
This adds a validation check for detecting when the header size in ARJ files
is set to zero and ArjInputStream fails to parse the file. Related to fuzzing
work tracked under COMPRESS-632.
--
garydgregory commented on PR #438:
URL: https://github.com/apache/commons-compress/pull/438#issuecomment-1809102560
Hello @yakovsh
Thank you for your PR.
Can you point to the TAR or PAX specifications for the legal value range? If
there are legal values that we cannot represent in a J
yakovsh opened a new pull request, #438:
URL: https://github.com/apache/commons-compress/pull/438
This is related to the fuzzing work in COMPRESS-632. The PR adds a
validation check for time values in PAX headers that are valid Long values but
out of range for java.time.Instant.
--
This
yakovsh closed pull request #435: COMPRESS-632: Adding a check for invalid
maxCodeSize
URL: https://github.com/apache/commons-compress/pull/435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
garydgregory merged PR #334:
URL: https://github.com/apache/commons-imaging/pull/334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
[
https://issues.apache.org/jira/browse/MATH-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785619#comment-17785619
]
Axel Howind commented on MATH-1661:
---
An automatic module name in a 3.x release would be
[
https://issues.apache.org/jira/browse/MATH-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785592#comment-17785592
]
Gary D. Gregory commented on MATH-1661:
---
You need to build with Java 11+ and define
[
https://issues.apache.org/jira/browse/MATH-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785590#comment-17785590
]
Gilles Sadowski commented on MATH-1661:
---
Does it mean that whether the file will exi
gwlucastrig commented on code in PR #334:
URL: https://github.com/apache/commons-imaging/pull/334#discussion_r1391390920
##
src/main/java/org/apache/commons/imaging/formats/jpeg/decoder/JpegDecoder.java:
##
@@ -46,6 +46,10 @@
import org.apache.commons.imaging.formats.jpeg.segme
[
https://issues.apache.org/jira/browse/MATH-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785558#comment-17785558
]
Alex Herbert commented on MATH-1661:
CM already defines the commons.module.name for al
yakovsh commented on PR #433:
URL: https://github.com/apache/commons-compress/pull/433#issuecomment-1808458337
Thank you for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
garydgregory commented on code in PR #334:
URL: https://github.com/apache/commons-imaging/pull/334#discussion_r1391297015
##
src/main/java/org/apache/commons/imaging/formats/jpeg/decoder/JpegDecoder.java:
##
@@ -46,6 +46,10 @@
import org.apache.commons.imaging.formats.jpeg.segm
[
https://issues.apache.org/jira/browse/MATH-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785537#comment-17785537
]
Gary D. Gregory commented on MATH-1661:
---
If you use the latest parent POM, it will g
gwlucastrig commented on PR #334:
URL: https://github.com/apache/commons-imaging/pull/334#issuecomment-1808386847
Well, the "scrap it and start again" option is still available if we need
it, but I attempted to rebase and push the changes your requested up to github.
If it didn't work, le
gwlucastrig commented on PR #334:
URL: https://github.com/apache/commons-imaging/pull/334#issuecomment-1808280389
I am not particularly adept at git, and I can't figure out how to rebase
(the rebase attempt fails and git complains that I have unstaged changes). So
I am going to scrap this
[
https://issues.apache.org/jira/browse/MATH-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785499#comment-17785499
]
Gilles Sadowski commented on MATH-1661:
---
A (too) quick look on the web reveals that
garydgregory commented on code in PR #334:
URL: https://github.com/apache/commons-imaging/pull/334#discussion_r1391169140
##
src/main/java/org/apache/commons/imaging/formats/jpeg/decoder/JpegDecoder.java:
##
@@ -452,9 +454,21 @@ public void visitSos(final int marker, final byte[
garydgregory commented on PR #334:
URL: https://github.com/apache/commons-imaging/pull/334#issuecomment-1808236363
Also, please rebase on git master, I moved the test data folder under
resources and had to adjust some tests.
--
This is an automated message from the Apache Git Service.
garydgregory commented on PR #334:
URL: https://github.com/apache/commons-imaging/pull/334#issuecomment-1808231889
Hi @gwlucastrig
Yes, run: `mvn clean site` and `open target/site/jacoco/index.html`: The
site is generated with a JaCoCo report. There is probably a short-hand Maven
invoc
gwlucastrig commented on code in PR #334:
URL: https://github.com/apache/commons-imaging/pull/334#discussion_r1391160794
##
src/main/java/org/apache/commons/imaging/formats/jpeg/decoder/JpegDecoder.java:
##
@@ -452,9 +454,21 @@ public void visitSos(final int marker, final byte[]
garydgregory commented on code in PR #334:
URL: https://github.com/apache/commons-imaging/pull/334#discussion_r1391157675
##
src/test/java/org/apache/commons/imaging/formats/tiff/TiffJpegTest.java:
##
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
gwlucastrig commented on PR #334:
URL: https://github.com/apache/commons-imaging/pull/334#issuecomment-1808188684
Gary,
Thanks for your comments which, as usual, were spot on. I will address them
as soon as I can.
I did have a question. Some of the coverage results were not w
gwlucastrig commented on code in PR #334:
URL: https://github.com/apache/commons-imaging/pull/334#discussion_r1391128095
##
src/test/java/org/apache/commons/imaging/formats/tiff/TiffJpegTest.java:
##
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
gwlucastrig commented on code in PR #334:
URL: https://github.com/apache/commons-imaging/pull/334#discussion_r1391122427
##
src/main/java/org/apache/commons/imaging/formats/tiff/datareaders/DataInterpreterJpeg.java:
##
@@ -0,0 +1,146 @@
+/* --
garydgregory commented on code in PR #334:
URL: https://github.com/apache/commons-imaging/pull/334#discussion_r1391073403
##
src/test/java/org/apache/commons/imaging/formats/tiff/TiffJpegTest.java:
##
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
garydgregory merged PR #1129:
URL: https://github.com/apache/commons-lang/pull/1129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@c
Colin Zhang created JXPATH-202:
--
Summary: selector by predicate of Long value get wrong result?
Key: JXPATH-202
URL: https://issues.apache.org/jira/browse/JXPATH-202
Project: Commons JXPath
Issu
32 matches
Mail list logo
