Re: [PR] LOGGING-185: Fix failing tests [commons-logging]

2023-11-18 Thread via GitHub
garydgregory merged PR #180: URL: https://github.com/apache/commons-logging/pull/180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] LOGGING-185: Fix failing tests [commons-logging]

2023-11-18 Thread via GitHub
ppkarwasz commented on PR #180: URL: https://github.com/apache/commons-logging/pull/180#issuecomment-1817667341 Remark: this PR solves the same problems as #157. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] Fix failing tests [commons-logging]

2023-11-18 Thread via GitHub
ppkarwasz opened a new pull request, #180: URL: https://github.com/apache/commons-logging/pull/180 This PR fixes multiple small problems that cause test failures: - the names of the generated JAR files and those used in tests based on `PathableClassloader` are not matching any more,

[PR] Resolving few implementation smells using Refactoring techniques [commons-dbutils]

2023-11-18 Thread via GitHub
sanjanarampurkottur01 opened a new pull request, #218: URL: https://github.com/apache/commons-dbutils/pull/218 Made changes to resolve implementation smells using the refactoring techniques: 1. Extract method 2. Rename method/variable 3. Decompose conditional 4. Introduce

[jira] [Updated] (JEXL-414) SoftCache may suffer from race conditions

2023-11-18 Thread Henri Biestro (Jira)
[ https://issues.apache.org/jira/browse/JEXL-414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Biestro updated JEXL-414: --- Fix Version/s: 3.3.1 > SoftCache may suffer from race conditions >

Re: [PR] [Imaging-369] Fix array bounds exception for TIFF with internal JPEG … [commons-imaging]

2023-11-18 Thread via GitHub
gwlucastrig commented on code in PR #335: URL: https://github.com/apache/commons-imaging/pull/335#discussion_r1398239328 ## src/test/java/org/apache/commons/imaging/formats/tiff/TiffJpegTest.java: ## @@ -161,6 +166,11 @@ public void testFullPixelMatch() throws IOException {

[jira] [Commented] (COMPRESS-651) Uncompress BZIP2 File Max Output is 900000 chars

2023-11-18 Thread Ahmadin Badruddin (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787505#comment-17787505 ] Ahmadin Badruddin commented on COMPRESS-651: Yes, I can. (⎈|) /cfm/ pbzip2 -d my1.tar.bz2

Re: [PR] refactor: use ReentrantLock in PoolableConnection.close (#DBCP-591) [commons-dbcp]

2023-11-18 Thread via GitHub
garydgregory commented on PR #322: URL: https://github.com/apache/commons-dbcp/pull/322#issuecomment-1817529133 Hello @psteitz ? Any thoughts on whether we should bring in this PR? How can we make sure that this does make things worse and in fact better on Java 8, 11, 17, and 21? Is

Re: [PR] refactor: use ReentrantLock in PoolableConnection.close (#DBCP-591) [commons-dbcp]

2023-11-18 Thread via GitHub
cortlepp-intershop commented on PR #322: URL: https://github.com/apache/commons-dbcp/pull/322#issuecomment-1817524088 True, but do you have a suggestion on how to write such a test? Since the Issue is not that something doesn't work, it's rather a performance thing. The current

[jira] [Resolved] (LANG-1681) Wrong javadoc exception in several methods and classes

2023-11-18 Thread Diego Marcilio (Jira)
[ https://issues.apache.org/jira/browse/LANG-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Diego Marcilio resolved LANG-1681. -- Resolution: Fixed Fixed in https://github.com/apache/commons-lang/pull/1047 > Wrong javadoc

[jira] [Commented] (COMPRESS-651) Uncompress BZIP2 File Max Output is 900000 chars

2023-11-18 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787487#comment-17787487 ] Gary D. Gregory commented on COMPRESS-651: -- Can you successfully get back to the source txt

[jira] [Commented] (IMAGING-369) TIFF JPEG reader encounters array bounds exception on edge cases.

2023-11-18 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IMAGING-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787478#comment-17787478 ] Gary D. Gregory commented on IMAGING-369: - Hi [~gwlucas], Note that we have a Jira field for

Re: [PR] refactor: use ReentrantLock in PoolableConnection.close (#DBCP-591) [commons-dbcp]

2023-11-18 Thread via GitHub
garydgregory commented on PR #322: URL: https://github.com/apache/commons-dbcp/pull/322#issuecomment-1817479141 > Hey @garydgregory any thoughts? Hello @cortlepp-intershop There is no test to prove this fixes anything. -- This is an automated message from the Apache Git

Re: [PR] refactor: use ReentrantLock in PoolableConnection.close (#DBCP-591) [commons-dbcp]

2023-11-18 Thread via GitHub
cortlepp-intershop commented on PR #322: URL: https://github.com/apache/commons-dbcp/pull/322#issuecomment-1817449233 Hey @garydgregory any thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] GEOMETRY-110 [commons-geometry]

2023-11-18 Thread via GitHub
agoss94 commented on code in PR #225: URL: https://github.com/apache/commons-geometry/pull/225#discussion_r1398127457 ## commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/hull/ConvexHull3D.java: ## @@ -0,0 +1,697 @@ +/* + * Licensed to the

Re: [PR] GEOMETRY-110 [commons-geometry]

2023-11-18 Thread via GitHub
agoss94 commented on code in PR #225: URL: https://github.com/apache/commons-geometry/pull/225#discussion_r1398127457 ## commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/hull/ConvexHull3D.java: ## @@ -0,0 +1,697 @@ +/* + * Licensed to the