[
https://issues.apache.org/jira/browse/IO-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788966#comment-17788966
]
hellozrh commented on IO-822:
-
PR is https://github.com/apache/commons-io/pull/515
> I hope to add a file size
hellozrh opened a new pull request, #515:
URL: https://github.com/apache/commons-io/pull/515
File size conversion tool, supporting mutual conversion of TB, GB, MB, KB,
Byte, etc.,as well as converting the size of numeric types into human-readable
strings.
anirudh711 opened a new pull request, #429:
URL: https://github.com/apache/commons-collections/pull/429
## PR Overview
This PR propses a fix for the following tests:
-
`org.apache.commons.collections4.multimap.ArrayListValuedHashMapTest.testMultiValuedMapIterator`
-
[
https://issues.apache.org/jira/browse/COLLECTIONS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anirudh Ragavender updated COLLECTIONS-850:
---
Description:
Overview of PR
This PR proposes a fix for the following
Anirudh Ragavender created COLLECTIONS-850:
--
Summary: testMultiValuedMapIterator is non-deterministic
Key: COLLECTIONS-850
URL: https://issues.apache.org/jira/browse/COLLECTIONS-850
Project:
William Price created JEXL-416:
--
Summary: Null-valued pragma throws NPE in 3.3
Key: JEXL-416
URL: https://issues.apache.org/jira/browse/JEXL-416
Project: Commons JEXL
Issue Type: Bug
anirudh711 opened a new pull request, #428:
URL: https://github.com/apache/commons-collections/pull/428
## **Problem:**
The test testCollectionToArray2 is flaky because the array in use does not
maintain the order of the elements. This was caught by the
yakovsh commented on code in PR #442:
URL: https://github.com/apache/commons-compress/pull/442#discussion_r1402701318
##
src/main/java/org/apache/commons/compress/archivers/dump/TapeInputStream.java:
##
@@ -294,6 +294,9 @@ public void resetBlockSize(final int recsPerBlock,
yakovsh commented on code in PR #441:
URL: https://github.com/apache/commons-compress/pull/441#discussion_r1402688746
##
src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveInputStream.java:
##
@@ -362,7 +362,11 @@ public int read(final byte[] b, final int off,
yakovsh commented on code in PR #441:
URL: https://github.com/apache/commons-compress/pull/441#discussion_r1402677972
##
src/test/java/org/apache/commons/compress/archivers/cpio/CpioArchiveEntryTest.java:
##
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation
garydgregory commented on code in PR #222:
URL: https://github.com/apache/commons-codec/pull/222#discussion_r1402656990
##
src/test/java/org/apache/commons/codec/net/PercentCodecTest.java:
##
@@ -105,6 +106,13 @@ public void testEncodeUnsupportedObject() {
[
https://issues.apache.org/jira/browse/COMPRESS-654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xudong Yang updated COMPRESS-654:
-
Description:
We maintain the Bazel ([https://bazel.build/]) build system, which uses Apache
garydgregory commented on code in PR #441:
URL: https://github.com/apache/commons-compress/pull/441#discussion_r1402656352
##
src/main/java/org/apache/commons/compress/archivers/cpio/CpioArchiveInputStream.java:
##
@@ -362,7 +362,11 @@ public int read(final byte[] b, final int
Xudong Yang created COMPRESS-654:
Summary: Issue extracting certain sparse tarballs
Key: COMPRESS-654
URL: https://issues.apache.org/jira/browse/COMPRESS-654
Project: Commons Compress
Issue
garydgregory commented on code in PR #441:
URL: https://github.com/apache/commons-compress/pull/441#discussion_r1402652002
##
src/test/java/org/apache/commons/compress/archivers/cpio/CpioArchiveEntryTest.java:
##
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software
garydgregory commented on code in PR #442:
URL: https://github.com/apache/commons-compress/pull/442#discussion_r1402651501
##
src/main/java/org/apache/commons/compress/archivers/dump/DumpArchiveConstants.java:
##
@@ -26,7 +26,7 @@ public final class DumpArchiveConstants {
garydgregory commented on code in PR #442:
URL: https://github.com/apache/commons-compress/pull/442#discussion_r1402647680
##
src/main/java/org/apache/commons/compress/archivers/dump/TapeInputStream.java:
##
@@ -294,6 +294,9 @@ public void resetBlockSize(final int recsPerBlock,
garydgregory merged PR #444:
URL: https://github.com/apache/commons-compress/pull/444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
arthurscchan commented on PR #222:
URL: https://github.com/apache/commons-codec/pull/222#issuecomment-1823363053
Hi, I have added unit test. I am not sure about combining the PRs since they
are opened as 4 different issues in the JIRA.
--
This is an automated message from the Apache Git
arthurscchan commented on PR #221:
URL: https://github.com/apache/commons-codec/pull/221#issuecomment-1823364457
Hi, I have added the unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
arthurscchan commented on PR #220:
URL: https://github.com/apache/commons-codec/pull/220#issuecomment-1823363932
Hi, I have added the unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
arthurscchan commented on code in PR #219:
URL: https://github.com/apache/commons-codec/pull/219#discussion_r1402525412
##
src/test/java/org/apache/commons/codec/language/RefinedSoundexTest.java:
##
@@ -93,4 +94,13 @@ public void testNewInstance2() {
public void
garydgregory commented on code in PR #219:
URL: https://github.com/apache/commons-codec/pull/219#discussion_r1402516762
##
src/test/java/org/apache/commons/codec/language/RefinedSoundexTest.java:
##
@@ -93,4 +94,13 @@ public void testNewInstance2() {
public void
arthurscchan commented on PR #219:
URL: https://github.com/apache/commons-codec/pull/219#issuecomment-1823262547
@garydgregory Thanks for the comment. I have added a unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
sanjanarampurkottur01 commented on PR #222:
URL: https://github.com/apache/commons-dbutils/pull/222#issuecomment-1823246922
Hi @garydgregory, could you please review the Pull request whenever you have
time? Thank you!
--
This is an automated message from the Apache Git Service.
To
sanjanarampurkottur01 commented on PR #222:
URL: https://github.com/apache/commons-dbutils/pull/222#issuecomment-1823216947
> AbstractTestColumnHandler
Hi @garydgregory, I have made changes to the mentioned files. However, the
empty if block cannot be fixed since we intend to not do
sanjanarampurkottur01 commented on PR #222:
URL: https://github.com/apache/commons-dbutils/pull/222#issuecomment-1823182229
> One PR please, this one.
Sure. Will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
garydgregory commented on PR #222:
URL: https://github.com/apache/commons-codec/pull/222#issuecomment-1823156553
Let's just have ONE PR instead of one-liner PRs. Especially since these all
claim to fix the exact same kind of issue. Also, you MUST provide a matching
test.
--
This is
garydgregory commented on PR #221:
URL: https://github.com/apache/commons-codec/pull/221#issuecomment-1823153671
@arthurscchan
You'll need a unit test to prove what the main change does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
garydgregory commented on PR #220:
URL: https://github.com/apache/commons-codec/pull/220#issuecomment-1823151696
Hello @arthurscchan
Same comment: You'll need a unit test to prove what the main code does.
--
This is an automated message from the Apache Git Service.
To respond to the
[ https://issues.apache.org/jira/browse/CODEC-312 ]
Sheung Chi Chan deleted comment on CODEC-312:
---
was (Author: JIRAUSER303223):
Suggested fixing PR: https://github.com/apache/commons-codec/pull/220
> MatchRatingApproachEncoder.encode throw
[ https://issues.apache.org/jira/browse/CODEC-313 ]
Sheung Chi Chan deleted comment on CODEC-313:
---
was (Author: JIRAUSER303223):
Suggested fix PR: https://github.com/apache/commons-codec/pull/221
> QuotedPrintableCodec.encodeQuotedPrintable
garydgregory commented on PR #219:
URL: https://github.com/apache/commons-codec/pull/219#issuecomment-1823149555
Hello @arthurscchan
You'll need a unit test to prove this change works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
[
https://issues.apache.org/jira/browse/CODEC-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788834#comment-17788834
]
Sheung Chi Chan commented on CODEC-313:
---
Suggested fix PR:
[ https://issues.apache.org/jira/browse/CODEC-311 ]
Sheung Chi Chan deleted comment on CODEC-311:
---
was (Author: JIRAUSER303223):
Suggested fixing PR: https://github.com/apache/commons-codec/pull/219
> RefinedSoundex.getMappingCode throw
[
https://issues.apache.org/jira/browse/CODEC-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788833#comment-17788833
]
Sheung Chi Chan commented on CODEC-312:
---
Suggested fixing PR:
[
https://issues.apache.org/jira/browse/CODEC-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788832#comment-17788832
]
Sheung Chi Chan commented on CODEC-311:
---
Suggested fixing PR:
arthurscchan opened a new pull request, #222:
URL: https://github.com/apache/commons-codec/pull/222
This fixes a possible IndexOutOfBoundsException in
arthurscchan opened a new pull request, #220:
URL: https://github.com/apache/commons-codec/pull/220
This fixes a possible StringIndexOutOfBoundException in
arthurscchan opened a new pull request, #219:
URL: https://github.com/apache/commons-codec/pull/219
This fixes a possible ArrayIndexOutOfBoundException in
Sheung Chi Chan created CODEC-314:
-
Summary: PercentCodec.insertAlwaysEncodeChars throws
IndexOutOfBoundException
Key: CODEC-314
URL: https://issues.apache.org/jira/browse/CODEC-314
Project: Commons
Sheung Chi Chan created CODEC-313:
-
Summary: QuotedPrintableCodec.encodeQuotedPrintable throws
ArrayIndexOutOfBoundException
Key: CODEC-313
URL: https://issues.apache.org/jira/browse/CODEC-313
Sheung Chi Chan created CODEC-312:
-
Summary: MatchRatingApproachEncoder.encode throw
StringIndexOutOfBound
Key: CODEC-312
URL: https://issues.apache.org/jira/browse/CODEC-312
Project: Commons Codec
Sheung Chi Chan created CODEC-311:
-
Summary: RefinedSoundex.getMappingCode throw
ArrayIndexOutOfBoundException
Key: CODEC-311
URL: https://issues.apache.org/jira/browse/CODEC-311
Project: Commons
garydgregory commented on PR #222:
URL: https://github.com/apache/commons-dbutils/pull/222#issuecomment-1823076057
One PR please, this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
sanjanarampurkottur01 commented on PR #222:
URL: https://github.com/apache/commons-dbutils/pull/222#issuecomment-1823061641
> Hi @sanjanarampurkottur01 Hm, ok, then you should not only address the one
file, but all files:
>
> ```
> [ERROR]
[
https://issues.apache.org/jira/browse/IO-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788795#comment-17788795
]
hellozrh commented on IO-822:
-
Far more than that. FileUtils. bytCountToDisplaySize only supports converting
garydgregory merged PR #220:
URL: https://github.com/apache/commons-dbutils/pull/220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory commented on code in PR #220:
URL: https://github.com/apache/commons-dbutils/pull/220#discussion_r1402139176
##
src/test/java/org/apache/commons/dbutils/MockResultSet.java:
##
@@ -53,6 +54,8 @@ public static ResultSet create(final ResultSetMetaData
metaData, final
garydgregory commented on code in PR #220:
URL: https://github.com/apache/commons-dbutils/pull/220#discussion_r1402139176
##
src/test/java/org/apache/commons/dbutils/MockResultSet.java:
##
@@ -53,6 +54,8 @@ public static ResultSet create(final ResultSetMetaData
metaData, final
garydgregory merged PR #337:
URL: https://github.com/apache/commons-imaging/pull/337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sanjanarampurkottur01 commented on code in PR #220:
URL: https://github.com/apache/commons-dbutils/pull/220#discussion_r1402115817
##
src/test/java/org/apache/commons/dbutils/MockResultSet.java:
##
@@ -265,64 +266,77 @@ protected String getString(final int columnIndex) throws
garydgregory commented on code in PR #220:
URL: https://github.com/apache/commons-dbutils/pull/220#discussion_r1402094200
##
src/test/java/org/apache/commons/dbutils/MockResultSet.java:
##
@@ -265,64 +266,77 @@ protected String getString(final int columnIndex) throws
gwlucastrig commented on PR #337:
URL: https://github.com/apache/commons-imaging/pull/337#issuecomment-1822815480
Thanks for the comments. Changes were made and a new commit pushed to Github
--
This is an automated message from the Apache Git Service.
To respond to the message, please
gwlucastrig commented on code in PR #337:
URL: https://github.com/apache/commons-imaging/pull/337#discussion_r1402084313
##
src/test/java/org/apache/commons/imaging/formats/tiff/TiffReadImageInfoTest.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation
sanjanarampurkottur01 commented on code in PR #220:
URL: https://github.com/apache/commons-dbutils/pull/220#discussion_r1402082036
##
src/test/java/org/apache/commons/dbutils/MockResultSet.java:
##
@@ -265,64 +266,86 @@ protected String getString(final int columnIndex) throws
sanjanarampurkottur01 commented on code in PR #220:
URL: https://github.com/apache/commons-dbutils/pull/220#discussion_r1402081588
##
src/test/java/org/apache/commons/dbutils/MockResultSet.java:
##
@@ -265,64 +266,86 @@ protected String getString(final int columnIndex) throws
[
https://issues.apache.org/jira/browse/IO-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788780#comment-17788780
]
Gary D. Gregory commented on IO-822:
Sounds like a duplicate of
garydgregory commented on code in PR #220:
URL: https://github.com/apache/commons-dbutils/pull/220#discussion_r1402070369
##
src/test/java/org/apache/commons/dbutils/MockResultSet.java:
##
@@ -265,64 +266,86 @@ protected String getString(final int columnIndex) throws
[
https://issues.apache.org/jira/browse/IO-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788779#comment-17788779
]
hellozrh commented on IO-822:
-
After passing the test, I will submit the code to Github
> I hope to add a file
sanjanarampurkottur01 commented on code in PR #220:
URL: https://github.com/apache/commons-dbutils/pull/220#discussion_r1402062601
##
src/test/java/org/apache/commons/dbutils/MockResultSet.java:
##
@@ -21,10 +21,7 @@
import java.sql.ResultSet;
import
hellozrh created IO-822:
---
Summary: I hope to add a file size tool class for converting units
such as TB, GB, MB, etc, such as java.util.concurrent.TimeUnit.java
Key: IO-822
URL:
garydgregory commented on PR #222:
URL: https://github.com/apache/commons-dbutils/pull/222#issuecomment-1822776365
Hi @sanjanarampurkottur01
Hm, ok, then you should not only address the one file, but all files:
```
[ERROR]
garydgregory commented on code in PR #220:
URL: https://github.com/apache/commons-dbutils/pull/220#discussion_r1402050005
##
src/test/java/org/apache/commons/dbutils/MockResultSet.java:
##
@@ -21,10 +21,7 @@
import java.sql.ResultSet;
import java.sql.ResultSetMetaData;
sanjanarampurkottur01 commented on code in PR #220:
URL: https://github.com/apache/commons-dbutils/pull/220#discussion_r1402049550
##
src/test/java/org/apache/commons/dbutils/MockResultSet.java:
##
@@ -21,10 +21,7 @@
import java.sql.ResultSet;
import
garydgregory commented on code in PR #220:
URL: https://github.com/apache/commons-dbutils/pull/220#discussion_r1402045445
##
src/test/java/org/apache/commons/dbutils/MockResultSet.java:
##
@@ -21,10 +21,7 @@
import java.sql.ResultSet;
import java.sql.ResultSetMetaData;
garydgregory commented on code in PR #220:
URL: https://github.com/apache/commons-dbutils/pull/220#discussion_r1402045445
##
src/test/java/org/apache/commons/dbutils/MockResultSet.java:
##
@@ -21,10 +21,7 @@
import java.sql.ResultSet;
import java.sql.ResultSetMetaData;
sanjanarampurkottur01 commented on PR #222:
URL: https://github.com/apache/commons-dbutils/pull/222#issuecomment-1822760135
> Hello @sanjanarampurkottur01 Why? This is test code and shows how client
classes could be laid out in the wild, with proper or improper adherence to
coding
[
https://issues.apache.org/jira/browse/JEXL-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788775#comment-17788775
]
Holger Sunke commented on JEXL-414:
---
Thank you for quick action. Looking at the source it looks very
garydgregory commented on code in PR #337:
URL: https://github.com/apache/commons-imaging/pull/337#discussion_r1402031806
##
src/test/java/org/apache/commons/imaging/formats/tiff/TiffReadImageInfoTest.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation
garydgregory commented on PR #222:
URL: https://github.com/apache/commons-dbutils/pull/222#issuecomment-1822722013
Hello @sanjanarampurkottur01
Why?
This is test code and shows how client classes could be laid out in the
wild, with proper or improper adherence to coding guidelines.
gwlucastrig commented on PR #337:
URL: https://github.com/apache/commons-imaging/pull/337#issuecomment-1822713296
Pushed a new commit that addresses the checkstyle issues. Apologies. I made
a minor code change after my last checkstyle:check and foolishly assumed that
nothing could go
sanjanarampurkottur01 commented on PR #220:
URL: https://github.com/apache/commons-dbutils/pull/220#issuecomment-1822600824
Hi Gary,
I have made the necessary changes to
https://github.com/apache/commons-dbutils/pull/220, I kindly request you to
review and approve the same.
sanjanarampurkottur01 commented on PR #220:
URL: https://github.com/apache/commons-dbutils/pull/220#issuecomment-1822576411
> @sanjanarampurkottur01 Please don't change the formatting style, it makes
PRs noisy and takes longer and is harder to review.
@garydgregory , I will fix that
sanjanarampurkottur01 commented on PR #220:
URL: https://github.com/apache/commons-dbutils/pull/220#issuecomment-1822571926
Hi Gary,
I am extremely sorry about that, I will change the formatting style and let
you know as soon as possible, once I push the changes.
Thank you.
garydgregory commented on PR #220:
URL: https://github.com/apache/commons-dbutils/pull/220#issuecomment-1822565139
@sanjanarampurkottur01
Please don't change the formatting style, it makes PRs noisy and takes
longer and is harder to review.
--
This is an automated message from the
[
https://issues.apache.org/jira/browse/CRYPTO-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788678#comment-17788678
]
Sebb commented on CRYPTO-164:
-
Looks like this is already being tested on ubuntu-latest.
> Add Support for
77 matches
Mail list logo
