garydgregory commented on code in PR #218:
URL: https://github.com/apache/commons-dbutils/pull/218#discussion_r1405300486
##
src/main/java/org/apache/commons/dbutils/wrappers/StringTrimmedResultSet.java:
##
@@ -92,12 +92,15 @@ public Object invoke(final Object proxy, final Metho
sanjanarampurkottur01 closed pull request #221: Refactoring deficient
encapsulation
URL: https://github.com/apache/commons-dbutils/pull/221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
sanjanarampurkottur01 commented on PR #221:
URL: https://github.com/apache/commons-dbutils/pull/221#issuecomment-1826439432
These changes are not taken into account, hence closing this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
garydgregory merged PR #183:
URL: https://github.com/apache/commons-logging/pull/183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
sanjanarampurkottur01 commented on code in PR #218:
URL: https://github.com/apache/commons-dbutils/pull/218#discussion_r1405217722
##
src/test/java/org/apache/commons/dbutils/BeanProcessorTest.java:
##
@@ -186,19 +187,21 @@ public void setTestField(final int idx, final Integer
sanjanarampurkottur01 commented on code in PR #218:
URL: https://github.com/apache/commons-dbutils/pull/218#discussion_r1405217642
##
src/test/java/org/apache/commons/dbutils/BeanProcessorTest.java:
##
@@ -186,19 +187,21 @@ public void setTestField(final int idx, final Integer
ppkarwasz opened a new pull request, #183:
URL: https://github.com/apache/commons-logging/pull/183
Commons Logging has a fallback simple logger that is used if the
`java.util.logging` package is not present.
Originally this only could happen with Java 1.3, but sinc Java 9 the user
ca
garydgregory commented on code in PR #218:
URL: https://github.com/apache/commons-dbutils/pull/218#discussion_r1405182753
##
src/test/java/org/apache/commons/dbutils/BeanProcessorTest.java:
##
@@ -186,19 +187,21 @@ public void setTestField(final int idx, final Integer
testField
garydgregory merged PR #474:
URL: https://github.com/apache/commons-text/pull/474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@com
garydgregory merged PR #476:
URL: https://github.com/apache/commons-text/pull/476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@com
sanjanarampurkottur01 commented on code in PR #218:
URL: https://github.com/apache/commons-dbutils/pull/218#discussion_r1405178953
##
src/test/java/org/apache/commons/dbutils/BeanProcessorTest.java:
##
@@ -213,93 +214,90 @@ public void testCheckAnnotationOnMissingReadMethod()
t
Scient122 closed pull request #477: Code smells fixing
URL: https://github.com/apache/commons-text/pull/477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
Scient122 opened a new pull request, #477:
URL: https://github.com/apache/commons-text/pull/477
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
ecki commented on code in PR #218:
URL: https://github.com/apache/commons-dbutils/pull/218#discussion_r1405177811
##
src/test/java/org/apache/commons/dbutils/BeanProcessorTest.java:
##
@@ -213,93 +214,90 @@ public void testCheckAnnotationOnMissingReadMethod()
throws Exception {
garydgregory commented on PR #178:
URL: https://github.com/apache/commons-logging/pull/178#issuecomment-1826379932
Right, we could do a 1.4.0 targeting Java 11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
ppkarwasz commented on PR #178:
URL: https://github.com/apache/commons-logging/pull/178#issuecomment-1826371905
It seems that Logback 1.3.x is the last one supporting Java 8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
garydgregory commented on PR #178:
URL: https://github.com/apache/commons-logging/pull/178#issuecomment-1826369383
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
sanjanarampurkottur01 commented on code in PR #218:
URL: https://github.com/apache/commons-dbutils/pull/218#discussion_r1405159111
##
src/test/java/org/apache/commons/dbutils/BeanProcessorTest.java:
##
@@ -213,93 +214,90 @@ public void testCheckAnnotationOnMissingReadMethod()
t
garydgregory merged PR #182:
URL: https://github.com/apache/commons-logging/pull/182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
[
https://issues.apache.org/jira/browse/LOGGING-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789679#comment-17789679
]
Piotr Karwasz commented on LOGGING-173:
---
[~elharo],
The class is still there, but
[
https://issues.apache.org/jira/browse/COMPRESS-652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789675#comment-17789675
]
Daniel Janus commented on COMPRESS-652:
---
I’ve created a PR with a test that cover
nathell opened a new pull request, #446:
URL: https://github.com/apache/commons-compress/pull/446
Description and rationale in a JIRA ticket:
https://issues.apache.org/jira/projects/COMPRESS/issues/COMPRESS-652.
In addition to adding a test, I’ve verified manually that this works both
garydgregory merged PR #518:
URL: https://github.com/apache/commons-io/pull/518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commo
elharo opened a new pull request, #518:
URL: https://github.com/apache/commons-io/pull/518
The problem in this test was asserting something that simply wasn't true and
wasn't expected to be true in many cases. Removing the offending assert allowed
some redundant tests to be removed.
sanjanarampurkottur01 commented on PR #218:
URL: https://github.com/apache/commons-dbutils/pull/218#issuecomment-1826313580
Hello Gary,
I am working on these code changes, based on your review.
Thank you.
Best Regards,
Sanjana Rampur Kottur
On Fri, 24 Nov 2023 a
[
https://issues.apache.org/jira/browse/IO-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789669#comment-17789669
]
Gary D. Gregory commented on IO-783:
This issue needs a pull request on GitHub so we can
[
https://issues.apache.org/jira/browse/IO-783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated IO-783:
---
Priority: Major (was: Blocker)
> Fetching file extension using FilenameUtils.getExtension method throws
[
https://issues.apache.org/jira/browse/LOGGING-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789668#comment-17789668
]
Gary D. Gregory commented on LOGGING-173:
-
The plan (or at least mine) is not br
[
https://issues.apache.org/jira/browse/LOGGING-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789665#comment-17789665
]
Elliotte Rusty Harold commented on LOGGING-173:
---
Just checked and AvalonLo
29 matches
Mail list logo
