[
https://issues.apache.org/jira/browse/IO-392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800233#comment-17800233
]
Elliotte Rusty Harold commented on IO-392:
--
IMHO this one should be closed. Commons IO is not the
elharo commented on PR #535:
URL: https://github.com/apache/commons-io/pull/535#issuecomment-1868610331
Thanks. I'll look at that. The one test failure on CI looks unrelated:
---
Error: Failed to execute goal
aherbert commented on PR #139:
URL: https://github.com/apache/commons-numbers/pull/139#issuecomment-1868575960
Added the benchmark to master. Run using:
```
cd commons-numbers-examples/examples-jmh
mvn package -Pexamples-jmh
java -jar target/examples-jmh.jar ArithmeticPerformance
aherbert commented on PR #139:
URL: https://github.com/apache/commons-numbers/pull/139#issuecomment-1868574821
Just browsed the JDK 17 source code for the long methods. These use a method
from Hacker's Delight (**2nd ed**).
So the Hacker's Delight (presumed **1st ed**) method in
aherbert commented on PR #139:
URL: https://github.com/apache/commons-numbers/pull/139#issuecomment-1868571519
Here are some benchmark results. JDK variants are prefixed with the class
that implements the method.
TLDR; the JDK is always faster for the int methods. It can be
aherbert commented on PR #139:
URL: https://github.com/apache/commons-numbers/pull/139#issuecomment-1868555695
I agree. ArithmeticUtils predates JDK 8. I imagine it was ported from Math
to Numbers without knowing that JDK 8 had equivalent methods. I'll do a
performance test, then we can
sebbASF commented on PR #139:
URL: https://github.com/apache/commons-numbers/pull/139#issuecomment-1868554318
If the reason we don't use the JDK methods is performance, this should be
explicitly noted in the source so future maintainers are aware.
--
This is an automated message from the
aherbert commented on PR #139:
URL: https://github.com/apache/commons-numbers/pull/139#issuecomment-1868552071
I would be wary of this simplification without a performance test.
In the Numbers class the int methods do not use long arithmetic. The long
methods do not use BigInteger.
garydgregory closed pull request #257: Bump org.apache.commons:commons-parent
from 64 to 65
URL: https://github.com/apache/commons-fileupload/pull/257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
garydgregory commented on PR #257:
URL:
https://github.com/apache/commons-fileupload/pull/257#issuecomment-1868547626
Closing: Already done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
garydgregory commented on PR #535:
URL: https://github.com/apache/commons-io/pull/535#issuecomment-1868546472
@elharo
Toward this type of effort, I refactored some tests a while back to extend
`AbstractTempDirTest`. Perhaps this class should do the same.
--
This is an
[
https://issues.apache.org/jira/browse/CODEC-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800194#comment-17800194
]
Gary D. Gregory commented on CODEC-316:
---
Hello [~technobcn]
Thank you for your request.
Feel free
sebbASF opened a new pull request, #139:
URL: https://github.com/apache/commons-numbers/pull/139
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
agoss94 commented on PR #225:
URL: https://github.com/apache/commons-geometry/pull/225#issuecomment-1868505809
Thanks @darkma773r I think I am mostly done with all remarks. There is one
other thing we should discuss. The original paper
Guillermo Grandes created CODEC-316:
---
Summary: Support for yescrypt
Key: CODEC-316
URL: https://issues.apache.org/jira/browse/CODEC-316
Project: Commons Codec
Issue Type: Wish
[
https://issues.apache.org/jira/browse/IO-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800172#comment-17800172
]
Elliotte Rusty Harold commented on IO-405:
--
I don't see any reason for the constructor to throw an
[
https://issues.apache.org/jira/browse/IO-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800170#comment-17800170
]
Elliotte Rusty Harold commented on IO-412:
--
I don't think IO-316 is the same. IO-316 is about
[
https://issues.apache.org/jira/browse/IO-413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb resolved IO-413.
-
Resolution: Won't Do
Agreed
> deleteQuietly(File) should try to closeOnDelete too
>
F0otman commented on PR #194:
URL:
https://github.com/apache/commons-beanutils/pull/194#issuecomment-1868459915
Apologize for the wrong operate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
F0otman closed pull request #194: Dev
URL: https://github.com/apache/commons-beanutils/pull/194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
F0otman opened a new pull request, #194:
URL: https://github.com/apache/commons-beanutils/pull/194
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
21 matches
Mail list logo
