Re: [PR] [EMAIL-203] Switch from javax.mail to jakarta.mail [commons-email]

2023-12-25 Thread via GitHub
garydgregory commented on PR #192: URL: https://github.com/apache/commons-email/pull/192#issuecomment-1869142737 Hello @brandonfl Since it does not even build, I would say not. Unless there are some details in it that are needed. The best approach would be to use git master, for your te

Re: [PR] [EMAIL-203] Switch from javax.mail to jakarta.mail [commons-email]

2023-12-25 Thread via GitHub
brandonfl commented on PR #192: URL: https://github.com/apache/commons-email/pull/192#issuecomment-1869139656 @garydgregory Since you have done it on master, did this PR is still needed ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Resolved] (EMAIL-203) Switch from javax.mail to jakarta.mail

2023-12-25 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/EMAIL-203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved EMAIL-203. --- Resolution: Fixed > Switch from javax.mail to jakarta.mail > -

[jira] [Commented] (EMAIL-203) Switch from javax.mail to jakarta.mail

2023-12-25 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/EMAIL-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800341#comment-17800341 ] Gary D. Gregory commented on EMAIL-203: --- See git master and 2.0.0-M1 SNAPSHOT builds

[jira] [Updated] (EMAIL-203) Switch from javax.mail to jakarta.mail

2023-12-25 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/EMAIL-203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated EMAIL-203: -- Affects Version/s: (was: 2.0) > Switch from javax.mail to jakarta.mail > ---

Re: [PR] [EMAIL-203] Switch from javax.mail to jakarta.mail [commons-email]

2023-12-25 Thread via GitHub
garydgregory commented on PR #192: URL: https://github.com/apache/commons-email/pull/192#issuecomment-1869069980 This PR does not build. Always run `mvn` locally before pushing to catch these errors. -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] [EMAIL-203] Switch from javax.mail to jakarta.mail [commons-email]

2023-12-25 Thread via GitHub
garydgregory commented on PR #192: URL: https://github.com/apache/commons-email/pull/192#issuecomment-1869069792 @brandonfl Please see git master and 2.0.0-M1-SNAPSHOT builds on https://repository.apache.org/content/repositories/snapshots/ -- This is an automated message from the Apac

[jira] [Commented] (IO-337) ByteOrderMark can be refactored as an enum

2023-12-25 Thread Niall Pemberton (Jira)
[ https://issues.apache.org/jira/browse/IO-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800316#comment-17800316 ] Niall Pemberton commented on IO-337: I will -1 this change if it is ever committed since

[jira] [Updated] (IO-337) ByteOrderMark can be refactored as an enum

2023-12-25 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated IO-337: --- Fix Version/s: 3.x > ByteOrderMark can be refactored as an enum > ---

[jira] [Commented] (IO-337) ByteOrderMark can be refactored as an enum

2023-12-25 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800314#comment-17800314 ] Gary D. Gregory commented on IO-337: We can reconsider for the next major version IMO. >

[jira] [Resolved] (IO-392) StringSourceStream

2023-12-25 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved IO-392. Resolution: Won't Do > StringSourceStream > -- > > Key: IO-392 >

[jira] [Commented] (IO-392) StringSourceStream

2023-12-25 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800313#comment-17800313 ] Gary D. Gregory commented on IO-392: This would be better suited for Xalan but seems like

[jira] [Commented] (IO-337) ByteOrderMark can be refactored as an enum

2023-12-25 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/IO-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800311#comment-17800311 ] Elliotte Rusty Harold commented on IO-337: -- IMHO this one is probably not worth the