[jira] [Created] (CRYPTO-181) CryptoRandom should use a security random

2024-01-23 Thread chaijunjie (Jira)
chaijunjie created CRYPTO-181: - Summary: CryptoRandom should use a security random Key: CRYPTO-181 URL: https://issues.apache.org/jira/browse/CRYPTO-181 Project: Commons Crypto Issue Type: Improv

Re: [PR] Avoid deprecation warnings and other minor cleanups in FileUtilsTest [commons-io]

2024-01-23 Thread via GitHub
garydgregory commented on PR #562: URL: https://github.com/apache/commons-io/pull/562#issuecomment-1907228216 Hi @elharo >None of the deprecation changes affect the tests. But they do since some of the changes are to `@Test` methods. I really don't want to fiddle with this

Re: [PR] Add test for copying a symlink FileUtilsTest#testCopyFile_symLink() [commons-io]

2024-01-23 Thread via GitHub
garydgregory merged PR #564: URL: https://github.com/apache/commons-io/pull/564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commo

[jira] [Commented] (IO-842) Deprecate FileUtils.writeLines without charsets

2024-01-23 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810120#comment-17810120 ] Gary D. Gregory commented on IO-842: Let's assume we have a family of JRE and Apache Comm

[PR] add test for copying a symlink [commons-io]

2024-01-23 Thread via GitHub
elharo opened a new pull request, #564: URL: https://github.com/apache/commons-io/pull/564 This adds a test for the current behavior at head. We might want to change this behavior, but if so this test will show us what we changed and that we changed it deliberately. @garydgregory @e

Re: [PR] [IO-842] deprecate writeLines methods without a charset [commons-io]

2024-01-23 Thread via GitHub
garydgregory commented on PR #563: URL: https://github.com/apache/commons-io/pull/563#issuecomment-1905956687 https://issues.apache.org/jira/browse/IO-842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[jira] [Commented] (IO-842) Deprecate FileUtils.writeLines without charsets

2024-01-23 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/IO-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809929#comment-17809929 ] Elliotte Rusty Harold commented on IO-842: -- No, there are several problems with that

[PR] [IO-842] deprecate writeLines methods without a charset [commons-io]

2024-01-23 Thread via GitHub
elharo opened a new pull request, #563: URL: https://github.com/apache/commons-io/pull/563 Also corrects Javadoc about which exception is thrown when the charset is not recognized and adds test for same. Note that the exception thrown is not changed here. I brought the documentation into sy

Re: [PR] DBCP-592: Support request boundaries [commons-dbcp]

2024-01-23 Thread via GitHub
ecki commented on PR #324: URL: https://github.com/apache/commons-dbcp/pull/324#issuecomment-1905921957 Yes its early, maybe wait for concrete requests with a desireable driver behavior. Having said that, calling endRequest to reset the vendor specific connection attributes seems lik

Re: [PR] DBCP-592: Support request boundaries [commons-dbcp]

2024-01-23 Thread via GitHub
garydgregory commented on PR #324: URL: https://github.com/apache/commons-dbcp/pull/324#issuecomment-1905917557 Oh, also when we do decide to use the APIs we should NOT use reflection. We can either bump the platform requirement or create a new Maven module with that requirement in a subcla

[jira] [Commented] (IO-842) Deprecate FileUtils.writeLines without charsets

2024-01-23 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809923#comment-17809923 ] Gary D. Gregory commented on IO-842: Now that we have [https://openjdk.org/jeps/400] we s

Re: [PR] DBCP-592: Support request boundaries [commons-dbcp]

2024-01-23 Thread via GitHub
garydgregory commented on PR #324: URL: https://github.com/apache/commons-dbcp/pull/324#issuecomment-1905897538 All of this hints to me that it is too early for us to integrate these calls into DBCP. Once more FOSS drivers implement these APIs in a meaningful manner will be able to create t

Re: [PR] DBCP-592: Support request boundaries [commons-dbcp]

2024-01-23 Thread via GitHub
ecki commented on PR #324: URL: https://github.com/apache/commons-dbcp/pull/324#issuecomment-1905880476 I was curious on those begin/end but could not find much of documentation. So I snooped a bit around in the source code of some drivers. Besides the resetting of the client side state (th

[jira] [Created] (IO-842) Deprecate FileUtils.writeLines without charsets

2024-01-23 Thread Elliotte Rusty Harold (Jira)
Elliotte Rusty Harold created IO-842: Summary: Deprecate FileUtils.writeLines without charsets Key: IO-842 URL: https://issues.apache.org/jira/browse/IO-842 Project: Commons IO Issue Type

Re: [PR] avoid deprecation warnings and other minor cleanups in FileUtilsTest [commons-io]

2024-01-23 Thread via GitHub
elharo commented on PR #562: URL: https://github.com/apache/commons-io/pull/562#issuecomment-1905863543 As far as code coverage I see [2024-01-23T00:44:13.800Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: The

Re: [PR] avoid deprecation warnings and other minor cleanups in FileUtilsTest [commons-io]

2024-01-23 Thread via GitHub
elharo commented on PR #562: URL: https://github.com/apache/commons-io/pull/562#issuecomment-1905861743 There's one failure on Java 21 only. This test wasn't touched in this PR. It's probably just flaky, but it's also possible it's broekn at HEAD: Error: Tests run: 3, Failures: 1, E

Re: [PR] avoid deprecated warnings and other minor cleanups in FileUtilsTest [commons-io]

2024-01-23 Thread via GitHub
elharo commented on PR #562: URL: https://github.com/apache/commons-io/pull/562#issuecomment-1905857003 None of the deprecation changes affect the tests. They are changes to the setup code for the tests. -- This is an automated message from the Apache Git Service. To respond to the messa

[jira] (JEXL-398) Allow 'trailing commas' or ellipsis while defining array, map and set literals

2024-01-23 Thread Henri Biestro (Jira)
[ https://issues.apache.org/jira/browse/JEXL-398 ] Henri Biestro deleted comment on JEXL-398: was (Author: garydgregory): The build is red. > Allow 'trailing commas' or ellipsis while defining array, map and set literals > -

[jira] [Commented] (JEXL-398) Allow 'trailing commas' or ellipsis while defining array, map and set literals

2024-01-23 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/JEXL-398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809877#comment-17809877 ] Gary D. Gregory commented on JEXL-398: -- The build is red. > Allow 'trailing commas' o

[jira] [Resolved] (JEXL-398) Allow 'trailing commas' or ellipsis while defining array, map and set literals

2024-01-23 Thread Henri Biestro (Jira)
[ https://issues.apache.org/jira/browse/JEXL-398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Biestro resolved JEXL-398. Resolution: Fixed Commit [ca55aa8e|https://github.com/apache/commons-jexl/commit/ca55aa8e9ad4265e4a7

[jira] [Reopened] (JEXL-398) Allow 'trailing commas' or ellipsis while defining array, map and set literals

2024-01-23 Thread Henri Biestro (Jira)
[ https://issues.apache.org/jira/browse/JEXL-398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Biestro reopened JEXL-398: * Dot-expressions are no longer accepted as map keys; * [,...] is no longer accepted; * array/set/map b