[jira] [Commented] (CLI-285) Multiple Options in Option Group

2024-03-07 Thread Claude Warren (Jira)
[ https://issues.apache.org/jira/browse/CLI-285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824636#comment-17824636 ] Claude Warren commented on CLI-285: --- Upon further reflection I think that to complete the set of check of

Re: [PR] Temporary file encryption support. [commons-fileupload]

2024-03-07 Thread via GitHub
garydgregory commented on PR #285: URL: https://github.com/apache/commons-fileupload/pull/285#issuecomment-1984113499 Hm, this branch does not run build checks, I'll see about fixing that soon. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Hotfix/commons fileupload 1.5.x [commons-fileupload]

2024-03-07 Thread via GitHub
halcsi19790320 closed pull request #284: Hotfix/commons fileupload 1.5.x URL: https://github.com/apache/commons-fileupload/pull/284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Hotfix/commons fileupload 1.5.x [commons-fileupload]

2024-03-07 Thread via GitHub
halcsi19790320 commented on PR #284: URL: https://github.com/apache/commons-fileupload/pull/284#issuecomment-1984018158 I merged it to 1.x branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] Temporary file encryption support. [commons-fileupload]

2024-03-07 Thread via GitHub
halcsi19790320 opened a new pull request, #285: URL: https://github.com/apache/commons-fileupload/pull/285 This pull request based on commons-fileupload 1.5 and support an security requirement the encrypted temporary files. Ciphers you could inject by java SPI. I have to use it

Re: [PR] Hotfix/commons fileupload 1.5.x [commons-fileupload]

2024-03-07 Thread via GitHub
garydgregory commented on PR #284: URL: https://github.com/apache/commons-fileupload/pull/284#issuecomment-1983782038 Then the PR needs to be based on the 1.x branch, not git master which it for 2.x. Gary On Thu, Mar 7, 2024, 9:40 AM halcsi19790320 ***@***.***> wrote:

Re: [PR] Hotfix/commons fileupload 1.5.x [commons-fileupload]

2024-03-07 Thread via GitHub
halcsi19790320 commented on PR #284: URL: https://github.com/apache/commons-fileupload/pull/284#issuecomment-1983647348 Hi! Yes I would like patch the 1.5 version. If it is not possible, then i would merge it. Thanks the rapid answers. H. Gary Gregory ***@***.***>

Re: [PR] Hotfix/commons fileupload 1.5.x [commons-fileupload]

2024-03-07 Thread via GitHub
garydgregory commented on PR #284: URL: https://github.com/apache/commons-fileupload/pull/284#issuecomment-1983570017 The conflicts are because the PR was created against git master. My guess is that the author wants to patch the 1.x branch. -- This is an automated message from the

Re: [PR] Hotfix/commons fileupload 1.5.x [commons-fileupload]

2024-03-07 Thread via GitHub
jochenw commented on PR #284: URL: https://github.com/apache/commons-fileupload/pull/284#issuecomment-1983540656 Hi, without having had a look at this: 1. Please fix the conflicts. 2. 32 changed files are **way** too much. Please try to split this up into two, or more

[PR] Hotfix/commons fileupload 1.5.x [commons-fileupload]

2024-03-07 Thread via GitHub
halcsi19790320 opened a new pull request, #284: URL: https://github.com/apache/commons-fileupload/pull/284 This pull request based on commons-fileupload 1.5 and support an security requirement the encrypted temporary files. Ciphers you could inject by java SPI. I have to use it

[jira] [Commented] (CLI-285) Multiple Options in Option Group

2024-03-07 Thread Claude Warren (Jira)
[ https://issues.apache.org/jira/browse/CLI-285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824298#comment-17824298 ] Claude Warren commented on CLI-285: --- First, let's introduce the Interface OptionCollection – Simply a