Re: [PR] CONFIGURATION-836: Migrate to jakarta [commons-configuration]

2024-03-18 Thread via GitHub
MichielDx commented on PR #386: URL: https://github.com/apache/commons-configuration/pull/386#issuecomment-2005893034 @garydgregory I changed it to configuration3, but now I get following error: `[ERROR] Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.18.5:cmp (de

Re: [PR] Guard MapConfiguration against null maps [commons-configuration]

2024-03-18 Thread via GitHub
pingpingy1 commented on PR #381: URL: https://github.com/apache/commons-configuration/pull/381#issuecomment-2005194768 @garydgregory Done! PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Commented] (CONFIGURATION-839) Version 2.10.0 fails java.lang.module.FindException: Module servlet.api not found

2024-03-18 Thread Bob Marinier (Jira)
[ https://issues.apache.org/jira/browse/CONFIGURATION-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828039#comment-17828039 ] Bob Marinier commented on CONFIGURATION-839: I tested RC1 and it works

Re: [PR] Bump com.puppycrawl.tools:checkstyle from 9.3 to 10.14.2 [commons-parent]

2024-03-18 Thread via GitHub
garydgregory commented on PR #383: URL: https://github.com/apache/commons-parent/pull/383#issuecomment-2004192415 Closing: Done through a profile. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Bump com.puppycrawl.tools:checkstyle from 9.3 to 10.14.2 [commons-parent]

2024-03-18 Thread via GitHub
garydgregory closed pull request #383: Bump com.puppycrawl.tools:checkstyle from 9.3 to 10.14.2 URL: https://github.com/apache/commons-parent/pull/383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (LOGGING-190) ServiceLoader with OSGi improvements (so commons can be used in an OSGi environment)

2024-03-18 Thread Johan Compagner (Jira)
[ https://issues.apache.org/jira/browse/LOGGING-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828017#comment-17828017 ] Johan Compagner commented on LOGGING-190: - i would be fine doing that but i am n

[jira] [Commented] (LOGGING-190) ServiceLoader with OSGi improvements (so commons can be used in an OSGi environment)

2024-03-18 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/LOGGING-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828004#comment-17828004 ] Gary D. Gregory commented on LOGGING-190: - Hello [~jcompan...@gmail.com] Feel f

Re: [PR] Guard MapConfiguration against null maps [commons-configuration]

2024-03-18 Thread via GitHub
garydgregory commented on PR #381: URL: https://github.com/apache/commons-configuration/pull/381#issuecomment-2004089691 @pingpingy1 Would you please rebase on master? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[jira] [Created] (LOGGING-190) ServiceLoader with OSGi improvements (so commons can be used in an OSGi environment)

2024-03-18 Thread Johan Compagner (Jira)
Johan Compagner created LOGGING-190: --- Summary: ServiceLoader with OSGi improvements (so commons can be used in an OSGi environment) Key: LOGGING-190 URL: https://issues.apache.org/jira/browse/LOGGING-190

Re: [PR] CONFIGURATION-836: Migrate to jakarta [commons-configuration]

2024-03-18 Thread via GitHub
garydgregory commented on PR #386: URL: https://github.com/apache/commons-configuration/pull/386#issuecomment-2003932309 Then you've broken binary compatibility as the error message says. Please see https://garygregory.wordpress.com/2020/06/14/how-we-handle-binary-compatibility-at-a

[jira] [Commented] (CONFIGURATION-839) Version 2.10.0 fails java.lang.module.FindException: Module servlet.api not found

2024-03-18 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/CONFIGURATION-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827970#comment-17827970 ] Gary D. Gregory commented on CONFIGURATION-839: --- [~bob.marinier] If

[jira] [Commented] (CONFIGURATION-839) Version 2.10.0 fails java.lang.module.FindException: Module servlet.api not found

2024-03-18 Thread Bob Marinier (Jira)
[ https://issues.apache.org/jira/browse/CONFIGURATION-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827960#comment-17827960 ] Bob Marinier commented on CONFIGURATION-839: Sounds good. For my own p

[PR] CONFIGURATION-836: Migrate to jakarta [commons-configuration]

2024-03-18 Thread via GitHub
MichielDx opened a new pull request, #386: URL: https://github.com/apache/commons-configuration/pull/386 @garydgregory I get following error while clean installing, but I'm not familiar with japicmp: `[ERROR] Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.18.5:cm