garydgregory commented on PR #290:
URL: https://github.com/apache/commons-bcel/pull/290#issuecomment-2008589150
@PabloNicolasDiaz
The PR still causes the build to fail.
Also, note that the code coverage is insufficient as reported by Codecov:
```
Attention: Patch coverage is
PabloNicolasDiaz commented on code in PR #290:
URL: https://github.com/apache/commons-bcel/pull/290#discussion_r1531181712
##
src/test/java/org/apache/bcel/CounterVisitorTestCase.java:
##
@@ -217,4 +217,8 @@ public void testSyntheticCount() {
public void testUnknownCount()
PabloNicolasDiaz commented on PR #290:
URL: https://github.com/apache/commons-bcel/pull/290#issuecomment-2008184067
Hello @garydgregory, let me figure out if i can solve all the errors and if
RecordComponentInfo needs to be acceder to users. RecordComponentInfo should be
mapped to every
garydgregory commented on PR #290:
URL: https://github.com/apache/commons-bcel/pull/290#issuecomment-2008175461
@PabloNicolasDiaz
The build is broken with:
```
Error: Failed to execute goal
com.github.siom79.japicmp:japicmp-maven-plugin:0.18.5:cmp (default-cli) on
project bcel:
garydgregory commented on code in PR #290:
URL: https://github.com/apache/commons-bcel/pull/290#discussion_r1531140604
##
src/main/java/org/apache/bcel/classfile/Record.java:
##
@@ -0,0 +1,152 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
garydgregory commented on PR #290:
URL: https://github.com/apache/commons-bcel/pull/290#issuecomment-2008164954
@PabloNicolasDiaz
Thank you for your PR.
I fixed a whole set of whitespace issues.
1. Please rebase on Git master to pick up a new version of our Checkstyle
PabloNicolasDiaz opened a new pull request, #290:
URL: https://github.com/apache/commons-bcel/pull/290
This PR adds support for java 14 record feature
(https://openjdk.org/jeps/359). Users now can use `JavaClass.isRecord()` to
detect a record class.
--
This is an automated message from
[
https://issues.apache.org/jira/browse/COMPRESS-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828473#comment-17828473
]
Basil Crow commented on COMPRESS-669:
-
bq. Brotli support that currently depend on another jar
garydgregory merged PR #385:
URL: https://github.com/apache/commons-parent/pull/385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
garydgregory merged PR #384:
URL: https://github.com/apache/commons-parent/pull/384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
pingpingy1 opened a new pull request, #289:
URL: https://github.com/apache/commons-bcel/pull/289
In the current implementation of the `createInvoke` method, an NPE is thrown
if the `argTypes` array is `null`. This commit adds a null guard that skips the
for loop if this is the case.
MichielDx commented on PR #386:
URL:
https://github.com/apache/commons-configuration/pull/386#issuecomment-2006047529
@garydgregory Reverted the rename, but still getting the same error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
garydgregory commented on PR #386:
URL:
https://github.com/apache/commons-configuration/pull/386#issuecomment-2006026171
@MichielDx
A (broken) PR with 510 changed files is not something reviewable or
reasonable. Changing package names for a major version change is a task best
left for
MichielDx commented on PR #386:
URL:
https://github.com/apache/commons-configuration/pull/386#issuecomment-2005893034
@garydgregory I changed it to configuration3, but now I get following error:
`[ERROR] Failed to execute goal
com.github.siom79.japicmp:japicmp-maven-plugin:0.18.5:cmp
14 matches
Mail list logo
