[
https://issues.apache.org/jira/browse/COMPRESS-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830676#comment-17830676
]
Gary D. Gregory commented on COMPRESS-675:
--
Hello [~tallison]
Do you have a
sebbASF commented on PR #1191:
URL: https://github.com/apache/commons-lang/pull/1191#issuecomment-2018458307
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
sebbASF merged PR #1191:
URL: https://github.com/apache/commons-lang/pull/1191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@common
[
https://issues.apache.org/jira/browse/COMPRESS-675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated COMPRESS-675:
-
Assignee: Gary D. Gregory
> Regression in pack200's Archive class -- underlying InputSt
[
https://issues.apache.org/jira/browse/COMPRESS-675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tim Allison updated COMPRESS-675:
-
Affects Version/s: 1.26.1
1.26.0
> Regression in pack200's Archive class
vgadget opened a new pull request, #1191:
URL: https://github.com/apache/commons-lang/pull/1191
Typo fixed. The javadoc was written:
`NumberUtils.toFloat(null, 1.1f) = 1.0f`
That is not correct, it should be:
`NumberUtils.toFloat(null, 1.1f) = 1.1f`
--
This is an automated
[
https://issues.apache.org/jira/browse/COMPRESS-675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tim Allison updated COMPRESS-675:
-
Summary: Regression in pack200's Archive class -- underlying InputStream is
now closed (was:
Tim Allison created COMPRESS-675:
Summary: Regression in
Key: COMPRESS-675
URL: https://issues.apache.org/jira/browse/COMPRESS-675
Project: Commons Compress
Issue Type: Bug
Repor
manzhizhen closed pull request #1190: Add StringUtils#equalsAll and
StringUtils#equalsAllIgnoreCase
URL: https://github.com/apache/commons-lang/pull/1190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
manzhizhen commented on PR #1190:
URL: https://github.com/apache/commons-lang/pull/1190#issuecomment-2018359320
> The example is clear, but seems quite contrived to me.
>
> Sorry, but I still don't see this being useful as a general purpose
StringUtils method that would earn its keep
sebbASF commented on PR #1190:
URL: https://github.com/apache/commons-lang/pull/1190#issuecomment-2018301050
The example is clear, but seems quite contrived to me.
Sorry, but I still don't see this being useful as a general purpose
StringUtils method that would earn its keep in the li
StefanOltmann commented on PR #366:
URL: https://github.com/apache/commons-imaging/pull/366#issuecomment-2018172410
@garydgregory Let me quote myself from
https://github.com/apache/commons-imaging/pull/367#issuecomment-1967723718:
> I think by now I did everything that I can do to con
StefanOltmann commented on PR #359:
URL: https://github.com/apache/commons-imaging/pull/359#issuecomment-2018150339
> Still no unit test. I'm not sure how we can avoid a future regression
without one. 😞
Wrong. There is a unit test in #366.
--
This is an automated message from the A
StefanOltmann commented on PR #366:
URL: https://github.com/apache/commons-imaging/pull/366#issuecomment-2018145082
@garydgregory I won't do the changes you requested.
I'm waiting on a review from @kinow.
--
This is an automated message from the Apache Git Service.
To respond to the
StefanOltmann commented on code in PR #366:
URL: https://github.com/apache/commons-imaging/pull/366#discussion_r1537692100
##
src/main/java/org/apache/commons/imaging/formats/tiff/write/TiffOutputField.java:
##
@@ -66,6 +66,10 @@ public boolean bytesEqual(final byte[] data) {
StefanOltmann commented on code in PR #366:
URL: https://github.com/apache/commons-imaging/pull/366#discussion_r1537689873
##
src/test/java/org/apache/commons/imaging/formats/jpeg/exif/ExifRewriterRoundtripTest.java:
##
@@ -56,124 +62,160 @@ public static Stream data() throws Ex
StefanOltmann commented on code in PR #366:
URL: https://github.com/apache/commons-imaging/pull/366#discussion_r1537688118
##
src/test/java/org/apache/commons/imaging/formats/jpeg/exif/ExifRewriterRoundtripTest.java:
##
@@ -56,124 +62,160 @@ public static Stream data() throws Ex
[
https://issues.apache.org/jira/browse/LOGGING-174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory closed LOGGING-174.
---
Fix Version/s: 1.3.1
Resolution: Fixed
> Minor improvements
> --
>
>
[
https://issues.apache.org/jira/browse/LOGGING-180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved LOGGING-180.
-
Fix Version/s: 1.3.1
Resolution: Fixed
> Upgrade commons logging log4j dependency
[
https://issues.apache.org/jira/browse/LOGGING-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved LOGGING-167.
-
Fix Version/s: 1.3.1
Resolution: Fixed
> [Java-9][JPMS] automatic module cannot b
[
https://issues.apache.org/jira/browse/LOGGING-178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory closed LOGGING-178.
---
Fix Version/s: 1.3.1
Resolution: Fixed
> Use final variables
> ---
>
[
https://issues.apache.org/jira/browse/LOGGING-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830484#comment-17830484
]
Gary D. Gregory commented on LOGGING-182:
-
Please use me as a contact :)
> Inte
manzhizhen commented on PR #1190:
URL: https://github.com/apache/commons-lang/pull/1190#issuecomment-2017979440
> This whole class needs a rethink IMO, I am not a fan of growing it
further. Also: `Stream.of(array).distinct().count() == 1` or any other more
efficient variations using `limit(
elharo commented on PR #224:
URL: https://github.com/apache/commons-logging/pull/224#issuecomment-2017927991
That works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
garydgregory commented on PR #224:
URL: https://github.com/apache/commons-logging/pull/224#issuecomment-2017906547
Git master is on 1.3.14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/LOGGING-190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved LOGGING-190.
-
Fix Version/s: 1.3.2
Resolution: Fixed
> ServiceLoader with OSGi improvements (so
garydgregory merged PR #234:
URL: https://github.com/apache/commons-logging/pull/234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
jcompagner commented on PR #234:
URL: https://github.com/apache/commons-logging/pull/234#issuecomment-2017864978
yes that seems to be working fine, now the registration of log4j.jcl is
picked up
--
This is an automated message from the Apache Git Service.
To respond to the message, please
elharo commented on PR #224:
URL: https://github.com/apache/commons-logging/pull/224#issuecomment-2017805918
OK. 1.3.13 then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
garydgregory commented on PR #224:
URL: https://github.com/apache/commons-logging/pull/224#issuecomment-2017803659
1.4 requires Java 11, so it's a no-go for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
garydgregory commented on PR #359:
URL: https://github.com/apache/commons-imaging/pull/359#issuecomment-2017802039
Still no unit test. I'm not sure how we can avoid a future regression
without one. 😞
--
This is an automated message from the Apache Git Service.
To respond to the message,
garydgregory commented on code in PR #366:
URL: https://github.com/apache/commons-imaging/pull/366#discussion_r1537442107
##
src/test/java/org/apache/commons/imaging/formats/jpeg/exif/ExifRewriterRoundtripTest.java:
##
@@ -56,124 +62,160 @@ public static Stream data() throws Exc
garydgregory commented on PR #234:
URL: https://github.com/apache/commons-logging/pull/234#issuecomment-2017784914
Ping @jcompagner 😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
garydgregory commented on PR #1190:
URL: https://github.com/apache/commons-lang/pull/1190#issuecomment-2017778909
This whole class needs a rethink IMO, I am not a fan of growing it further.
Also: `Stream.of(array).distinct().count() == 1` or any other more efficient
variations using `limi
manzhizhen commented on PR #1190:
URL: https://github.com/apache/commons-lang/pull/1190#issuecomment-2017683383
> No, I am asking: when would this be useful?
>
> Is there some real-world situation where this method would be useful?
For example, I have a string constant to indica
sebbASF commented on PR #1190:
URL: https://github.com/apache/commons-lang/pull/1190#issuecomment-2017651742
No, I am asking: when would this be useful?
Is there some real-world situation where this method would be useful?
--
This is an automated message from the Apache Git Serv
manzhizhen commented on PR #1190:
URL: https://github.com/apache/commons-lang/pull/1190#issuecomment-2017622323
> I'm sorry, but I don't see what this would be used for? No point adding
code that won't be used.
Are you saying there are no additional unit tests? Let me add
--
This i
sebbASF commented on code in PR #848:
URL: https://github.com/apache/commons-lang/pull/848#discussion_r1537325516
##
src/main/java/org/apache/commons/lang3/StringUtils.java:
##
@@ -8129,11 +8129,52 @@ private static boolean startsWith(final CharSequence
str, final CharSequence
sebbASF commented on PR #1190:
URL: https://github.com/apache/commons-lang/pull/1190#issuecomment-2017602066
I'm sorry, but I don't see what this would be used for?
No point adding code that won't be used.
--
This is an automated message from the Apache Git Service.
To respond to the me
manzhizhen opened a new pull request, #1190:
URL: https://github.com/apache/commons-lang/pull/1190
Similar to the StringUtils#equalsAny and StringUtils#equalsAnyIgnoreCase
methods, the equalsAll and equalsAllIgnoreCase methods have been added
--
This is an automated message from the Apach
40 matches
Mail list logo
