Re: [PR] Bump commons-io:commons-io from 2.15.1 to 2.16.0 [commons-email]

2024-03-28 Thread via GitHub
garydgregory merged PR #231: URL: https://github.com/apache/commons-email/pull/231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@co

Re: [PR] CONFIGURATION-843: Methods should not be empty [commons-configuration]

2024-03-28 Thread via GitHub
TYzzt commented on PR #393: URL: https://github.com/apache/commons-configuration/pull/393#issuecomment-2026452760 @garydgregory Thanks for the recovery.I've made the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] Bump github/codeql-action from 3.24.8 to 3.24.9 [commons-io]

2024-03-28 Thread via GitHub
garydgregory merged PR #606: URL: https://github.com/apache/commons-io/pull/606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commo

Re: [PR] Bump codecov/codecov-action from 4.1.0 to 4.1.1 [commons-io]

2024-03-28 Thread via GitHub
garydgregory merged PR #607: URL: https://github.com/apache/commons-io/pull/607 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commo

Re: [PR] Bump codecov/codecov-action from 4.1.0 to 4.1.1 [commons-scxml]

2024-03-28 Thread via GitHub
garydgregory merged PR #208: URL: https://github.com/apache/commons-scxml/pull/208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@co

Re: [PR] Bump github/codeql-action from 3.24.8 to 3.24.9 [commons-scxml]

2024-03-28 Thread via GitHub
garydgregory merged PR #209: URL: https://github.com/apache/commons-scxml/pull/209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@co

Re: [PR] Bump commons-io:commons-io from 2.15.1 to 2.16.0 [commons-email]

2024-03-28 Thread via GitHub
garydgregory commented on PR #231: URL: https://github.com/apache/commons-email/pull/231#issuecomment-2026277199 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Bump commons-io:commons-io from 2.15.1 to 2.16.0 [commons-bcel]

2024-03-28 Thread via GitHub
garydgregory merged PR #295: URL: https://github.com/apache/commons-bcel/pull/295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@com

Re: [PR] Bump commons-io:commons-io from 2.15.1 to 2.16.0 [commons-imaging]

2024-03-28 Thread via GitHub
garydgregory merged PR #380: URL: https://github.com/apache/commons-imaging/pull/380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] Bump commons-io:commons-io from 2.15.1 to 2.16.0 [commons-crypto]

2024-03-28 Thread via GitHub
garydgregory merged PR #321: URL: https://github.com/apache/commons-crypto/pull/321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@c

Re: [PR] Bump commons-io:commons-io from 2.15.1 to 2.16.0 [commons-configuration]

2024-03-28 Thread via GitHub
garydgregory merged PR #394: URL: https://github.com/apache/commons-configuration/pull/394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

Re: [PR] Bump commons-io:commons-io from 2.15.1 to 2.16.0 [commons-collections]

2024-03-28 Thread via GitHub
garydgregory merged PR #469: URL: https://github.com/apache/commons-collections/pull/469 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] Bump commons-io:commons-io from 2.15.1 to 2.16.0 [commons-fileupload]

2024-03-28 Thread via GitHub
garydgregory merged PR #291: URL: https://github.com/apache/commons-fileupload/pull/291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

Re: [PR] Bump commons-io:commons-io from 2.15.1 to 2.16.0 [commons-csv]

2024-03-28 Thread via GitHub
garydgregory merged PR #408: URL: https://github.com/apache/commons-csv/pull/408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@comm

Re: [PR] Bump commons-io:commons-io from 2.15.1 to 2.16.0 [commons-codec]

2024-03-28 Thread via GitHub
garydgregory merged PR #258: URL: https://github.com/apache/commons-codec/pull/258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@co

[jira] [Updated] (IO-555) Add a FileSystem enum to provide legal file names

2024-03-28 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated IO-555: --- Fix Version/s: 2.16.1 (was: 2.16.0) > Add a FileSystem enum to provide legal file

[jira] [Updated] (IO-840) Review ChecksumInputStream

2024-03-28 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory updated IO-840: --- Fix Version/s: 2.16.1 (was: 2.16.0) > Review ChecksumInputStream > ---

Re: [PR] [CLI-329] Support "Deprecated" CLI Options [commons-cli]

2024-03-28 Thread via GitHub
garydgregory commented on PR #252: URL: https://github.com/apache/commons-cli/pull/252#issuecomment-2026004644 Hi @epugh Are we all set? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] [TEXT-175] Fix regression for determining whitespace in WordUtils [commons-text]

2024-03-28 Thread via GitHub
garydgregory commented on PR #519: URL: https://github.com/apache/commons-text/pull/519#issuecomment-2025892605 @kinow @sebbASF @chtompki Do you have any thoughts on this method treating whitespace a certain way vs. what the rest of the class does, for example, `abbreviate()`? -- This

Re: [PR] [TEXT-175] Fix regression for determining whitespace in WordUtils [commons-text]

2024-03-28 Thread via GitHub
garydgregory commented on PR #519: URL: https://github.com/apache/commons-text/pull/519#issuecomment-2025855047 @seanfabs Thank you for your PR. In the future, use method references like `x::foo` instead of code like `c -> x.foo(c)`. Note that using `(c) -> ...` instead of `c -> ...`

[jira] [Comment Edited] (TEXT-175) WordUtils.capitalizeFully(String) only splits by spaces, instead of any whitespace

2024-03-28 Thread Sean Fabri (Jira)
[ https://issues.apache.org/jira/browse/TEXT-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831883#comment-17831883 ] Sean Fabri edited comment on TEXT-175 at 3/28/24 4:21 PM: -- I have

[jira] [Comment Edited] (TEXT-175) WordUtils.capitalizeFully(String) only splits by spaces, instead of any whitespace

2024-03-28 Thread Sean Fabri (Jira)
[ https://issues.apache.org/jira/browse/TEXT-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831883#comment-17831883 ] Sean Fabri edited comment on TEXT-175 at 3/28/24 4:20 PM: -- I have

[jira] [Commented] (TEXT-175) WordUtils.capitalizeFully(String) only splits by spaces, instead of any whitespace

2024-03-28 Thread Sean Fabri (Jira)
[ https://issues.apache.org/jira/browse/TEXT-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831883#comment-17831883 ] Sean Fabri commented on TEXT-175: - I have picked up the baton with this one - see a new PR

[PR] Fix regression for determining whitespace in WordUtils [commons-text]

2024-03-28 Thread via GitHub
seanfabs opened a new pull request, #519: URL: https://github.com/apache/commons-text/pull/519 Fixes a regression so that the `Character.isWhitespace(char)` is used instead of just the space character for the `capitalize()` and `uncapitalize()` methods in WordUtils. Note - I'm awaiti

[jira] [Resolved] (COLLECTIONS-849) Compilation with Java 21 fails with "error: addFirst(E#1) in AbstractLinkedList cannot implement addFirst(E#2) in List"

2024-03-28 Thread Alex Herbert (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Herbert resolved COLLECTIONS-849. -- Resolution: Duplicate > Compilation with Java 21 fails with "error: addFirst(E#1)

[jira] [Comment Edited] (CONFIGURATION-842) Constructors of an "abstract" class should not be declared "public"

2024-03-28 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/CONFIGURATION-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831782#comment-17831782 ] Gary D. Gregory edited comment on CONFIGURATION-842 at 3/28/24 1:12 PM:

[jira] [Resolved] (CONFIGURATION-842) Constructors of an "abstract" class should not be declared "public"

2024-03-28 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/CONFIGURATION-842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved CONFIGURATION-842. --- Resolution: Invalid -1 This PR breaks binary compatibility and it's an

Re: [PR] CONFIGURATION-842: Constructors of an "abstract" class should not be … [commons-configuration]

2024-03-28 Thread via GitHub
garydgregory commented on PR #392: URL: https://github.com/apache/commons-configuration/pull/392#issuecomment-2025149654 Next time, link back to the JIRA ticket you created. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] CONFIGURATION-842: Constructors of an "abstract" class should not be … [commons-configuration]

2024-03-28 Thread via GitHub
garydgregory commented on PR #392: URL: https://github.com/apache/commons-configuration/pull/392#issuecomment-2025148734 -1 This PR breaks binary compatibility and it's an arbitrary changed not based on anything. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] CONFIGURATION-842: Constructors of an "abstract" class should not be … [commons-configuration]

2024-03-28 Thread via GitHub
garydgregory closed pull request #392: CONFIGURATION-842: Constructors of an "abstract" class should not be … URL: https://github.com/apache/commons-configuration/pull/392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] CONFIGURATION-843: Methods should not be empty [commons-configuration]

2024-03-28 Thread via GitHub
garydgregory commented on code in PR #393: URL: https://github.com/apache/commons-configuration/pull/393#discussion_r1542934427 ## src/main/java/org/apache/commons/configuration2/AbstractConfiguration.java: ## @@ -119,7 +119,7 @@ public abstract class AbstractConfiguration exte

Re: [PR] CONFIGURATION-843: Methods should not be empty [commons-configuration]

2024-03-28 Thread via GitHub
garydgregory commented on code in PR #393: URL: https://github.com/apache/commons-configuration/pull/393#discussion_r1542931437 ## src/main/java/org/apache/commons/configuration2/ConfigurationUtils.java: ## @@ -63,6 +63,7 @@ public final class ConfigurationUtils { @O

[jira] [Commented] (COLLECTIONS-849) Compilation with Java 21 fails with "error: addFirst(E#1) in AbstractLinkedList cannot implement addFirst(E#2) in List"

2024-03-28 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831777#comment-17831777 ] Julian Reschke commented on COLLECTIONS-849: Maybe close as "duplicate"

[jira] [Resolved] (CODEC-321) Test Case deficiencies in ColognePhoneticTest

2024-03-28 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/CODEC-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved CODEC-321. --- Resolution: Invalid -1 No improvement in code coverage, before and after remain at 96.40%. See

Re: [PR] [CODEC-321] test for ColognePhoneticTest [commons-codec]

2024-03-28 Thread via GitHub
garydgregory commented on PR #256: URL: https://github.com/apache/commons-codec/pull/256#issuecomment-2025126582 The PR description is empty, at the very least describe the intended improvement and link back to the JIRA ticket. -- This is an automated message from the Apache Git Service.

Re: [PR] [CODEC-322] add unit test for PureJavaCrc32CTest [commons-codec]

2024-03-28 Thread via GitHub
garydgregory commented on PR #257: URL: https://github.com/apache/commons-codec/pull/257#issuecomment-2025124903 Also, the PR description is empty. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [CODEC-321] test for ColognePhoneticTest [commons-codec]

2024-03-28 Thread via GitHub
garydgregory commented on PR #256: URL: https://github.com/apache/commons-codec/pull/256#issuecomment-2025124024 -1 No improvement in code coverage, before and after remain at 96.40%. See https://app.codecov.io/gh/apache/commons-codec/blob/master/src%2Fmain%2Fjava%2Forg%2Fapache%2Fcomm

Re: [PR] [CODEC-321] test for ColognePhoneticTest [commons-codec]

2024-03-28 Thread via GitHub
garydgregory closed pull request #256: [CODEC-321] test for ColognePhoneticTest URL: https://github.com/apache/commons-codec/pull/256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[jira] [Commented] (CODEC-322) The PureJavaCrc32C test case is missing

2024-03-28 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/CODEC-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831769#comment-17831769 ] Gary D. Gregory commented on CODEC-322: --- This issue has no description. -1 No impro

[jira] [Resolved] (CODEC-322) The PureJavaCrc32C test case is missing

2024-03-28 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/CODEC-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved CODEC-322. --- Resolution: Invalid > The PureJavaCrc32C test case is missing > --

Re: [PR] [CODEC-322] add unit test for PureJavaCrc32CTest [commons-codec]

2024-03-28 Thread via GitHub
garydgregory commented on PR #257: URL: https://github.com/apache/commons-codec/pull/257#issuecomment-2025113176 -1 No improvement in code coverage See https://app.codecov.io/gh/apache/commons-codec/blob/master/src%2Fmain%2Fjava%2Forg%2Fapache%2Fcommons%2Fcodec%2Fdigest%2FPureJavaCrc32

Re: [PR] [CODEC-322] add unit test for PureJavaCrc32CTest [commons-codec]

2024-03-28 Thread via GitHub
garydgregory closed pull request #257: [CODEC-322] add unit test for PureJavaCrc32CTest URL: https://github.com/apache/commons-codec/pull/257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[jira] [Comment Edited] (COLLECTIONS-842) AbstractLinkedList apparently incompatible with JDK 21's java.util.List

2024-03-28 Thread Julian Reschke (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762150#comment-17762150 ] Julian Reschke edited comment on COLLECTIONS-842 at 3/28/24 12:49 PM:

Re: [PR] Support for Java 16 Record feature [commons-bcel]

2024-03-28 Thread via GitHub
garydgregory commented on PR #290: URL: https://github.com/apache/commons-bcel/pull/290#issuecomment-2025100267 @markro49 Would you please review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (IO-850) DeletingPathVisitor always fails to delete a dir when symbolic link target is deleted before the link itself

2024-03-28 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831761#comment-17831761 ] Gary D. Gregory commented on IO-850: [~jcompan...@gmail.com]  Interesting case! Thank yo

[PR] BCEL-372: Optimized code AttributeHTML [commons-bcel]

2024-03-28 Thread via GitHub
TYzzt opened a new pull request, #294: URL: https://github.com/apache/commons-bcel/pull/294 1.Reduce duplicate code 2.Reduce loop calls -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Created] (BCEL-372) Optimized code AttributeHTML

2024-03-28 Thread zhao tao (Jira)
zhao tao created BCEL-372: - Summary: Optimized code AttributeHTML Key: BCEL-372 URL: https://issues.apache.org/jira/browse/BCEL-372 Project: Commons BCEL Issue Type: Improvement Reporter:

[PR] feat(CODEC-322): add unit test for PureJavaCrc32CTest [commons-codec]

2024-03-28 Thread via GitHub
jiangyq7 opened a new pull request, #257: URL: https://github.com/apache/commons-codec/pull/257 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Created] (CODEC-322) The PureJavaCrc32C test case is missing

2024-03-28 Thread zhao tao (Jira)
zhao tao created CODEC-322: -- Summary: The PureJavaCrc32C test case is missing Key: CODEC-322 URL: https://issues.apache.org/jira/browse/CODEC-322 Project: Commons Codec Issue Type: Improvement

[jira] [Created] (CONFIGURATION-843) Methods should not be empty

2024-03-28 Thread zhao tao (Jira)
zhao tao created CONFIGURATION-843: -- Summary: Methods should not be empty Key: CONFIGURATION-843 URL: https://issues.apache.org/jira/browse/CONFIGURATION-843 Project: Commons Configuration I

[jira] [Created] (CODEC-321) Test Case deficiencies in ColognePhoneticTest

2024-03-28 Thread zhao tao (Jira)
zhao tao created CODEC-321: -- Summary: Test Case deficiencies in ColognePhoneticTest Key: CODEC-321 URL: https://issues.apache.org/jira/browse/CODEC-321 Project: Commons Codec Issue Type: Improvemen

[PR] CONFIGURATION-842: Constructors of an "abstract" class should not be … [commons-configuration]

2024-03-28 Thread via GitHub
TYzzt opened a new pull request, #392: URL: https://github.com/apache/commons-configuration/pull/392 …declared "public" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[jira] [Created] (CONFIGURATION-842) Constructors of an "abstract" class should not be declared "public"

2024-03-28 Thread zhao tao (Jira)
zhao tao created CONFIGURATION-842: -- Summary: Constructors of an "abstract" class should not be declared "public" Key: CONFIGURATION-842 URL: https://issues.apache.org/jira/browse/CONFIGURATION-842 P

[jira] [Created] (IO-850) DeletingPathVisitor always fails to delete a dir when symbolic link target is deleted before the link itself

2024-03-28 Thread Johan Compagner (Jira)
Johan Compagner created IO-850: -- Summary: DeletingPathVisitor always fails to delete a dir when symbolic link target is deleted before the link itself Key: IO-850 URL: https://issues.apache.org/jira/browse/IO-850