patel-kshitij opened a new pull request, #237:
URL: https://github.com/apache/commons-math/pull/237
I have removed several code smell from the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
garydgregory commented on PR #392:
URL:
https://github.com/apache/commons-collections/pull/392#issuecomment-2028799373
@saurabh-rahate
- Thank you for your PR, see my notes for future contributions.
- This was done differently in git master.
- You are credited in `changes.xml`.
garydgregory closed pull request #392: Remove duplicate condition in
FixedOrderComparator equals()
URL: https://github.com/apache/commons-collections/pull/392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
garydgregory commented on PR #420:
URL:
https://github.com/apache/commons-collections/pull/420#issuecomment-2028796545
-1 A PR should be small and focused. This is too big to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
garydgregory closed pull request #420: COLLECTIONS-846 Miscellaneous minor bug
fixes and associated test refactoring
URL: https://github.com/apache/commons-collections/pull/420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
garydgregory commented on PR #428:
URL:
https://github.com/apache/commons-collections/pull/428#issuecomment-2028795913
Hello @anirudh711
You'll need to show something failing, like a new test, to justify this
change.
TY
--
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/COLLECTIONS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832595#comment-17832595
]
Gary D. Gregory commented on COLLECTIONS-850:
-
See comments in PR. Tests
[
https://issues.apache.org/jira/browse/COLLECTIONS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved COLLECTIONS-850.
-
Resolution: Fixed
> testMultiValuedMapIterator is non-deterministic
> --
garydgregory commented on PR #429:
URL:
https://github.com/apache/commons-collections/pull/429#issuecomment-2028793282
Done differently and more thoroughly in git master. You are credited in
`changes.xml`.
--
This is an automated message from the Apache Git Service.
To respond to the mes
garydgregory closed pull request #429: COLLECTIONS-850- Fix Flaky test
testMultiValuedMapIterator
URL: https://github.com/apache/commons-collections/pull/429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
garydgregory commented on PR #290:
URL: https://github.com/apache/commons-bcel/pull/290#issuecomment-2028731158
@PabloNicolasDiaz
The API `RecordComponentInfo#getConstantPool()` is neither used nor tested.
--
This is an automated message from the Apache Git Service.
To respond to t
garydgregory commented on code in PR #290:
URL: https://github.com/apache/commons-bcel/pull/290#discussion_r1545655543
##
src/main/java/org/apache/bcel/classfile/Visitor.java:
##
@@ -237,4 +249,15 @@ default void visitStackMapType(final StackMapType obj) {
void visitSynthet
garydgregory commented on code in PR #290:
URL: https://github.com/apache/commons-bcel/pull/290#discussion_r1545650255
##
src/main/java/org/apache/bcel/classfile/Visitor.java:
##
@@ -237,4 +249,15 @@ default void visitStackMapType(final StackMapType obj) {
void visitSynthet
dlavati closed pull request #127: TEXT-175: WordUtils.capitalizeFully should
use all whitespaces if del…
URL: https://github.com/apache/commons-text/pull/127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
dlavati commented on PR #127:
URL: https://github.com/apache/commons-text/pull/127#issuecomment-2028627079
Fixed in #519
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
15 matches
Mail list logo
