Re: [PR] Some ArrayUtils method descriptions are not accurate [commons-lang]

2024-04-01 Thread via GitHub
aherbert commented on PR #1065: URL: https://github.com/apache/commons-lang/pull/1065#issuecomment-2030710084 I would close it. The javadoc currently reflects what the code is doing. If you read the javadoc as is you should get the understanding that the method is _trying_ to protect you fr

Re: [PR] Make dependency on java.desktop optional [commons-lang]

2024-04-01 Thread via GitHub
garydgregory commented on PR #1182: URL: https://github.com/apache/commons-lang/pull/1182#issuecomment-2030606468 -1: This looks too hacky and brittle to me as we do not have ways to prevent future changes from depending on java.desktop or other modules which would make this moot. For 4.0,

Re: [PR] Some ArrayUtils method descriptions are not accurate [commons-lang]

2024-04-01 Thread via GitHub
garydgregory commented on PR #1065: URL: https://github.com/apache/commons-lang/pull/1065#issuecomment-2030599744 @aherbert Thoughts on closing this PR or merging it despite the shortcomings? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] EventListenerSupport - Allow firing events "quietly" [commons-lang]

2024-04-01 Thread via GitHub
garydgregory commented on PR #1156: URL: https://github.com/apache/commons-lang/pull/1156#issuecomment-2030596706 Closing: No more feedback as of #1167 in January. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] EventListenerSupport - Allow firing events "quietly" [commons-lang]

2024-04-01 Thread via GitHub
garydgregory closed pull request #1156: EventListenerSupport - Allow firing events "quietly" URL: https://github.com/apache/commons-lang/pull/1156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Improve handling of malformed `Validate` messages [commons-lang]

2024-04-01 Thread via GitHub
garydgregory closed pull request #1159: Improve handling of malformed `Validate` messages URL: https://github.com/apache/commons-lang/pull/1159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Improve handling of malformed `Validate` messages [commons-lang]

2024-04-01 Thread via GitHub
garydgregory commented on PR #1159: URL: https://github.com/apache/commons-lang/pull/1159#issuecomment-2030595077 Closing, as summarized by @elharo "If the format string is bad, it's a client error that should result in IllegalFormatException." -- This is an automated message from the

Re: [PR] fix InaccessibleObjectException on java-17 [commons-lang]

2024-04-01 Thread via GitHub
garydgregory commented on PR #1183: URL: https://github.com/apache/commons-lang/pull/1183#issuecomment-2030593310 Closing: No reply in 2 weeks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] fix InaccessibleObjectException on java-17 [commons-lang]

2024-04-01 Thread via GitHub
garydgregory closed pull request #1183: fix InaccessibleObjectException on java-17 URL: https://github.com/apache/commons-lang/pull/1183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Bump org.apache.commons:commons-parent from 67 to 69 [commons-lang]

2024-04-01 Thread via GitHub
garydgregory merged PR #1194: URL: https://github.com/apache/commons-lang/pull/1194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@c

Re: [PR] Bump org.apache.commons:commons-parent from 67 to 69 [commons-io]

2024-04-01 Thread via GitHub
garydgregory merged PR #608: URL: https://github.com/apache/commons-io/pull/608 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commo

Re: [PR] Bump org.apache.commons:commons-parent from 67 to 69 [commons-pool]

2024-04-01 Thread via GitHub
garydgregory merged PR #297: URL: https://github.com/apache/commons-pool/pull/297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@com

Re: [PR] Bump org.apache.commons:commons-parent from 67 to 69 [commons-dbutils]

2024-04-01 Thread via GitHub
garydgregory merged PR #256: URL: https://github.com/apache/commons-dbutils/pull/256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] Bump org.apache.commons:commons-parent from 67 to 69 [commons-exec]

2024-04-01 Thread via GitHub
garydgregory merged PR #174: URL: https://github.com/apache/commons-exec/pull/174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@com

Re: [PR] Bump org.apache.commons:commons-parent from 67 to 69 [commons-beanutils]

2024-04-01 Thread via GitHub
garydgregory merged PR #229: URL: https://github.com/apache/commons-beanutils/pull/229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

Re: [PR] Bump org.apache.commons:commons-parent from 67 to 69 [commons-text]

2024-04-01 Thread via GitHub
garydgregory merged PR #524: URL: https://github.com/apache/commons-text/pull/524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@com

Re: [PR] Bump org.apache.commons:commons-parent from 67 to 69 [commons-daemon]

2024-04-01 Thread via GitHub
garydgregory merged PR #155: URL: https://github.com/apache/commons-daemon/pull/155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@c

Re: [PR] Bump org.apache.commons:commons-parent from 67 to 69 [commons-dbcp]

2024-04-01 Thread via GitHub
garydgregory merged PR #371: URL: https://github.com/apache/commons-dbcp/pull/371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@com

Re: [PR] Bump org.apache.commons:commons-parent from 67 to 69 [commons-csv]

2024-04-01 Thread via GitHub
garydgregory merged PR #410: URL: https://github.com/apache/commons-csv/pull/410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@comm

Re: [PR] Bump org.apache.commons:commons-parent from 67 to 69 [commons-crypto]

2024-04-01 Thread via GitHub
garydgregory merged PR #323: URL: https://github.com/apache/commons-crypto/pull/323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@c

Re: [PR] Bump org.apache.commons:commons-parent from 67 to 69 [commons-configuration]

2024-04-01 Thread via GitHub
garydgregory merged PR #396: URL: https://github.com/apache/commons-configuration/pull/396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

Re: [PR] Bump org.apache.commons:commons-parent from 67 to 69 [commons-codec]

2024-04-01 Thread via GitHub
garydgregory merged PR #261: URL: https://github.com/apache/commons-codec/pull/261 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@co

Re: [PR] Bump org.apache.commons:commons-parent from 67 to 69 [commons-release-plugin]

2024-04-01 Thread via GitHub
garydgregory merged PR #257: URL: https://github.com/apache/commons-release-plugin/pull/257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsub

Re: [PR] Bump org.apache.commons:commons-parent from 67 to 69 [commons-logging]

2024-04-01 Thread via GitHub
garydgregory merged PR #240: URL: https://github.com/apache/commons-logging/pull/240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] Bump org.apache.commons:commons-parent from 67 to 69 [commons-validator]

2024-04-01 Thread via GitHub
garydgregory merged PR #201: URL: https://github.com/apache/commons-validator/pull/201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

Re: [PR] Bump org.apache.commons:commons-parent from 67 to 69 [commons-net]

2024-04-01 Thread via GitHub
garydgregory merged PR #238: URL: https://github.com/apache/commons-net/pull/238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@comm

Re: [PR] Bump org.apache.commons:commons-parent from 67 to 69 [commons-build-plugin]

2024-04-01 Thread via GitHub
garydgregory merged PR #240: URL: https://github.com/apache/commons-build-plugin/pull/240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

Re: [PR] Bump org.apache.commons:commons-parent from 67 to 69 [commons-compress]

2024-04-01 Thread via GitHub
garydgregory merged PR #508: URL: https://github.com/apache/commons-compress/pull/508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

Re: [PR] Bump org.apache.commons:commons-parent from 67 to 69 [commons-bcel]

2024-04-01 Thread via GitHub
garydgregory merged PR #297: URL: https://github.com/apache/commons-bcel/pull/297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@com

Re: [PR] Add null guard for InstructionFactory.createInvoke() [commons-bcel]

2024-04-01 Thread via GitHub
garydgregory commented on PR #289: URL: https://github.com/apache/commons-bcel/pull/289#issuecomment-2029931534 @pingpingy1 TY for your PR; merged! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Add null guard for InstructionFactory.createInvoke() [commons-bcel]

2024-04-01 Thread via GitHub
garydgregory merged PR #289: URL: https://github.com/apache/commons-bcel/pull/289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@com

[jira] [Comment Edited] (IO-852) No release notes published for 2.16.0?

2024-04-01 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832837#comment-17832837 ] Gary D. Gregory edited comment on IO-852 at 4/1/24 1:02 PM: Websi

[jira] [Resolved] (IO-852) No release notes published for 2.16.0?

2024-04-01 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved IO-852. Fix Version/s: 2.16.0 Assignee: Gary D. Gregory Resolution: Fixed Website is up-to-date

Re: [PR] Support for Java 16 Record feature [commons-bcel]

2024-04-01 Thread via GitHub
garydgregory commented on code in PR #290: URL: https://github.com/apache/commons-bcel/pull/290#discussion_r1545655543 ## src/main/java/org/apache/bcel/classfile/Visitor.java: ## @@ -237,4 +249,15 @@ default void visitStackMapType(final StackMapType obj) { void visitSynthet

[jira] [Created] (IO-852) No release notes published for 2.16.0?

2024-04-01 Thread Jeremy Norris (Jira)
Jeremy Norris created IO-852: Summary: No release notes published for 2.16.0? Key: IO-852 URL: https://issues.apache.org/jira/browse/IO-852 Project: Commons IO Issue Type: Bug Affects Version

Re: [PR] Code smells removal [commons-math]

2024-04-01 Thread via GitHub
aherbert commented on code in PR #237: URL: https://github.com/apache/commons-math/pull/237#discussion_r1546063536 ## commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/ode/FieldEquationsMapper.java: ## @@ -199,4 +201,36 @@ private void checkIndex(final int index)

Re: [PR] Public method [commons-collections]

2024-04-01 Thread via GitHub
vad0 closed pull request #472: Public method URL: https://github.com/apache/commons-collections/pull/472 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Public method [commons-collections]

2024-04-01 Thread via GitHub
vad0 opened a new pull request, #472: URL: https://github.com/apache/commons-collections/pull/472 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib