Re: [PR] Cleanup help formatting [commons-cli]

garydgregory commented on code in PR #277: URL: https://github.com/apache/commons-cli/pull/277#discussion_r1605818691 ## src/main/java/org/apache/commons/cli/HelpFormatter.java: ## @@ -129,6 +129,16 @@ public Builder setShowDeprecated(final boolean useDefaultFormat) {

Re: [PR] Cleanup help formatting [commons-cli]

garydgregory commented on code in PR #277: URL: https://github.com/apache/commons-cli/pull/277#discussion_r1605818691 ## src/main/java/org/apache/commons/cli/HelpFormatter.java: ## @@ -129,6 +129,16 @@ public Builder setShowDeprecated(final boolean useDefaultFormat) {

Re: [PR] Cleanup help formatting [commons-cli]

garydgregory commented on code in PR #277: URL: https://github.com/apache/commons-cli/pull/277#discussion_r1605797848 ## src/site/xdoc/usage.xml: ## @@ -466,145 +465,141 @@ catch (ParseException exp) { deprecated method. Usage of the deprecated

Re: [PR] Cleanup help formatting [commons-cli]

garydgregory commented on code in PR #277: URL: https://github.com/apache/commons-cli/pull/277#discussion_r1605797762 ## src/main/java/org/apache/commons/cli/HelpFormatter.java: ## @@ -129,6 +129,14 @@ public Builder setShowDeprecated(final boolean useDefaultFormat) {

Re: [PR] Cleanup help formatting [commons-cli]

garydgregory commented on code in PR #277: URL: https://github.com/apache/commons-cli/pull/277#discussion_r1605797762 ## src/main/java/org/apache/commons/cli/HelpFormatter.java: ## @@ -129,6 +129,14 @@ public Builder setShowDeprecated(final boolean useDefaultFormat) {

Re: [PR] Cleanup help formatting [commons-cli]

Claudenw commented on code in PR #277: URL: https://github.com/apache/commons-cli/pull/277#discussion_r1605796694 ## src/site/xdoc/usage.xml: ## @@ -466,145 +465,141 @@ catch (ParseException exp) { deprecated method. Usage of the deprecated

Re: [PR] Cleanup help formatting [commons-cli]

Claudenw commented on code in PR #277: URL: https://github.com/apache/commons-cli/pull/277#discussion_r1605796400 ## src/site/xdoc/usage.xml: ## @@ -466,145 +465,141 @@ catch (ParseException exp) { deprecated method. Usage of the deprecated

Re: [PR] Cleanup help formatting [commons-cli]

Claudenw commented on code in PR #277: URL: https://github.com/apache/commons-cli/pull/277#discussion_r1605795923 ## src/main/java/org/apache/commons/cli/HelpFormatter.java: ## @@ -129,6 +129,14 @@ public Builder setShowDeprecated(final boolean useDefaultFormat) { }

Re: [PR] Improve memory allocation and validation [commons-imaging]

Marcono1234 commented on PR #401: URL: https://github.com/apache/commons-imaging/pull/401#issuecomment-2118834773 @garydgregory, yes I know that it has conflicts, and I can try to split this. My main goal was to show the general idea I had, the main important changes are in `Allocator` and

Re: [PR] Improve memory allocation and validation [commons-imaging]

garydgregory commented on PR #401: URL: https://github.com/apache/commons-imaging/pull/401#issuecomment-2118829400 @Marcono1234 Thank you for your PR but it conflicts with the current state of the master branch. As a general process issue, you should start with a smaller PR, 51 files

Re: [PR] Cleanup help formatting [commons-cli]

garydgregory commented on code in PR #277: URL: https://github.com/apache/commons-cli/pull/277#discussion_r1605789846 ## src/main/java/org/apache/commons/cli/HelpFormatter.java: ## @@ -129,6 +129,14 @@ public Builder setShowDeprecated(final boolean useDefaultFormat) {

[PR] Improve memory allocation and validation [commons-imaging]

Marcono1234 opened a new pull request, #401: URL: https://github.com/apache/commons-imaging/pull/401 This is a general proposal for how the commons-imaging code could better handle allocations to protect against malicious image data causing high memory consumption. The changes do not show

Re: [PR] COLLECTIONS-854 : renaming bloomfilter components and methods as per ticket [commons-collections]

garydgregory commented on code in PR #492: URL: https://github.com/apache/commons-collections/pull/492#discussion_r1605789594 ## src/main/java/org/apache/commons/collections4/bloomfilter/BitMapExtractor.java: ## @@ -61,33 +61,33 @@ public boolean forEachBitMap(final

[jira] [Created] (COLLECTIONS-855) Update the EnhancedDoubleHasher to correct the cube component of the hash

Alex Herbert created COLLECTIONS-855: Summary: Update the EnhancedDoubleHasher to correct the cube component of the hash Key: COLLECTIONS-855 URL: https://issues.apache.org/jira/browse/COLLECTIONS-855

Re: [PR] COLLECTIONS-854 : renaming bloomfilter components and methods as per ticket [commons-collections]

Claudenw commented on code in PR #492: URL: https://github.com/apache/commons-collections/pull/492#discussion_r1605689991 ## src/main/java/org/apache/commons/collections4/bloomfilter/BitMapExtractor.java: ## @@ -61,33 +61,33 @@ public boolean forEachBitMap(final LongPredicate

Re: [PR] COLLECTIONS-854 : renaming bloomfilter components and methods as per ticket [commons-collections]

Claudenw commented on code in PR #492: URL: https://github.com/apache/commons-collections/pull/492#discussion_r1605688857 ## src/main/java/org/apache/commons/collections4/bloomfilter/IndexExtractor.java: ## @@ -31,15 +31,15 @@ * @since 4.5 Review Comment: I don't think

[PR] Cleanup help formatting [commons-cli]

Claudenw opened a new pull request, #277: URL: https://github.com/apache/commons-cli/pull/277 Changes to simplify deprecated help output. - Changed `deprecatedFormatFunc` from `BiFunction` to `Function` - updated docs - added `HelpFormatter.getDescription(Option)` to provide a