Re: [PR] TEXT-217: Add SnakeCase Parsing [commons-text]

2024-05-25 Thread via GitHub
speters33w commented on PR #552: URL: https://github.com/apache/commons-text/pull/552#issuecomment-2131888601 I haven't downloaded this PR yet to take a good look at it yet. Probably Monday. I'll pull it and run a few aggressive tests. As far as conventions for camelCase, PascalCase,

Re: [PR] TEXT-217: Add SnakeCase Parsing [commons-text]

2024-05-25 Thread via GitHub
garydgregory commented on PR #552: URL: https://github.com/apache/commons-text/pull/552#issuecomment-2131476419 @Claudenw Please set this PR to Draft while we are still discussing it :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] TEXT-217: Add SnakeCase Parsing [commons-text]

2024-05-25 Thread via GitHub
garydgregory commented on code in PR #552: URL: https://github.com/apache/commons-text/pull/552#discussion_r1614897803 ## src/main/java/org/apache/commons/text/CasedString.java: ## @@ -0,0 +1,188 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

Re: [PR] TEXT-217: Add SnakeCase Parsing [commons-text]

2024-05-25 Thread via GitHub
garydgregory commented on code in PR #552: URL: https://github.com/apache/commons-text/pull/552#discussion_r1614896311 ## src/test/java/org/apache/commons/text/CasedStringTest.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

Re: [PR] TEXT-217: Add SnakeCase Parsing [commons-text]

2024-05-25 Thread via GitHub
Claudenw commented on code in PR #552: URL: https://github.com/apache/commons-text/pull/552#discussion_r1614874414 ## src/main/java/org/apache/commons/text/CasedString.java: ## @@ -0,0 +1,188 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

Re: [PR] TEXT-217: Add SnakeCase Parsing [commons-text]

2024-05-25 Thread via GitHub
Claudenw commented on code in PR #552: URL: https://github.com/apache/commons-text/pull/552#discussion_r1614873256 ## src/test/java/org/apache/commons/text/CasedStringTest.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

Re: [PR] Change visibility of PropertyUtilsBean.getReadMethod(Class, PropertyDescriptor) [commons-beanutils]

2024-05-25 Thread via GitHub
garydgregory merged PR #232: URL: https://github.com/apache/commons-beanutils/pull/232 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

Re: [PR] TEXT-217: Add SnakeCase Parsing [commons-text]

2024-05-25 Thread via GitHub
garydgregory commented on code in PR #552: URL: https://github.com/apache/commons-text/pull/552#discussion_r1614753424 ## src/main/java/org/apache/commons/text/CasedString.java: ## @@ -0,0 +1,188 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

Re: [PR] Change visibility of PropertyUtilsBean.getReadMethod(Class, PropertyDescriptor) [commons-beanutils]

2024-05-25 Thread via GitHub
doublep commented on PR #232: URL: https://github.com/apache/commons-beanutils/pull/232#issuecomment-2131229026 @garydgregory I just pushed some Javadoc changes. Feel free to rewrite or adjust as you prefer, easier this way than negotiating in advance. -- This is an automated message fro

Re: [PR] TEXT-217: Add SnakeCase Parsing [commons-text]

2024-05-25 Thread via GitHub
garydgregory commented on code in PR #552: URL: https://github.com/apache/commons-text/pull/552#discussion_r1614604438 ## src/main/java/org/apache/commons/text/CasedString.java: ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

Re: [PR] TEXT-217: Add SnakeCase Parsing [commons-text]

2024-05-25 Thread via GitHub
garydgregory commented on code in PR #552: URL: https://github.com/apache/commons-text/pull/552#discussion_r1614603731 ## src/test/java/org/apache/commons/text/CasedStringTest.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

Re: [PR] TEXT-217: Add SnakeCase Parsing [commons-text]

2024-05-25 Thread via GitHub
garydgregory commented on PR #552: URL: https://github.com/apache/commons-text/pull/552#issuecomment-2131225530 Please see my reply in [TEXT-217](https://issues.apache.org/jira/browse/TEXT-217) The tests are too obtuse from my POV and there is zero Javadoc to set user expectations (s

[jira] [Commented] (TEXT-217) Snake case utility method: CaseUtils.toSnakeCase(....)

2024-05-25 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/TEXT-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849453#comment-17849453 ] Gary D. Gregory commented on TEXT-217: -- Hi [~claude] This could both be useful but al

Re: [PR] TEXT-217: Add SnakeCase Parsing [commons-text]

2024-05-25 Thread via GitHub
Claudenw commented on PR #552: URL: https://github.com/apache/commons-text/pull/552#issuecomment-2131213314 The test does a cross product of cases. I find that using `WordUtils.capitalise()` and `WordUitls.uncapitalise()` can address the capitalisation SnakeCase issues. I found I nee

Re: [PR] TEXT-217: Add SnakeCase Parsing [commons-text]

2024-05-25 Thread via GitHub
garydgregory commented on PR #552: URL: https://github.com/apache/commons-text/pull/552#issuecomment-2131209608 For me, camel case starts with a lower case like a Java method name or an Open API key. -- This is an automated message from the Apache Git Service. To respond to the message, p

[jira] [Commented] (TEXT-217) Snake case utility method: CaseUtils.toSnakeCase(....)

2024-05-25 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/TEXT-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849452#comment-17849452 ] Gary D. Gregory commented on TEXT-217: -- Where does OpenAPI require snake case for keys

[jira] [Updated] (TEXT-217) Snake case utility method: CaseUtils.toSnakeCase(....)

2024-05-25 Thread Claude Warren (Jira)
[ https://issues.apache.org/jira/browse/TEXT-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Warren updated TEXT-217: --- Fix Version/s: 1.12.1 (was: 1.9) > Snake case utility method: CaseUtils.toSnakeC

[jira] [Commented] (TEXT-217) Snake case utility method: CaseUtils.toSnakeCase(....)

2024-05-25 Thread Claude Warren (Jira)
[ https://issues.apache.org/jira/browse/TEXT-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849450#comment-17849450 ] Claude Warren commented on TEXT-217: pull request #552 solves the problem by creating a

[jira] [Updated] (TEXT-217) Snake case utility method: CaseUtils.toSnakeCase(....)

2024-05-25 Thread Claude Warren (Jira)
[ https://issues.apache.org/jira/browse/TEXT-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Warren updated TEXT-217: --- Assignee: Claude Warren > Snake case utility method: CaseUtils.toSnakeCase() >