[jira] [Updated] (POOL-211) Proxy support for pooled objects

2013-01-10 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas updated POOL-211: - Affects Version/s: 2.0 Consider something along these lines for the 2.0 branch as well

[jira] [Commented] (POOL-229) Move AbandonedObjectPool from DBCP to POOL

2013-01-10 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13550474#comment-13550474 ] Mark Thomas commented on POOL-229: -- I've applied the patch above (with a few tweaks

[jira] [Commented] (POOL-231) GOP, GKOP invalidateObject is not threadsafe

2012-12-04 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13509876#comment-13509876 ] Mark Thomas commented on POOL-231: -- +1 works for me GOP, GKOP

[jira] [Commented] (POOL-228) Unit test failure in TestGenericObjectPoolClassLoaders

2012-08-01 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13426374#comment-13426374 ] Mark Thomas commented on POOL-228: -- No confusion here. I was looking at the 1.6.x code

[jira] [Commented] (POOL-227) Unit test failures due to getMinIdle changes

2012-07-31 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13426053#comment-13426053 ] Mark Thomas commented on POOL-227: -- Patch is unreviewable. Far too many whitespace changes

[jira] [Commented] (POOL-228) Unit test failure in TestGenericObjectPoolClassLoaders

2012-07-31 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13426077#comment-13426077 ] Mark Thomas commented on POOL-228: -- That test passes for me. Your analysis is wrong

[jira] [Commented] (POOL-226) GenericKeyedObjectPool.ObjectTimestampPair fields could be made final without breaking compat?

2012-07-31 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13426080#comment-13426080 ] Mark Thomas commented on POOL-226: -- That class is removed entirely in Pool2 anyway

Re: [jira] [Commented] (IMAGING-82) BMP Physical Width in inches and Physical Height in inches is wrong

2012-06-27 Thread Mark Thomas
On 27/06/2012 09:30, Luc Maisonobe (JIRA) wrote: [ https://issues.apache.org/jira/browse/IMAGING-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13402056#comment-13402056 ] Luc Maisonobe commented on IMAGING-82:

[jira] [Resolved] (POOL-217) PoolUtils.MIN_IDLE_TIMER could be provided using an IODH

2012-06-17 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-217. -- Resolution: Fixed Fix Version/s: 2.0 PoolUtils.MIN_IDLE_TIMER could be provided using

[jira] [Resolved] (POOL-220) PooledObject#compareTo() is not guaranteed consistent with equals

2012-06-17 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-220. -- Resolution: Fixed Fix Version/s: 2.0 Adding the pointless methods was less hassle than setting up

[jira] [Updated] (POOL-211) Proxy support for pooled objects

2012-05-06 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas updated POOL-211: - Fix Version/s: (was: Nightly Builds) Proxy support for pooled objects

[jira] [Commented] (POOL-219) Example documentation refers to StackObjectPool which is not present in Pool2

2012-05-05 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13269055#comment-13269055 ] Mark Thomas commented on POOL-219: -- References to StackObjectPool need to be removed. GOP

[jira] [Resolved] (POOL-220) PoolableObject#compareTo() is not guaranteed consistent with equals

2012-05-05 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-220. -- Resolution: Fixed I went for the option of clarifying in the Javadoc that the natural ordering

[jira] [Resolved] (POOL-218) Does borrowObject block?

2012-05-04 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-218. -- Resolution: Invalid Jira is not a support forum. This question belongs on the users mailing list

[jira] [Resolved] (POOL-215) GenericKeyedObjectPool - multiple mutable fields not published safely

2012-05-02 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-215. -- Resolution: Fixed Fix Version/s: 2.0 Fixed in the refactoring to use BaseGenericObjectPool. All

[jira] [Commented] (POOL-213) _numActive can go negative

2012-05-02 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13266462#comment-13266462 ] Mark Thomas commented on POOL-213: -- pool2 is a major refactoring that is close to the first

[jira] [Resolved] (POOL-214) GenericObjectPool.evictionPolicy not thread-safe

2012-04-30 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-214. -- Resolution: Fixed Fix Version/s: 2.0 This was resolved as part of the refactoring to use

[jira] (POOL-213) _numActive can go negative

2012-04-25 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas updated POOL-213: - Attachment: test.txt _numActive can go negative -- Key

Re: [jira] (POOL-213) _numActive can go negative

2012-04-25 Thread Mark Thomas
On 25/04/2012 11:50, Mark Thomas (JIRA) wrote: [ https://issues.apache.org/jira/browse/POOL-213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas updated POOL-213: - Attachment: test.txt Please ignore

[jira] [Commented] (POOL-212) GenericObjectPool allows maxIdle minIdle

2012-04-12 Thread Mark Thomas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13252756#comment-13252756 ] Mark Thomas commented on POOL-212: -- This can't be fixed in the setters since in a number

[jira] [Updated] (POOL-212) GenericObjectPool allows maxIdle minIdle

2012-04-12 Thread Mark Thomas (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas updated POOL-212: - Fix Version/s: 1.5.8 1.6.1 GenericObjectPool allows maxIdle minIdle

[jira] [Resolved] (POOL-212) GenericObjectPool allows maxIdle minIdle

2012-04-12 Thread Mark Thomas (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-212. -- Resolution: Fixed Fixed in all current development lines. GenericObjectPool allows

[jira] [Moved] (DBCP-379) number of connections created has crossed more than maxActive

2012-04-02 Thread Mark Thomas (Moved) (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas moved POOL-107 to DBCP-379: --- Fix Version/s: (was: 1.5) Affects Version/s: (was: 1.3

[jira] [Commented] (DBCP-379) number of connections created has crossed more than maxActive

2012-04-02 Thread Mark Thomas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13244455#comment-13244455 ] Mark Thomas commented on DBCP-379: -- Moved to DBCP since the issue described is as DBCP

[jira] [Closed] (NET-457) Does commonsnet ftp component connect to a Secure Stratus site?

2012-03-27 Thread Mark Thomas (Closed) (JIRA)
[ https://issues.apache.org/jira/browse/NET-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas closed NET-457. --- Resolution: Invalid JIRA is not a support forum. Please use the users mailing list. Does

[jira] [Resolved] (DBCP-297) Ciphered passwords

2012-03-05 Thread Mark Thomas (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved DBCP-297. -- Resolution: Won't Fix This feature is impossible to implement in any way that provides meaningful

[jira] [Commented] (DBCP-377) Dbcp Idle Check Mechanism Doesn't Work

2012-03-05 Thread Mark Thomas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13222645#comment-13222645 ] Mark Thomas commented on DBCP-377: -- I'm not aware of any known issues with idle object

[jira] [Resolved] (POOL-161) ContextClassLoader problems for the Evictor thread

2012-02-14 Thread Mark Thomas (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-161. -- Resolution: Fixed Fix ported to 1.5.x and 2.x ContextClassLoader problems

[jira] [Resolved] (POOL-203) GenericKeyedObjectPool.ObjectDeque could be better encapsulated

2012-02-14 Thread Mark Thomas (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-203. -- Resolution: Won't Fix GenericKeyedObjectPool.ObjectDeque could be better encapsulated

[jira] [Commented] (POOL-209) SharedPoolDataSource does not handle null keys correctly

2012-02-14 Thread Mark Thomas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207977#comment-13207977 ] Mark Thomas commented on POOL-209: -- If you see this issue, please also provide details

[jira] [Commented] (POOL-209) SharedPoolDataSource does not handle null keys correctly

2012-02-14 Thread Mark Thomas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207997#comment-13207997 ] Mark Thomas commented on POOL-209: -- I have been reviewing the 1.5.4 and 1.5.x pool code

[jira] [Commented] (POOL-161) ContextClassLoader problems for the Evictor thread

2012-02-13 Thread Mark Thomas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207329#comment-13207329 ] Mark Thomas commented on POOL-161: -- Craig: Per context use of commons pool does avoid

[jira] [Updated] (POOL-161) ContextClassLoader problems for the Evictor thread

2012-02-13 Thread Mark Thomas (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas updated POOL-161: - Fix Version/s: 1.5.8 ContextClassLoader problems for the Evictor thread

[jira] [Commented] (POOL-161) ContextClassLoader problems for the Evictor thread

2012-02-13 Thread Mark Thomas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13207344#comment-13207344 ] Mark Thomas commented on POOL-161: -- Huh? Could you explain that comment please. We already

[jira] [Commented] (POOL-107) number of connections created has crossed more than maxActive

2012-02-12 Thread Mark Thomas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13206526#comment-13206526 ] Mark Thomas commented on POOL-107: -- I've spent some time looking at this and I am

[jira] [Resolved] (POOL-207) GenericKeyedObjectPool.clear() has unnecessary null check of objectDequeue

2012-02-09 Thread Mark Thomas (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-207. -- Resolution: Fixed Thanks for the analysis. GenericKeyedObjectPool.clear() has

[jira] [Resolved] (POOL-100) Possibiblity to define eviction policies

2012-02-09 Thread Mark Thomas (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-100. -- Resolution: Fixed Now fully implemented. There is probably scope to extend / modify the interfaces

Re: [jira] [Closed] (NET-439) there should be some improvement in font size

2012-02-02 Thread Mark Thomas
On 02/02/2012 10:17, srinivas (Closed) (JIRA) wrote: [ https://issues.apache.org/jira/browse/NET-439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] srinivas closed NET-439. This idiot has just had their access to the ASF Jira removed.

[jira] [Deleted] (NET-439) there should be some improvement in font size

2012-02-02 Thread Mark Thomas (Deleted) (JIRA)
[ https://issues.apache.org/jira/browse/NET-439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas deleted NET-439: there should be some improvement in font size

[jira] [Commented] (POOL-211) Proxy support for pooled objects

2012-01-30 Thread Mark Thomas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13196359#comment-13196359 ] Mark Thomas commented on POOL-211: -- Pool 2 doesn't provide this functionality directly

[jira] [Created] (DAEMON-237) ++JvmOptions processed as --JvmOptions

2012-01-28 Thread Mark Thomas (Created) (JIRA)
: 1.0.8 Environment: XP 64-bit, XP 32-bit, Windows 7 64-bit Reporter: Mark Thomas See https://issues.apache.org/bugzilla/show_bug.cgi?id=52548 and http://tomcat.markmail.org/thread/md3ibbv2w3mxtnb2 for details -- This message is automatically generated by JIRA. If you think

[jira] [Commented] (DBCP-376) Thread safety issue

2012-01-25 Thread Mark Thomas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13193029#comment-13193029 ] Mark Thomas commented on DBCP-376: -- That the pooling implementation has been completely re

[jira] [Resolved] (DBCP-374) commons-dbcp-1.4-src compile fail with apache-ant-1.8.2 and jdk1.7.0_02 and jdk1.6.0_29

2011-12-29 Thread Mark Thomas (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved DBCP-374. -- Resolution: Invalid You must use Java 6 to build. You need to configure the dependencies

[jira] [Reopened] (POOL-107) number of connections created has crossed more than maxActive

2011-12-28 Thread Mark Thomas (Reopened) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas reopened POOL-107: -- Re-open as fix may be incomplete number of connections created has crossed more than

[jira] [Updated] (POOL-207) GenericKeyedObjectPool.clear() has unnecessary null check of objectDequeue

2011-12-21 Thread Mark Thomas (Updated) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas updated POOL-207: - Fix Version/s: 2.0 GenericKeyedObjectPool.clear() has unnecessary null check of objectDequeue

[jira] [Commented] (POOL-100) Possibiblity to define eviction policies

2011-12-17 Thread Mark Thomas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171619#comment-13171619 ] Mark Thomas commented on POOL-100: -- I have half a patch for this that I hope to complete

[jira] [Resolved] (POOL-206) GOP/GKOP close() - incorrect behaviour with evict() ?

2011-12-17 Thread Mark Thomas (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-206. -- Resolution: Fixed The evictor is now stopped before closing the pool. Marking the pool as closed while

[jira] [Resolved] (POOL-205) GKOP - inconsistent synchronisation of poolKeyList

2011-12-17 Thread Mark Thomas (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-205. -- Resolution: Fixed Fixed by adding a read lock GKOP - inconsistent synchronisation

[jira] [Commented] (POOL-204) GKOP encapsulate poolMap/poolKeyList to ensure invariants?

2011-12-17 Thread Mark Thomas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171655#comment-13171655 ] Mark Thomas commented on POOL-204: -- Hmm. I'm currently wondering if I can just remove

[jira] [Commented] (POOL-204) GKOP encapsulate poolMap/poolKeyList to ensure invariants?

2011-12-17 Thread Mark Thomas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171656#comment-13171656 ] Mark Thomas commented on POOL-204: -- Scratch that. The list is required to maintain eviction

[jira] [Commented] (POOL-204) GKOP encapsulate poolMap/poolKeyList to ensure invariants?

2011-12-17 Thread Mark Thomas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171658#comment-13171658 ] Mark Thomas commented on POOL-204: -- The data structures are already encapsulated within

[jira] [Resolved] (POOL-204) GKOP encapsulate poolMap/poolKeyList to ensure invariants?

2011-12-17 Thread Mark Thomas (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-204. -- Resolution: Fixed Comments added. GKOP encapsulate poolMap/poolKeyList to ensure

[jira] [Commented] (POOL-203) GenericKeyedObjectPool.ObjectDeque could be better encapsulated

2011-12-17 Thread Mark Thomas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171663#comment-13171663 ] Mark Thomas commented on POOL-203: -- This is an awful lot of work that adds quite a lot

[jira] [Resolved] (POOL-202) GenericKeyedObjectPool.close() can interfere with evict(); eviction[Key]Iterator is not consistently synched.

2011-12-17 Thread Mark Thomas (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-202. -- Resolution: Fixed Fixed by moving to startEvictor. Also aligned GOP with GKOP

[jira] [Resolved] (POOL-176) GenericKeyedObjectPool should support softMinEvictableIdleTimeMillis a la GenericObjectPool

2011-12-17 Thread Mark Thomas (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-176. -- Resolution: Fixed GenericKeyedObjectPool should support softMinEvictableIdleTimeMillis a la

[jira] [Resolved] (POOL-200) GOP/GKOP don't consistently use getters to access fields

2011-12-14 Thread Mark Thomas (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-200. -- Resolution: Fixed Fix Version/s: 2.0 GOP/GKOP don't consistently use getters to access

[jira] [Commented] (POOL-201) Classes Generic[Keyed]ObjectPoolConfig are generic - but why?

2011-12-14 Thread Mark Thomas (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13169618#comment-13169618 ] Mark Thomas commented on POOL-201: -- It is a left-over from when the factory was part

[jira] [Resolved] (POOL-201) Classes Generic[Keyed]ObjectPoolConfig are generic - but why?

2011-12-14 Thread Mark Thomas (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-201. -- Resolution: Fixed Fix Version/s: 2.0 Classes Generic[Keyed]ObjectPoolConfig are generic

[jira] [Resolved] (POOL-159) GenericObjectPool: Add a getNumWaiters() method for monitoring purposes

2011-12-14 Thread Mark Thomas (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-159. -- Resolution: Fixed With the POOL2 re-write, this was easy to implement

[jira] [Resolved] (POOL-197) PooledObject: risky init of lastBorrowTime lastReturnTime

2011-12-13 Thread Mark Thomas (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-197. -- Resolution: Fixed Fix Version/s: 2.0 PooledObject: risky init of lastBorrowTime

[jira] [Resolved] (POOL-198) LinkedBlockingDeque has some non-private fields, and a package-protected internal method

2011-12-13 Thread Mark Thomas (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-198. -- Resolution: Fixed Fix Version/s: 2.0 Those issues are all side-effects of copying the class from

[jira] [Resolved] (POOL-196) PooledObject.getActiveTimeMillis() does not synch. access to lastReturnTime and lastBorrowTime

2011-12-13 Thread Mark Thomas (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-196. -- Resolution: Fixed Fix Version/s: 2.0 PooledObject.getActiveTimeMillis() does not synch

[jira] [Resolved] (POOL-195) Generic[Keyed]ObjectPool.startEvictor() is overrideable yet is called from the ctor

2011-12-13 Thread Mark Thomas (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-195. -- Resolution: Fixed Fix Version/s: 2.0 I went with the final option. Generic

[jira] [Resolved] (POOL-193) It is safer to make org.apache.commons.pool2.impl.GenericObjectPool.evictor volatile

2011-12-13 Thread Mark Thomas (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-193. -- Resolution: Fixed Fix Version/s: 2.0 I made the method synchronized to align it with GKOP

[jira] [Resolved] (POOL-190) Add API BaseObjectPool.isOpen()

2011-12-13 Thread Mark Thomas (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-190. -- Resolution: Fixed BOP is still present in 2.0. There is an isClosed() method that can be used

[jira] [Resolved] (POOL-182) Issues with org.apache.commons.pool2.performance. PerformanceTest

2011-12-13 Thread Mark Thomas (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-182. -- Resolution: Fixed I merged the proposed match manually. Functional changes were kept. Cosmetic ones

[jira] [Resolved] (POOL-164) GenericKeyedObjectPoolFactory should be able to load itself from a properties file

2011-12-13 Thread Mark Thomas (Resolved) (JIRA)
[ https://issues.apache.org/jira/browse/POOL-164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-164. -- Resolution: Won't Fix There appears to be little demand for this so I suggest that you implement

[jira] [Resolved] (POOL-172) Add JMX (MBean) management and monitoring

2011-08-17 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-172. -- Resolution: Fixed Assignee: Mark Thomas GOP and GKOP attributes are now exposed via JMX. Add JMX

[jira] [Resolved] (POOL-98) Make GenericObjectPool better extensible

2011-08-17 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-98?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-98. - Resolution: Fixed Assignee: Mark Thomas Because pool2 retains references to all the objects, not just

[jira] [Resolved] (POOL-148) borrowObject should return the exception thrown by validateObject when throwing an Exception to let Exceptions be handled at a higher level

2011-08-17 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-148. -- Resolution: Fixed Assignee: Mark Thomas This was addressed in the pool2 re-factoring

[jira] [Commented] (POOL-131) Make org.apache.commons.pool.impl.GenericObjectPool.returnObject(Object) log errors about passivation/destroying

2011-08-17 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13086459#comment-13086459 ] Mark Thomas commented on POOL-131: -- Throwing runtime exceptions is likely to cause more

[jira] [Resolved] (POOL-142) Swallowing exceptions throw by factory destroy() methods can hide genuine issues

2011-08-17 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-142. -- Resolution: Duplicate Agree with the analysis. Logging the exception is probably the best approach. See

[jira] [Commented] (POOL-99) Test for idle time exceeded in borrowObject

2011-08-15 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-99?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13085147#comment-13085147 ] Mark Thomas commented on POOL-99: - In that scenario, simply execute a validation query (which

[jira] [Resolved] (POOL-99) Test for idle time exceeded in borrowObject

2011-08-14 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-99?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-99. - Resolution: Won't Fix The idle time feature is based on the assumption that objects are expensive to keep

[jira] [Resolved] (POOL-119) GenericObjectPool: Provide option to create new objects serial

2011-08-14 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-119. -- Resolution: Won't Fix Since there appears to be no interest in providing a patch for what appears to me

[jira] [Resolved] (POOL-124) Access to enclosing constructor Foo.Bar() is emulated by a synthetic accessor method. Increasing its visibility will improve your performance.

2011-08-14 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-124. -- Resolution: Won't Fix I don't like the code changes fixing this issue requires. I'd much prefer

[jira] [Resolved] (POOL-155) ObjectPool.invalidateObject(object) should throw an Exception if object is null

2011-08-14 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-155. -- Resolution: Fixed Pool 2.0.x ensures the following: - only objects borrowed from the pool may

[jira] [Resolved] (POOL-173) Better config without duplication.

2011-08-14 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-173. -- Resolution: Fixed The configuration did get re-done once the new pooling implementation was ironed out

[jira] [Resolved] (POOL-178) Common interfaces and abstract classes for BOP and BKOP

2011-08-14 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-178. -- Resolution: Fixed There were quite a few changes in the API as part of the 2.0.x changes but all

[jira] [Resolved] (DBCP-350) Problem with DBCP 1.3 /jdk 6 and oracle spatial

2011-08-11 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved DBCP-350. -- Resolution: Not A Problem The analysis shows that this is caused by hibernate needing to access the raw

[jira] [Commented] (DBCP-350) Problem with DBCP 1.3 /jdk 6 and oracle spatial

2011-08-11 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13083058#comment-13083058 ] Mark Thomas commented on DBCP-350: -- No, DBCP does not use hibernate. Your application

[jira] [Deleted] (JELLY-289) CLONE -Problem with default namespace in imported scripts

2011-08-08 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/JELLY-289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas deleted JELLY-289: -- CLONE -Problem with default namespace in imported scripts

[jira] [Created] (FILEUPLOAD-199) Uploads have unexpected results for files with non-ASCII names - support RFC2047

2011-07-21 Thread Mark Thomas (JIRA)
: Commons FileUpload Issue Type: Bug Affects Versions: 1.2.2 Reporter: Mark Thomas Uploading a file with a UTF-8 file name results in a garbled file name on the server. Both the browser and Commons File Upload are at fault in this process. The headers for each uploaded

[jira] [Resolved] (DAEMON-212) Remove reference to resolved issue DAEMON-49 from service how-to

2011-07-08 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/DAEMON-212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved DAEMON-212. Resolution: Invalid The Commons Daemon project has no control over the Tomcat docs. You need

[jira] [Resolved] (POOL-140) Rethink synchronisation strategy

2011-07-07 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-140. -- Resolution: Fixed Both these issues have been addressed in the redesign and re-factoring that is part

[jira] [Resolved] (POOL-177) GenericKeyedObjectPoolFactory and GenericObjectPoolFactory to share a common superclass

2011-07-07 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-177. -- Resolution: Won't Fix Having restarted the pool2 re-factoring using dbcp2 as a reality check for what

[jira] [Resolved] (POOL-103) Tracing borrowed objects

2011-07-07 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-103. -- Resolution: Fixed The re-factoring in pool2 has added checks that throw an exception if: - an object

[jira] [Created] (DAEMON-210) Service Manager autostart should check for administrative rights

2011-06-23 Thread Mark Thomas (JIRA)
: Improvement Components: Procrun Affects Versions: 1.0.5 Reporter: Mark Thomas See https://issues.apache.org/bugzilla/show_bug.cgi?id=33262 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (POOL-150) GenericKeyedObjectPool.preparePool does not throw an exception if supplied factory is null

2011-06-13 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-150. -- Resolution: Fixed This was fixed as a side-effect of the 2.0.x re-factoring although not in the manner

[jira] [Resolved] (POOL-134) Parameterize the maxWait time to be per borrow call

2011-06-13 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-134. -- Resolution: Fixed Assignee: Mark Thomas Parameterize the maxWait time to be per borrow call

[jira] [Resolved] (POOL-121) Provide thread name for EvcitionTimer

2011-06-13 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-121. -- Resolution: Fixed Provide thread name for EvcitionTimer

[jira] [Resolved] (POOL-84) [PATCH] Proposal for a new pool type SharedObjectPool

2011-06-11 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-84?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-84. - Resolution: Won't Fix This use case doesn't seem to fit in with the use cases pool is intended to support

[jira] [Commented] (POOL-84) [PATCH] Proposal for a new pool type SharedObjectPool

2011-06-11 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13047982#comment-13047982 ] Mark Thomas commented on POOL-84: - Test comment. Please ignore. (I'll delete it shortly

[jira] [Updated] (POOL-84) [PATCH] Proposal for a new pool type SharedObjectPool

2011-06-11 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-84?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas updated POOL-84: Comment: was deleted (was: Test comment. Please ignore. (I'll delete it shortly). Apologies for the noise

[jira] [Resolved] (POOL-188) Confusing PoolUtils.ErodingKeyedObjectPool.numIdle(K key) method; bug in ErodingKeyedObjectPool.returnObject(K key, V obj) ?

2011-05-21 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-188. -- Resolution: Fixed Fix Version/s: 2.0 Assignee: Mark Thomas Confusing

[jira] [Resolved] (POOL-185) when continue kill all connection , Cannot get a connection.

2011-05-21 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-185. -- Resolution: Invalid No response from OP - assume this is a question for the users list. when continue

[jira] [Created] (DAEMON-206) Improve checks on service name

2011-05-20 Thread Mark Thomas (JIRA)
Improve checks on service name -- Key: DAEMON-206 URL: https://issues.apache.org/jira/browse/DAEMON-206 Project: Commons Daemon Issue Type: Improvement Reporter: Mark Thomas See https

[jira] [Resolved] (DBCP-300) remove synchronize access of createDataSource

2011-05-10 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved DBCP-300. -- Resolution: Fixed This has been fixed for DBCP 2.x onwards. Earlier versions can't be fixed since

[jira] [Reopened] (POOL-180) Max active per key can be exceeded by one

2011-03-24 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas reopened POOL-180: -- Phil spotted similar issues in evict that also need to be fixed. Max active per key can be exceeded by one

[jira] [Resolved] (POOL-179) GenericObjectPool.borrowObject() incorrectly swallows InterruptedException

2011-03-23 Thread Mark Thomas (JIRA)
[ https://issues.apache.org/jira/browse/POOL-179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved POOL-179. -- Resolution: Fixed Assignee: Mark Thomas Fixed for 1.5.6 and the current trunk

<    1   2   3   4   5   6   7   8   >