[GitHub] [commons-bcel] KengoTODA commented on pull request #157: Keep ConstantPool.getConstant(int) backward compatible with v6.5.0

2022-11-15 Thread GitBox
KengoTODA commented on PR #157: URL: https://github.com/apache/commons-bcel/pull/157#issuecomment-1316097489 Wmm, I don't think so. This PR affects nothing related to iterating data in the class file, nor writing bytecode to class files... BCEL 6.6.1 has no other big changes,

[GitHub] [commons-bcel] KengoTODA commented on pull request #157: Keep ConstantPool.getConstant(int) backward compatible with v6.5.0

2022-10-18 Thread GitBox
KengoTODA commented on PR #157: URL: https://github.com/apache/commons-bcel/pull/157#issuecomment-1282978963 note: I've checked the implementation of OpenJDK. I found the code that skips classfile entry after long constants and double constants, but cannot find its intention because the

[GitHub] [commons-bcel] KengoTODA commented on pull request #157: Keep ConstantPool.getConstant(int) backward compatible with v6.5.0

2022-10-16 Thread GitBox
KengoTODA commented on PR #157: URL: https://github.com/apache/commons-bcel/pull/157#issuecomment-1280010676 I'll check it, thanks for reminding me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [commons-bcel] KengoTODA commented on pull request #157: Keep ConstantPool.getConstant(int) backward compatible with v6.5.0

2022-10-15 Thread GitBox
KengoTODA commented on PR #157: URL: https://github.com/apache/commons-bcel/pull/157#issuecomment-1279876921 > I was using Eclipse I see, then this problem should be OpenJDK-based compiler specific. > There must be a better way to deal with this issue though because this PR

[GitHub] [commons-bcel] KengoTODA commented on pull request #157: Keep ConstantPool.getConstant(int) backward compatible with v6.5.0

2022-10-15 Thread GitBox
KengoTODA commented on PR #157: URL: https://github.com/apache/commons-bcel/pull/157#issuecomment-1279857807 Confirmed that this problem can be reproduced with Java version `8.0.345` and `17.0.4.1` distributed by Temurin. So it's not Java version dependent... are you using ecj or another

[GitHub] [commons-bcel] KengoTODA commented on pull request #157: Keep ConstantPool.getConstant(int) backward compatible with v6.5.0

2022-10-15 Thread GitBox
KengoTODA commented on PR #157: URL: https://github.com/apache/commons-bcel/pull/157#issuecomment-1279853964 full `javap` result: ``` Classfile /private/tmp/ClassWithNullConstantPoolItem.class Last modified Oct 15, 2022; size 278 bytes MD5 checksum

[GitHub] [commons-bcel] KengoTODA commented on pull request #157: Keep ConstantPool.getConstant(int) backward compatible with v6.5.0

2022-10-15 Thread GitBox
KengoTODA commented on PR #157: URL: https://github.com/apache/commons-bcel/pull/157#issuecomment-1279852144 Really interesting, it could be compiler dependent? I can reproduce it with AdoptOpenJDK-11.0.11+9. I'll try to add a unit test to reproduce. Thanks. -- This is an

[GitHub] [commons-bcel] KengoTODA commented on pull request #157: Keep ConstantPool.getConstant(int) backward compatible with v6.5.0

2022-10-15 Thread GitBox
KengoTODA commented on PR #157: URL: https://github.com/apache/commons-bcel/pull/157#issuecomment-1279751051 full stack trace for reference ``` The following errors occurred during analysis: Exception analyzing ghIssues.Issue389 using detector