[GitHub] [commons-bcel] nbauma109 commented on a diff in pull request #177: Bcelifier stackmap support verifier

2022-11-29 Thread GitBox
nbauma109 commented on code in PR #177: URL: https://github.com/apache/commons-bcel/pull/177#discussion_r1034761303 ## src/test/resources/StackMapExample2.java: ## @@ -0,0 +1,8 @@ +public class StackMapExample2 { + Review Comment: Commented rather than javadoc-ed as it is te

[GitHub] [commons-bcel] nbauma109 commented on a diff in pull request #177: Bcelifier stackmap support verifier

2022-11-29 Thread GitBox
nbauma109 commented on code in PR #177: URL: https://github.com/apache/commons-bcel/pull/177#discussion_r1034748724 ## src/main/java/org/apache/bcel/classfile/Code.java: ## @@ -247,6 +247,20 @@ public LineNumberTable getLineNumberTable() { return null; } +/**

[GitHub] [commons-bcel] nbauma109 commented on a diff in pull request #177: Bcelifier stackmap support verifier

2022-11-29 Thread GitBox
nbauma109 commented on code in PR #177: URL: https://github.com/apache/commons-bcel/pull/177#discussion_r1034720605 ## src/main/java/org/apache/bcel/classfile/Code.java: ## @@ -247,6 +247,20 @@ public LineNumberTable getLineNumberTable() { return null; } +/**

[GitHub] [commons-bcel] nbauma109 commented on a diff in pull request #177: Bcelifier stackmap support verifier

2022-11-29 Thread GitBox
nbauma109 commented on code in PR #177: URL: https://github.com/apache/commons-bcel/pull/177#discussion_r1034705119 ## src/main/java/org/apache/bcel/classfile/StackMapType.java: ## @@ -29,9 +29,9 @@ * @see StackMap * @see Const */ -public final class StackMapType implement

[GitHub] [commons-bcel] nbauma109 commented on a diff in pull request #177: Bcelifier stackmap support verifier

2022-11-29 Thread GitBox
nbauma109 commented on code in PR #177: URL: https://github.com/apache/commons-bcel/pull/177#discussion_r1034702240 ## src/main/java/org/apache/bcel/classfile/StackMap.java: ## @@ -135,7 +135,7 @@ public StackMapEntry[] getStackMap() { public void setStackMap(final StackMap