garydgregory commented on pull request #33:
URL: https://github.com/apache/commons-cli/pull/33#issuecomment-945225559


   Hi @waso 
   
   The way the current code stands, a Builder MUST have a valid option as 
enforced by the call to `OptionValidator.validate()` in the Builder 
constructor, such that you cannot build an Option or even an Option builder 
without a valid option. This PR might let you build invalid options. I'm not 
sure as I did not try to run a debugger. _But_, I could see keeping the current 
fail-fast behavior _if_ the new setter called `OptionValidator.validate`, at 
least that would be closer to the current behavior.
   
   May you please rebase on git master?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to