[GitHub] [commons-codec] adamretter commented on issue #46: Base16 Input and Output Streams

2020-04-21 Thread GitBox
adamretter commented on issue #46: URL: https://github.com/apache/commons-codec/pull/46#issuecomment-617230193 @aherbert After your initial PR feedback which seemed positive, your second comments are quite disheartening. I tried to reuse what was already present in Commons Codec, i.e. the

[GitHub] [commons-codec] adamretter commented on issue #46: Base16 Input and Output Streams

2020-04-21 Thread GitBox
adamretter commented on issue #46: URL: https://github.com/apache/commons-codec/pull/46#issuecomment-617090652 @garydgregory @aherbert Thanks for the feedback. I have pushed a commit which I think addresses the strict encoding thing now.

[GitHub] [commons-codec] adamretter commented on issue #46: Base16 Input and Output Streams

2020-04-20 Thread GitBox
adamretter commented on issue #46: URL: https://github.com/apache/commons-codec/pull/46#issuecomment-616607129 Thanks @garydgregory from the API of `BaseNCodec` it was not at all clear that I had to support that. I can get that implemented soon. Are there any other things that I