[GitHub] [commons-codec] garydgregory commented on pull request #94: CODEC-303: Refactor NoOpBaseNCodec to improve test logic

2021-10-17 Thread GitBox
garydgregory commented on pull request #94: URL: https://github.com/apache/commons-codec/pull/94#issuecomment-945134566 Closing per comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [commons-codec] garydgregory commented on pull request #94: CODEC-303: Refactor NoOpBaseNCodec to improve test logic

2021-09-22 Thread GitBox
garydgregory commented on pull request #94: URL: https://github.com/apache/commons-codec/pull/94#issuecomment-925450260 Using Mockito here I feel falls under the old adage "Once you have a hammer, everything starts to look like a nail." The class in question is an abstract class and theref

[GitHub] [commons-codec] garydgregory commented on pull request #94: CODEC-303: Refactor NoOpBaseNCodec to improve test logic

2021-09-21 Thread GitBox
garydgregory commented on pull request #94: URL: https://github.com/apache/commons-codec/pull/94#issuecomment-924597345 While this seems like a clever use of Mockito, it hinders ease of understanding the code and maintenance IMO. Mocking is a great technique for certain use cases, th