[GitHub] [commons-collections] SilverNarcissus commented on issue #83: WIP: Initial bloom filter code contribution

2019-10-25 Thread GitBox
SilverNarcissus commented on issue #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-546305451 > I think that the use case for checking for a match against an existing filter should at least have some performance testi

[GitHub] [commons-collections] SilverNarcissus commented on issue #83: WIP: Initial bloom filter code contribution

2019-10-23 Thread GitBox
SilverNarcissus commented on issue #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-545711492 Let's make the situation more clear. In my consideration, I have a bloom filter (just call it b) which comprised of the mer

[GitHub] [commons-collections] SilverNarcissus commented on issue #83: WIP: Initial bloom filter code contribution

2019-10-21 Thread GitBox
SilverNarcissus commented on issue #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-544770518 For checking whether an object is in the bloom filter. Assuming we hash the object by 4 hash functions and there result is

[GitHub] [commons-collections] SilverNarcissus commented on issue #83: WIP: Initial bloom filter code contribution

2019-10-16 Thread GitBox
SilverNarcissus commented on issue #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-542955368 Hi~ Thanks for your work! I have a question about you use immutable bloom filter and if we want to judge whether an object