Simulant87 commented on PR #276:
URL:
https://github.com/apache/commons-collections/pull/276#issuecomment-1481857196
Thank you @aherbert and @Claudenw for your valuable comments.
I addressed them all with my recent changes. I decided to make my private
methods protected now to grant
Simulant87 commented on PR #276:
URL:
https://github.com/apache/commons-collections/pull/276#issuecomment-1480240789
@Claudenw I saw you were active on other pull requests. Could you please
review my pull request here as well? I just updated it to resolve a conflict.
--
This is an
Simulant87 commented on PR #276:
URL:
https://github.com/apache/commons-collections/pull/276#issuecomment-1350566817
@garydgregory May I request another review, to get my PR merged? I think the
PR is complete with a test covering the new code, no conflicts to the main
branch, and the
Simulant87 commented on pull request #276:
URL:
https://github.com/apache/commons-collections/pull/276#issuecomment-1050209446
Hello @kinow,
I saw that you are able to merge in this repository in another recent PR.
Would you also like to review my suggested changes in this PR, please?
Simulant87 commented on pull request #276:
URL:
https://github.com/apache/commons-collections/pull/276#issuecomment-1050206636
@freya022 thank you for your suggestion. This sounds like another high
performance improvement.
However it also sounds like the behaviour might slightly change
Simulant87 commented on pull request #276:
URL:
https://github.com/apache/commons-collections/pull/276#issuecomment-1038825792
@garydgregory Thank you for the feedback.
I added a test that verifies the `convertKey` method is only called once,
which fails currently on the master branch
Simulant87 commented on pull request #276:
URL:
https://github.com/apache/commons-collections/pull/276#issuecomment-1029455359
@garydgregory Thank you for the feedback.
I added a test the verifies the `convertKey` method is only called once,
which fails currently on the master branch
