[GitHub] [commons-collections] ben-manes commented on pull request #300: [COLLECTIONS-802] Fix remove failed by removing set null to currentKe…

2022-04-24 Thread GitBox
ben-manes commented on PR #300: URL: https://github.com/apache/commons-collections/pull/300#issuecomment-1107935459 Checking and I accidentally attached the wrong version of `ApacheMapTest`.  The flag `allowNulls` should have been false for `ReferenceMap`, and was there just

[GitHub] [commons-collections] ben-manes commented on pull request #300: [COLLECTIONS-802] Fix remove failed by removing set null to currentKe…

2022-04-24 Thread GitBox
ben-manes commented on PR #300: URL: https://github.com/apache/commons-collections/pull/300#issuecomment-1107932533 oops. I must have forgotten, not realized, or master has new failures. I very much like Guava’s collection tests as reusable and catch these minor mistakes. I’d recommend