dota17 commented on a change in pull request #123: [COLLECTIONS-739] Fix
inconsistent @throws comments in DefaultedMap
URL:
https://github.com/apache/commons-collections/pull/123#discussion_r354071920
##########
File path: src/main/java/org/apache/commons/collections4/map/DefaultedMap.java
##########
@@ -105,7 +105,8 @@
* @param map the map to decorate, must not be null
* @param factory the factory to use to create entries, must not be null
* @return a new defaulting map
- * @throws NullPointerException if map or factory is null
+ * @throws NullPointerException if map is null
+ * @throws IllegalArgumentException if factory is null
Review comment:
This is indeed a judgment of NullPointerException. It is recommended to
modify IllegalArgumentException to NullPointerException, and to supplement the
test cases for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
