[GitHub] [commons-collections] kinow commented on pull request #301: [COLLECTIONS-811] Integrate Guava Testlib tests for Apache Commons Collections

2022-04-30 Thread GitBox
kinow commented on PR #301: URL: https://github.com/apache/commons-collections/pull/301#issuecomment-1114077324 Rebased. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [commons-collections] kinow commented on pull request #301: [COLLECTIONS-811] Integrate Guava Testlib tests for Apache Commons Collections

2022-04-28 Thread GitBox
kinow commented on PR #301: URL: https://github.com/apache/commons-collections/pull/301#issuecomment-1112055774 And didn't notice a difference in build time. Executed a few times locally as well, and can confirm it doesn't bring any brittleness to our tests. Looks like a good addition to o

[GitHub] [commons-collections] kinow commented on pull request #301: [COLLECTIONS-811] Integrate Guava Testlib tests for Apache Commons Collections

2022-04-28 Thread GitBox
kinow commented on PR #301: URL: https://github.com/apache/commons-collections/pull/301#issuecomment-1112054324 Rebased. Confirmed the license is compatible (AL as well). Waiting for CI, and will update `changes.xml` in the meantime. Then it should be ready for review :+1: -- This is a