[GitHub] [commons-compress] PeterAlfredLee commented on pull request #214: [COMPRESS-584] Fix IOUtils.readRange() can read more from a channel than asked for

PeterAlfredLee commented on pull request #214: URL: https://github.com/apache/commons-compress/pull/214#issuecomment-896453094 Hi @matthijsln I want to merge this PR first. The current implementation didn't change much from original implemention. I will investigate into the "

[GitHub] [commons-compress] PeterAlfredLee commented on pull request #214: [COMPRESS-584] Fix IOUtils.readRange() can read more from a channel than asked for

PeterAlfredLee commented on pull request #214: URL: https://github.com/apache/commons-compress/pull/214#issuecomment-892526508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [commons-compress] PeterAlfredLee commented on pull request #214: [COMPRESS-584] Fix IOUtils.readRange() can read more from a channel than asked for

PeterAlfredLee commented on pull request #214: URL: https://github.com/apache/commons-compress/pull/214#issuecomment-893209493 This current implemention looks good to me now. For the "no copy buffer" version, it looks more efficient. But I'm not quite sure about this. I will try to m

[GitHub] [commons-compress] PeterAlfredLee commented on pull request #214: [COMPRESS-584] Fix IOUtils.readRange() can read more from a channel than asked for

PeterAlfredLee commented on pull request #214: URL: https://github.com/apache/commons-compress/pull/214#issuecomment-892526508 I prefer the one with a copy buffer. I'm not professional in IO but the implemention with buffer is pretty common in IO implementions. -- This is an autom

[GitHub] [commons-compress] PeterAlfredLee commented on pull request #214: [COMPRESS-584] Fix IOUtils.readRange() can read more from a channel than asked for

PeterAlfredLee commented on pull request #214: URL: https://github.com/apache/commons-compress/pull/214#issuecomment-892478291 > Note that for [COMPRESS-585](https://issues.apache.org/jira/browse/COMPRESS-585) I propose removing the limit to the max bytes read to COPY_BUF_SIZE altogether (

[GitHub] [commons-compress] PeterAlfredLee commented on pull request #214: [COMPRESS-584] Fix IOUtils.readRange() can read more from a channel than asked for

PeterAlfredLee commented on pull request #214: URL: https://github.com/apache/commons-compress/pull/214#issuecomment-892466407 Hi @matthijsln Please have a look at my reply :-) > When the len of bytes to read is bigger than COPY_BUF_SIZE, there are some problems. You can reproduce

[GitHub] [commons-compress] PeterAlfredLee commented on pull request #214: [COMPRESS-584] Fix IOUtils.readRange() can read more from a channel than asked for

PeterAlfredLee commented on pull request #214: URL: https://github.com/apache/commons-compress/pull/214#issuecomment-892459986 The new implemention also has some problems : 1. The test `readRangeFromChannelStopsIfThereIsNothingToReadAnymore` is failed 2. When the `len` of bytes to rea

[GitHub] [commons-compress] PeterAlfredLee commented on pull request #214: [COMPRESS-584] Fix IOUtils.readRange() can read more from a channel than asked for

PeterAlfredLee commented on pull request #214: URL: https://github.com/apache/commons-compress/pull/214#issuecomment-892419298 Good catch! This looks good to me. Thanks for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message