[GitHub] [commons-compress] bodewig commented on issue #84: COMPRESS-477 Add support for extracting splitted zip files

2019-12-08 Thread GitBox
bodewig commented on issue #84: COMPRESS-477 Add support for extracting splitted zip files URL: https://github.com/apache/commons-compress/pull/84#issuecomment-562942818 @PeterAlfreadLee I'll merge this PR and perform some minor changes that I'd ask you to look at once I've pushed things.

[GitHub] [commons-compress] bodewig commented on issue #84: COMPRESS-477 Add support for extracting splitted zip files

2019-12-01 Thread GitBox
bodewig commented on issue #84: COMPRESS-477 Add support for extracting splitted zip files URL: https://github.com/apache/commons-compress/pull/84#issuecomment-560235408 Obviously this has been my fault and I had to "submit" the review in order to make it visible. Sorry for the confusion a

[GitHub] [commons-compress] bodewig commented on issue #84: COMPRESS-477 Add support for extracting splitted zip files

2019-12-01 Thread GitBox
bodewig commented on issue #84: COMPRESS-477 Add support for extracting splitted zip files URL: https://github.com/apache/commons-compress/pull/84#issuecomment-560137512 @PeterAlfreadLee there are a couple of review comments I made at the same time I commented about having a separate PR fo

[GitHub] [commons-compress] bodewig commented on issue #84: COMPRESS-477 Add support for extracting splitted zip files

2019-12-01 Thread GitBox
bodewig commented on issue #84: COMPRESS-477 Add support for extracting splitted zip files URL: https://github.com/apache/commons-compress/pull/84#issuecomment-560137003 Before I start another round of review here, this is from Linux `unzip` manual > Multi-part archives are n

[GitHub] [commons-compress] bodewig commented on issue #84: COMPRESS-477 Add support for extracting splitted zip files

2019-11-02 Thread GitBox
bodewig commented on issue #84: COMPRESS-477 Add support for extracting splitted zip files URL: https://github.com/apache/commons-compress/pull/84#issuecomment-549057606 Many thanks again @PeterAlfreadLee Please don't take my review comments as a pushback, many of them are minor. O

[GitHub] [commons-compress] bodewig commented on issue #84: COMPRESS-477 Add support for extracting splitted zip files

2019-11-02 Thread GitBox
bodewig commented on issue #84: COMPRESS-477 Add support for extracting splitted zip files URL: https://github.com/apache/commons-compress/pull/84#issuecomment-549055156 I agree it would be better to separate it into a new PR. I'm not sure if/how the creation code would overlap with

[GitHub] [commons-compress] bodewig commented on issue #84: COMPRESS-477 Add support for extracting splitted zip files

2019-10-27 Thread GitBox
bodewig commented on issue #84: COMPRESS-477 Add support for extracting splitted zip files URL: https://github.com/apache/commons-compress/pull/84#issuecomment-546686157 Many thanks @PeterAlfreadLee I'll need some time to fully review the PR. As for `ZipArchiveInputStream` I complete