bodewig commented on issue #86: COMPRESS-477 building a split zip
URL: https://github.com/apache/commons-compress/pull/86#issuecomment-569591435
@PeterAlfreadLee please have a look at 57664d91 and check I haven't made any
mistakes.
--
bodewig commented on issue #86: COMPRESS-477 building a split zip
URL: https://github.com/apache/commons-compress/pull/86#issuecomment-565799612
@PeterAlfreadLee please take a look at my changes in 26c7aff
I think all that needs to be done now is document split support inside of
the
bodewig commented on issue #86: COMPRESS-477 building a split zip
URL: https://github.com/apache/commons-compress/pull/86#issuecomment-565797653
@PeterAlfreadLee the openjdk-ea build is failing in master as well. It
probably either is a problem that exists in master anyway or a problem with
bodewig commented on issue #86: COMPRESS-477 building a split zip
URL: https://github.com/apache/commons-compress/pull/86#issuecomment-563063669
@trejkaz I won't make any promises but I intend to propose a new release
once this PR and #87 are in - and I've looked through the latest JIRA iss
bodewig commented on issue #86: COMPRESS-477 building a split zip
URL: https://github.com/apache/commons-compress/pull/86#issuecomment-562991230
https://github.com/bodewig/commons-compress/tree/COMPRESS-477-constructing
holds a rebased version of this PR, I'd be happy if you just applied si
bodewig commented on issue #86: COMPRESS-477 building a split zip
URL: https://github.com/apache/commons-compress/pull/86#issuecomment-560234164
Sorry, I misunderstood github's code review feature and wasn't aware I was
the only one who could see it until I "sumitted" the review. There was
bodewig commented on issue #86: COMPRESS-477 building a split zip
URL: https://github.com/apache/commons-compress/pull/86#issuecomment-560233565
For me there is a "@bodewig started a review" section right on this
conversation page and I see my comments inline inside of the Files panel. But
bodewig commented on issue #86: COMPRESS-477 building a split zip
URL: https://github.com/apache/commons-compress/pull/86#issuecomment-560142927
@PeterAlfreadLee this looks very good overall, many thanks. I've added a few
review comments. Apart from that some `@since` markers and javadocs w
