[GitHub] [commons-compress] theobisproject commented on pull request #120: COMPRESS-542: Lazy allocation of SevenZArchiveEntry to prevent OOM on corrupt files

2020-08-15 Thread GitBox
theobisproject commented on pull request #120: URL: https://github.com/apache/commons-compress/pull/120#issuecomment-674373279 I am using this project https://github.com/rohanpadhye/jqf to do the fuzzing via the AFL bridge provided. This was the fuzz method implementation I used ```java

[GitHub] [commons-compress] theobisproject commented on pull request #120: COMPRESS-542: Lazy allocation of SevenZArchiveEntry to prevent OOM on corrupt files

2020-08-13 Thread GitBox
theobisproject commented on pull request #120: URL: https://github.com/apache/commons-compress/pull/120#issuecomment-673640854 In the files I got from the fuzzing I noticed that even the array creation can lead to an OOM exception. I tried to replace it with a list and let it grow as

[GitHub] [commons-compress] theobisproject commented on pull request #120: COMPRESS-542: Lazy allocation of SevenZArchiveEntry to prevent OOM on corrupt files

2020-08-09 Thread GitBox
theobisproject commented on pull request #120: URL: https://github.com/apache/commons-compress/pull/120#issuecomment-671175522 The test files @akelday attached to the jira issue are replicating the issue. Since this issue is dependend on the available Java heap it could be difficult to

[GitHub] [commons-compress] theobisproject commented on pull request #120: COMPRESS-542: Lazy allocation of SevenZArchiveEntry to prevent OOM on corrupt files

2020-08-05 Thread GitBox
theobisproject commented on pull request #120: URL: https://github.com/apache/commons-compress/pull/120#issuecomment-669688765 Just a short update. I will try to generate a reproducting file via fuzzing which is hopefully successful. This might take some days but I think at the end of the

[GitHub] [commons-compress] theobisproject commented on pull request #120: COMPRESS-542: Lazy allocation of SevenZArchiveEntry to prevent OOM on corrupt files

2020-08-04 Thread GitBox
theobisproject commented on pull request #120: URL: https://github.com/apache/commons-compress/pull/120#issuecomment-668600127 > My biggest issue with this PR is that it is missing a unit test. Without a failing unit test, there is no way to know that this fixes anything or that a future

[GitHub] [commons-compress] theobisproject commented on pull request #120: COMPRESS-542: Lazy allocation of SevenZArchiveEntry to prevent OOM on corrupt files

2020-08-04 Thread GitBox
theobisproject commented on pull request #120: URL: https://github.com/apache/commons-compress/pull/120#issuecomment-668591608 As you are a bit more familiar with the 7z archive maybe you have an idea how to avoid the entry allocation completely before we are sure the header is not

[GitHub] [commons-compress] theobisproject commented on pull request #120: COMPRESS-542: Lazy allocation of SevenZArchiveEntry to prevent OOM on corrupt files

2020-08-04 Thread GitBox
theobisproject commented on pull request #120: URL: https://github.com/apache/commons-compress/pull/120#issuecomment-668585383 Hi @PeterAlfredLee as explained in the Jira Ticket it was a corrupted archive where the `numFiles` variable read from the header in `readFilesInfo` was about