[GitHub] [commons-configuration] BranislavBeno commented on pull request #229: CONFIGURATION-822: Fix ambiguity on the section determining

2022-11-06 Thread GitBox
BranislavBeno commented on PR #229: URL: https://github.com/apache/commons-configuration/pull/229#issuecomment-1305180959 > I might update the constructor after a merge to be private and use a builder to avoid the proliferation of constructors... Thank you for PR accepting. Builde

[GitHub] [commons-configuration] BranislavBeno commented on pull request #229: CONFIGURATION-822: Fix ambiguity on the section determining

2022-10-19 Thread GitBox
BranislavBeno commented on PR #229: URL: https://github.com/apache/commons-configuration/pull/229#issuecomment-1284607829 It seems, that inline comments are already allowed, however, currently only on value lines. Tested with e.g.: [TestINIConfiguration#testValueWithComment](https://g

[GitHub] [commons-configuration] BranislavBeno commented on pull request #229: CONFIGURATION-822: Fix ambiguity on the section determining

2022-10-18 Thread GitBox
BranislavBeno commented on PR #229: URL: https://github.com/apache/commons-configuration/pull/229#issuecomment-1283072066 > Which INI specification are you implementing? AFIK a semicolon for a comment is only legal at the start of a line (https://en.m.wikipedia.org/wiki/INI_file) Ho