[GitHub] [commons-digester] nhojpatrick commented on pull request #7: JUnit assertThrows

2022-10-19 Thread GitBox
nhojpatrick commented on PR #7: URL: https://github.com/apache/commons-digester/pull/7#issuecomment-1284426626 Splitting into separate PR as if this takes ages to get merged it's easier to rebase. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [commons-digester] nhojpatrick commented on pull request #7: JUnit assertThrows

2020-10-17 Thread GitBox
nhojpatrick commented on pull request #7: URL: https://github.com/apache/commons-digester/pull/7#issuecomment-710923812 Ready to be merged, only looking at replacing `@Test(expected = Exception.class)` with `assertThrows` in this pr. I will raise another pr to cover replacing `try/catch/fa