ecki commented on code in PR #112:
URL: https://github.com/apache/commons-exec/pull/112#discussion_r1264679931


##########
src/site/apt/tutorial.apt:
##########
@@ -169,7 +169,7 @@ executor.execute(cmdLine, resultHandler);
 
 // some time later the result handler callback was invoked so we
 // can safely request the exit value
-int exitValue = resultHandler.waitFor();
+resultHandler.waitFor();

Review Comment:
   Looks good - maybe in the future we should use snippets or at least have a 
copy in a test class.
   
   you might need to add the changes.xml entry?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to