[GitHub] [commons-exec] garydgregory commented on a diff in pull request #27: [EXEC-114] - Migrate to Junit 5

2022-12-04 Thread GitBox
garydgregory commented on code in PR #27: URL: https://github.com/apache/commons-exec/pull/27#discussion_r1039045760 ## src/test/java/org/apache/commons/exec/issues/Exec65Test.java: ## @@ -38,7 +45,9 @@ */ public class Exec65Test extends AbstractExecTest { -@Test(expect

[GitHub] [commons-exec] garydgregory commented on a diff in pull request #27: [EXEC-114] - Migrate to Junit 5

2022-12-04 Thread GitBox
garydgregory commented on code in PR #27: URL: https://github.com/apache/commons-exec/pull/27#discussion_r1038976837 ## pom.xml: ## @@ -107,8 +107,23 @@ Niall Pemberton + +Arturo Bernal + + Review Comment:

[GitHub] [commons-exec] garydgregory commented on a diff in pull request #27: [EXEC-114] - Migrate to Junit 5

2022-12-03 Thread GitBox
garydgregory commented on code in PR #27: URL: https://github.com/apache/commons-exec/pull/27#discussion_r1038870739 ## pom.xml: ## @@ -173,6 +188,14 @@ + Review Comment: @arturobernalg Is this really need